Update dependency monaco-editor to ^0.52.2 #225731
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
added
release_note:skip
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
2 times, most recently
from
e5c2574 to
d6cb9a3
Compare
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
from
d6cb9a3 to
93c94a6
Compare
Contributor
Author
|
/ci |
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
from
0ecf5a9 to
cfc9576
Compare
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
from
8750165 to
2a6b8d7
Compare
Contributor
Author
|
/ci |
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
from
2a6b8d7 to
923f173
Compare
Contributor
Author
|
/ci |
eokoneyo
force-pushed
the
chore/monaco-upgrade
branch
from
56f8c28 to
c6ca6a1
Compare
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @eokoneyo |
| }, | ||
| ], | ||
| }, | ||
| optimization: { |
Contributor
There was a problem hiding this comment.
Could you please tell me why you are removing this?
Contributor
Author
There was a problem hiding this comment.
in the version we upgrading away from, the file referenced in the exclude pattern because it was already transform although to ESM, when we include it to be optimized (i.e treeshaking and the likes) it would break hence why we excluded it from any kind of optimization and just use as is
Contributor
Author
There was a problem hiding this comment.
...in the new version, it doesn't cause any issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Culled from #206176.
The original PR was reverted.