[GenAi] Clean up default LLM setting feature flag.#242543
Merged
KDKHD merged 10 commits intoelastic:mainfrom Nov 17, 2025
Merged
[GenAi] Clean up default LLM setting feature flag.#242543KDKHD merged 10 commits intoelastic:mainfrom
KDKHD merged 10 commits intoelastic:mainfrom
Conversation
Member
Author
|
/ci |
KDKHD
changed the title
KDKHD
added
release_note:skip
KDKHD
commented
Nov 11, 2025
Comment on lines
+30
to
+32
| settings.SECURITY_SOLUTION_DEFAULT_VALUE_REPORT_MINUTES, | ||
| settings.SECURITY_SOLUTION_DEFAULT_VALUE_REPORT_RATE, | ||
| settings.SECURITY_SOLUTION_DEFAULT_VALUE_REPORT_TITLE, |
Member
Author
There was a problem hiding this comment.
@stephmilovic, while cleaning up x-pack/solutions/security/plugins/security_solution_serverless/server/plugin.ts and removing the old default llm setting, I noticed that the other value report settings were not whitelisted in here. Were these intentionally not whitelisted before?
KDKHD
commented
Nov 11, 2025
| uiSettings.register(orderSettings(securityUiSettings)); | ||
| }; | ||
|
|
||
| export const getDefaultAIConnectorSetting = ( |
Member
Author
There was a problem hiding this comment.
The old default LLM setting has been replaced with the global one.
Member
Author
|
@elasticmachine merge upstream |
Dosant
approved these changes
Nov 11, 2025
andrew-goldstein
approved these changes
Nov 12, 2025
damian-polewski
approved these changes
Nov 12, 2025
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
KDKHD
added a commit
to KDKHD/kibana
that referenced
this pull request
Nov 17, 2025
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. Removes the `aiAssistant.defaultLlmSettingEnabled` feature flag and associated cleanup. ### Changes - **Removed feature flag**: Deleted `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both `gen_ai_settings` and `security_solution` plugins - **Simplified code**: Removed all feature flag checks - now always uses the new default connector behavior - **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to `@kbn/management-settings-ids` package to avoid duplication - **Fixed serverless**: Added value report settings to `SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async wrapper in `security_solution_serverless` plugin - Serverless settings properly whitelisted for value report features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 2c75d4f) # Conflicts: # x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.json
Member
Author
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
KDKHD
added a commit
to KDKHD/kibana
that referenced
this pull request
Nov 17, 2025
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. Removes the `aiAssistant.defaultLlmSettingEnabled` feature flag and associated cleanup. ### Changes - **Removed feature flag**: Deleted `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both `gen_ai_settings` and `security_solution` plugins - **Simplified code**: Removed all feature flag checks - now always uses the new default connector behavior - **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to `@kbn/management-settings-ids` package to avoid duplication - **Fixed serverless**: Added value report settings to `SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async wrapper in `security_solution_serverless` plugin - Serverless settings properly whitelisted for value report features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 2c75d4f) # Conflicts: # src/platform/packages/shared/kbn-management/settings/setting_ids/index.ts # src/platform/packages/shared/serverless/settings/security_project/index.ts # x-pack/platform/plugins/private/gen_ai_settings/public/components/gen_ai_settings_app.test.tsx # x-pack/platform/plugins/private/gen_ai_settings/public/components/gen_ai_settings_app.tsx # x-pack/solutions/security/plugins/security_solution/common/constants.ts # x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.test.ts # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/executive_summary.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/index.tsx # x-pack/solutions/security/plugins/security_solution/server/ui_settings.ts # x-pack/solutions/security/plugins/security_solution/tsconfig.json # x-pack/solutions/security/plugins/security_solution_serverless/server/plugin.ts # x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.json
KDKHD
added a commit
to KDKHD/kibana
that referenced
this pull request
Nov 17, 2025
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. Removes the `aiAssistant.defaultLlmSettingEnabled` feature flag and associated cleanup. ### Changes - **Removed feature flag**: Deleted `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both `gen_ai_settings` and `security_solution` plugins - **Simplified code**: Removed all feature flag checks - now always uses the new default connector behavior - **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to `@kbn/management-settings-ids` package to avoid duplication - **Fixed serverless**: Added value report settings to `SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async wrapper in `security_solution_serverless` plugin - Serverless settings properly whitelisted for value report features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 2c75d4f) # Conflicts: # src/platform/packages/shared/kbn-management/settings/setting_ids/index.ts # src/platform/packages/shared/serverless/settings/security_project/index.ts # x-pack/platform/plugins/private/gen_ai_settings/public/components/gen_ai_settings_app.test.tsx # x-pack/platform/plugins/private/gen_ai_settings/public/components/gen_ai_settings_app.tsx # x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.test.ts # x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_default_ai_connector_id.ts # x-pack/solutions/security/plugins/security_solution/public/flyout/ai_for_soc/components/connector_missing_callout.test.tsx # x-pack/solutions/security/plugins/security_solution/public/flyout/ai_for_soc/components/connector_missing_callout.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/executive_summary.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/index.test.tsx # x-pack/solutions/security/plugins/security_solution/public/reports/components/ai_value/index.tsx # x-pack/solutions/security/plugins/security_solution/server/ui_settings.ts # x-pack/solutions/security/plugins/security_solution/tsconfig.json # x-pack/solutions/security/plugins/security_solution_serverless/server/plugin.ts # x-pack/solutions/security/plugins/security_solution_serverless/tsconfig.json
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
KDKHD
added a commit
that referenced
this pull request
Nov 20, 2025
…243234) # Backport This will backport the following commits from `main` to `9.2`: - [[GenAi] Clean up default LLM setting feature flag. (#242543)](#242543) <!--- Backport version: 10.2.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Kenneth Kreindler","email":"42113355+KDKHD@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-11-17T15:35:04Z","message":"[GenAi] Clean up default LLM setting feature flag. (#242543)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\nRemoves the `aiAssistant.defaultLlmSettingEnabled` feature flag and\nassociated cleanup.\n\n### Changes\n\n- **Removed feature flag**: Deleted\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both\n`gen_ai_settings` and `security_solution` plugins\n- **Simplified code**: Removed all feature flag checks - now always uses\nthe new default connector behavior\n- **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to\n`@kbn/management-settings-ids` package to avoid duplication\n- **Fixed serverless**: Added value report settings to\n`SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async\nwrapper in `security_solution_serverless` plugin\n- Serverless settings properly whitelisted for value report features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c75d4f550dc5a8308d291e542a8728296ed7d4e","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.1.0","v8.19.0","v9.2.0","v9.3.0"],"title":"[GenAi] Clean up default LLM setting feature flag.","number":242543,"url":"https://github.com/elastic/kibana/pull/242543","mergeCommit":{"message":"[GenAi] Clean up default LLM setting feature flag. (#242543)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\nRemoves the `aiAssistant.defaultLlmSettingEnabled` feature flag and\nassociated cleanup.\n\n### Changes\n\n- **Removed feature flag**: Deleted\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both\n`gen_ai_settings` and `security_solution` plugins\n- **Simplified code**: Removed all feature flag checks - now always uses\nthe new default connector behavior\n- **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to\n`@kbn/management-settings-ids` package to avoid duplication\n- **Fixed serverless**: Added value report settings to\n`SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async\nwrapper in `security_solution_serverless` plugin\n- Serverless settings properly whitelisted for value report features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c75d4f550dc5a8308d291e542a8728296ed7d4e"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19","9.2"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/242543","number":242543,"mergeCommit":{"message":"[GenAi] Clean up default LLM setting feature flag. (#242543)\n\n## Summary\n\nSummarize your PR. If it involves visual changes include a screenshot or\ngif.\n\nRemoves the `aiAssistant.defaultLlmSettingEnabled` feature flag and\nassociated cleanup.\n\n### Changes\n\n- **Removed feature flag**: Deleted\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and\n`AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both\n`gen_ai_settings` and `security_solution` plugins\n- **Simplified code**: Removed all feature flag checks - now always uses\nthe new default connector behavior\n- **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to\n`@kbn/management-settings-ids` package to avoid duplication\n- **Fixed serverless**: Added value report settings to\n`SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async\nwrapper in `security_solution_serverless` plugin\n- Serverless settings properly whitelisted for value report features\n\n### Checklist\n\nCheck the PR satisfies following conditions. \n\nReviewers should verify this PR satisfies this list as well.\n\n- [X] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)\n- [X]\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\nwas added for features that require explanation or tutorials\n- [X] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [X] If a plugin configuration key changed, check if it needs to be\nallowlisted in the cloud and added to the [docker\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\n- [X] This was checked for breaking HTTP API changes, and any breaking\nchanges have been approved by the breaking-change committee. The\n`release_note:breaking` label should be applied in these situations.\n- [X] [Flaky Test\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\nused on any tests changed\n- [X] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [X] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\n### Identify risks\n\nDoes this PR introduce any risks? For example, consider risks like hard\nto test bugs, performance regression, potential of data loss.\n\nDescribe the risk, its severity, and mitigation for each identified\nrisk. Invite stakeholders and evaluate how to proceed before merging.\n\n- [ ] [See some risk\nexamples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)\n- [ ] ...\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c75d4f550dc5a8308d291e542a8728296ed7d4e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
7 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Dec 2, 2025
## Summary Summarize your PR. If it involves visual changes include a screenshot or gif. Removes the `aiAssistant.defaultLlmSettingEnabled` feature flag and associated cleanup. ### Changes - **Removed feature flag**: Deleted `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED` and `AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUE` constants from both `gen_ai_settings` and `security_solution` plugins - **Simplified code**: Removed all feature flag checks - now always uses the new default connector behavior - **Centralized constants**: Moved `DEFAULT_VALUE_REPORT_*` settings to `@kbn/management-settings-ids` package to avoid duplication - **Fixed serverless**: Added value report settings to `SECURITY_PROJECT_SETTINGS` whitelist and removed unnecessary async wrapper in `security_solution_serverless` plugin - Serverless settings properly whitelisted for value report features ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [X] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [X] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [X] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [X] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [X] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [X] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
2 similar comments
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
KDKHD
added
backport:skip
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Removes the
aiAssistant.defaultLlmSettingEnabledfeature flag and associated cleanup.Changes
AI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLEDandAI_ASSISTANT_DEFAULT_LLM_SETTING_ENABLED_VALUEconstants from bothgen_ai_settingsandsecurity_solutionpluginsDEFAULT_VALUE_REPORT_*settings to@kbn/management-settings-idspackage to avoid duplicationSECURITY_PROJECT_SETTINGSwhitelist and removed unnecessary async wrapper insecurity_solution_serverlesspluginChecklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.