[SideNav] v1 NavTree Structure Clean-Up by Dosant · Pull Request #241943 · elastic/kibana

Dosant · 2025-11-05T10:48:23Z

Summary

Follow up to #241114

This time we cleaning up everything related to the navigation trees structure that is no longer needed in new nav

Platform @Dosant
Search @Dosant (@TattdCodeMonkey to review)
Oblt @justinkambic
Security @ashokaditya

Guidance:

Use TypeScript errors to see what needs to be cleaned up:
All V1 property no longer needed. Please Review. V1 branches no longer needed
V2 properties renamed: iconV2 -> icon; badgeTypeV2 -> badgeType
Body and Footer no longer need intermediate root nodes! The nav nodes should go directly under body: [/* nodes / ], footer: [/ footer */]
@justinkambic, @ashokaditya, use search trees as an example. I cleaned it up.

Dosant · 2025-11-05T11:25:41Z

x-pack/solutions/search/plugins/serverless_search/public/navigation_tree.ts

 });

 export const navigationTree = ({ isAppRegistered }: ApplicationStart): NavigationTreeDefinition => {
-  function isAvailable<T>(appId: string, content: T): T[] {


no need for this check afaik because it should be handled by navlinks status.

I agree, I'd have to look through to git blame to see when this got added an what it was trying to address since nav link should have always handled this.

…up-2

…/sidenav-cleanup-2

…up-2

smith

obs-ui changes look good.

…up-2

abhishekbhatia1710

LGTM

…up-2

PhilippeOberti

Approving to unblock the PR but I'm still a bit confused about why the Value report is not working

elasticmachine · 2025-11-25T15:34:41Z

⏳ Build in-progress

Buildkite Build
Commit: 6db2354
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-241943-6db2354d7b34

Failed CI Steps

FTR Configs #40

Test Failures

[job] [logs] FTR Configs #40 / Serverless Common UI - Management Data View Management index pattern filter "after all" hook for "should set "conflict" filter when "View conflicts" button is pressed"
[job] [logs] FTR Configs #40 / Serverless Common UI - Management Data View Management index pattern filter "before all" hook for "should filter indexed fields by type"

History

💔 Build #364854 failed 2768b3f
💛 Build #364360 was flaky 26aba27
💛 Build #364048 was flaky b9a4ba8
💛 Build #363327 was flaky 80fe569
💛 Build #363266 was flaky cfbd230

justinkambic

LGTM

@Dosant

## Summary Follow up to elastic#241114 This time we cleaning up everything related to the navigation trees structure that is no longer needed in new nav - [x] Platform @Dosant - [x] Search @Dosant (@TattdCodeMonkey to review) - [x] Oblt @justinkambic - [x] Security @ashokaditya Guidance: - Use TypeScript errors to see what needs to be cleaned up: - All V1 property no longer needed. Please Review. V1 branches no longer needed - V2 properties renamed: iconV2 -> icon; badgeTypeV2 -> badgeType - Body and Footer no longer need intermediate root nodes! The nav nodes should go directly under body: [/* nodes */ ], footer: [/* footer */] - @justinkambic, @ashokaditya, use search trees as an example. I cleaned it up. --------- Co-authored-by: Justin Kambic <jk@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <ashokaditya@elastic.co>

@Dosant

## Summary Follow up to elastic#241114 This time we cleaning up everything related to the navigation trees structure that is no longer needed in new nav - [x] Platform @Dosant - [x] Search @Dosant (@TattdCodeMonkey to review) - [x] Oblt @justinkambic - [x] Security @ashokaditya Guidance: - Use TypeScript errors to see what needs to be cleaned up: - All V1 property no longer needed. Please Review. V1 branches no longer needed - V2 properties renamed: iconV2 -> icon; badgeTypeV2 -> badgeType - Body and Footer no longer need intermediate root nodes! The nav nodes should go directly under body: [/* nodes */ ], footer: [/* footer */] - @justinkambic, @ashokaditya, use search trees as an example. I cleaned it up. --------- Co-authored-by: Justin Kambic <jk@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <ashokaditya@elastic.co>

@Dosant

## Summary Follow up to elastic#241114 This time we cleaning up everything related to the navigation trees structure that is no longer needed in new nav - [x] Platform @Dosant - [x] Search @Dosant (@TattdCodeMonkey to review) - [x] Oblt @justinkambic - [x] Security @ashokaditya Guidance: - Use TypeScript errors to see what needs to be cleaned up: - All V1 property no longer needed. Please Review. V1 branches no longer needed - V2 properties renamed: iconV2 -> icon; badgeTypeV2 -> badgeType - Body and Footer no longer need intermediate root nodes! The nav nodes should go directly under body: [/* nodes */ ], footer: [/* footer */] - @justinkambic, @ashokaditya, use search trees as an example. I cleaned it up. --------- Co-authored-by: Justin Kambic <jk@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <ashokaditya@elastic.co>

@Dosant

## Summary Follow up to elastic#241114 This time we cleaning up everything related to the navigation trees structure that is no longer needed in new nav - [x] Platform @Dosant - [x] Search @Dosant (@TattdCodeMonkey to review) - [x] Oblt @justinkambic - [x] Security @ashokaditya Guidance: - Use TypeScript errors to see what needs to be cleaned up: - All V1 property no longer needed. Please Review. V1 branches no longer needed - V2 properties renamed: iconV2 -> icon; badgeTypeV2 -> badgeType - Body and Footer no longer need intermediate root nodes! The nav nodes should go directly under body: [/* nodes */ ], footer: [/* footer */] - @justinkambic, @ashokaditya, use search trees as an example. I cleaned it up. --------- Co-authored-by: Justin Kambic <jk@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Ashokaditya <ashokaditya@elastic.co>

wip clean up nav trees structure. clean up search tress

0b4053b

Dosant requested review from TattdCodeMonkey, ashokaditya and justinkambic November 5, 2025 10:50

Dosant commented Nov 5, 2025

View reviewed changes

justinkambic and others added 14 commits November 5, 2025 14:31

Implement changes for Observability ECH and Serverless nav.

61be02c

Merge branch 'main' of github.com:elastic/kibana into d/sidenav-clean…

74f6461

…up-2

Merge branch 'd/sidenav-cleanup-2' of github.com:Dosant/kibana into d…

83b9b7d

…/sidenav-cleanup-2

remove redundant level

3fd00be

move level up, fix home, fix tests

5353f3f

Changes from node scripts/generate codeowners

b9e7066

remove i18n

f86cc38

Merge branch 'd/sidenav-cleanup-2' of github.com:Dosant/kibana into d…

9b0f612

…/sidenav-cleanup-2

Merge branch 'main' of github.com:elastic/kibana into d/sidenav-clean…

30d52a0

…up-2

clean test utils

acb22a5

fix nav service tests

f17fccf

fix tests ts

4fe6179

Merge branch 'main' into d/sidenav-cleanup-2

5c6f70f

Merge branch 'main' into d/sidenav-cleanup-2

9f1f280

justinkambic mentioned this pull request Nov 13, 2025

Implement new side nav for Observability #232456

Closed

Dosant and others added 7 commits November 14, 2025 11:45

Merge branch 'main' of github.com:elastic/kibana into d/sidenav-clean…

f0997ff

…up-2

security ECH nav tree cleanup

ba484fc

move custom icons and export

d8b3ad1

Update deep_links.ts

f148238

Serverless EASE Nav cleanup

12ce683

ECH missing nav ids for launchpad sub links

d8535a7

serverless essentials/complete tier nav cleanup

a5caee3

ashokaditya force-pushed the d/sidenav-cleanup-2 branch from 4812f31 to a5caee3 Compare November 17, 2025 10:01

ashokaditya added 2 commits November 17, 2025 11:02

cleanup redundant footer children ECH nav

9a1e97a

cleanup redundant footer children EASE nav

cc64b5c

smith approved these changes Nov 20, 2025

View reviewed changes

Dosant added 4 commits November 20, 2025 15:58

fix incorrect cases link

1e4e2b4

fix

cfbd230

Merge branch 'main' of github.com:elastic/kibana into d/sidenav-clean…

b513f43

…up-2

fix

80fe569

abhishekbhatia1710 approved these changes Nov 21, 2025

View reviewed changes

Dosant and others added 3 commits November 23, 2025 12:58

Merge branch 'main' into d/sidenav-cleanup-2

b9a4ba8

Merge branch 'main' of github.com:elastic/kibana into d/sidenav-clean…

73c6794

…up-2

Changes from node scripts/regenerate_moon_projects.js --update

26aba27

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner November 24, 2025 14:14

PhilippeOberti approved these changes Nov 24, 2025

View reviewed changes

botelastic bot added the Team:obs-ux-management label Nov 24, 2025

Ikuni17 approved these changes Nov 25, 2025

View reviewed changes

Dosant and others added 2 commits November 25, 2025 11:08

Merge branch 'main' into d/sidenav-cleanup-2

3d79c2d

Changes from node scripts/regenerate_moon_projects.js --update

2768b3f

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner November 25, 2025 10:31

Dosant and others added 3 commits November 25, 2025 13:26

Merge branch 'main' into d/sidenav-cleanup-2

24cae73

Merge branch 'main' into d/sidenav-cleanup-2

0eae704

Changes from node scripts/regenerate_moon_projects.js --update

6db2354

Dosant removed the request for review from a team November 25, 2025 14:16

justinkambic approved these changes Nov 25, 2025

View reviewed changes

Dosant enabled auto-merge (squash) November 25, 2025 16:10

Dosant merged commit e96cf28 into elastic:main Nov 25, 2025
13 checks passed

kibanamachine added the v9.3.0 label Nov 25, 2025

PhilippeOberti mentioned this pull request Dec 12, 2025

[Security Solution] remove newDataViewPickerEnabled feature flag #238549

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SideNav] v1 NavTree Structure Clean-Up#241943

[SideNav] v1 NavTree Structure Clean-Up#241943
Dosant merged 49 commits intoelastic:mainfrom
Dosant:d/sidenav-cleanup-2

Dosant commented Nov 5, 2025 •

edited by ashokaditya

Loading

Uh oh!

Dosant Nov 5, 2025 •

edited

Loading

Uh oh!

TattdCodeMonkey Nov 18, 2025

Uh oh!

smith left a comment

Uh oh!

abhishekbhatia1710 left a comment

Uh oh!

PhilippeOberti left a comment

Uh oh!

elasticmachine commented Nov 25, 2025

Uh oh!

justinkambic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Conversation

Dosant commented Nov 5, 2025 • edited by ashokaditya Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Dosant Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TattdCodeMonkey Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

smith left a comment

Choose a reason for hiding this comment

Uh oh!

abhishekbhatia1710 left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 25, 2025

⏳ Build in-progress

Failed CI Steps

Test Failures

History

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

Dosant commented Nov 5, 2025 •

edited by ashokaditya

Loading

Dosant Nov 5, 2025 •

edited

Loading