Skip to content

[Fleet] Backport lock manager service usage#242210

Merged
juliaElastic merged 2 commits into8.19from
backport-lock-manager-service-usage
Nov 7, 2025
Merged

[Fleet] Backport lock manager service usage#242210
juliaElastic merged 2 commits into8.19from
backport-lock-manager-service-usage

Conversation

@nchaulet
Copy link
Member

@nchaulet nchaulet commented Nov 6, 2025

Summary

Backport #219113

We are hitting some retries issue during setup, and relying on the lock manager service as we do in 9+ version seems to be more reliable

@nchaulet nchaulet requested review from a team and Supplementing November 6, 2025 22:42
@nchaulet nchaulet self-assigned this Nov 6, 2025
@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 6, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@Supplementing
Copy link
Contributor

Supplementing commented Nov 6, 2025

Looking at the original PR, this one is missing the changes to tsconfig.json. Are they needed here? https://github.com/elastic/kibana/pull/219113/files

@Supplementing
Copy link
Contributor

Also, do we need to bring in the changes from #219220 that expose lockManager as a package? I see it was a dependency for the original PR, so not sure if that will have any effect on these changes.

Copy link
Contributor

@Supplementing Supplementing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments, but otherwise, LGTM 🚀

@nchaulet
Copy link
Member Author

nchaulet commented Nov 6, 2025

Also, do we need to bring in the changes from #219220 that expose lockManager as a package? I see it was a dependency for the original PR, so not sure if that will have any effect on these changes.

Luckily this one was already backported to 8.19,

Looking at the original PR, this one is missing the changes to tsconfig.json. Are they needed here? https://github.com/elastic/kibana/pull/219113/files

Yes they are, I just updated

@Supplementing
Copy link
Contributor

Luckily this one was already backported to 8.19,

I saw the backport had failed but missed where it succeeded, thanks for clarifying!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / Connector renders correctly

Metrics [docs]

✅ unchanged

cc @nchaulet

@jlind23
Copy link
Contributor

jlind23 commented Nov 7, 2025

@kpollich @Supplementing @nchaulet can we please get his backport merge as soon as we can?

@juliaElastic juliaElastic merged commit 0c54d11 into 8.19 Nov 7, 2025
8 checks passed
@juliaElastic juliaElastic deleted the backport-lock-manager-service-usage branch November 7, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:build-cloud-image release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants