[SideNav] v1 NavTree Structure Clean-Up

.github/CODEOWNERS

@@ -329,10 +329,6 @@ src/core/packages/user-settings/server-mocks @elastic/kibana-security
 src/core/test-helpers/kbn-server @elastic/kibana-core
 src/core/test-helpers/model-versions @elastic/kibana-core
 src/platform/packages/private/analytics/utils/analytics_collection_utils @elastic/kibana-core
-src/platform/packages/private/default-nav/analytics @elastic/kibana-data-discovery @elastic/kibana-presentation @elastic/kibana-visualizations
-src/platform/packages/private/default-nav/devtools @elastic/kibana-management
-src/platform/packages/private/default-nav/management @elastic/kibana-management
-src/platform/packages/private/default-nav/ml @elastic/ml-ui
 src/platform/packages/private/kbn-ambient-common-types @elastic/kibana-operations
 src/platform/packages/private/kbn-ambient-ftr-types @elastic/kibana-operations @elastic/appex-qa
 src/platform/packages/private/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam

package.json

@@ -513,10 +513,6 @@
     "@kbn/deeplinks-shared": "link:src/platform/packages/shared/deeplinks/shared",
     "@kbn/deeplinks-workflows": "link:src/platform/packages/shared/deeplinks/workflows",
     "@kbn/deeplinks-workplace-ai": "link:src/platform/packages/shared/deeplinks/workplace_ai",
-    "@kbn/default-nav-analytics": "link:src/platform/packages/private/default-nav/analytics",
-    "@kbn/default-nav-devtools": "link:src/platform/packages/private/default-nav/devtools",
-    "@kbn/default-nav-management": "link:src/platform/packages/private/default-nav/management",
-    "@kbn/default-nav-ml": "link:src/platform/packages/private/default-nav/ml",
     "@kbn/default-tracer": "link:src/platform/packages/shared/kbn-default-tracer",
     "@kbn/delete-managed-asset-callout": "link:src/platform/packages/shared/kbn-management/delete_managed_assets_callout",
     "@kbn/dependency-injection-example-plugin": "link:examples/dependency_injection",

src/core/packages/chrome/browser-internal/moon.yml

@@ -42,10 +42,6 @@ dependsOn:
   - '@kbn/core-custom-branding-common'
   - '@kbn/core-analytics-browser-mocks'
   - '@kbn/core-analytics-browser'
-  - '@kbn/default-nav-analytics'
-  - '@kbn/default-nav-ml'
-  - '@kbn/default-nav-management'
-  - '@kbn/default-nav-devtools'
   - '@kbn/shared-ux-router'
   - '@kbn/core-http-browser-internal'
   - '@kbn/core-base-browser-internal'

src/core/packages/chrome/browser-internal/src/project_navigation/README.md

@@ -4,10 +4,10 @@ This service manages the side navigation's state using a decoupled, plugin-based
 
 ## Architecture at a Glance
 
--   **Plugins for Stateful Deployment**: Register navigation trees via the `addSolutionNavigation` service from `@kbn/shared-navigation-plugin`.
--   **Serverless Plugins**: Register navigation trees via the `initNavigation` method from the serverless plugin's start contract.
--   **`ProjectNavigationService`**: Manages the source-of-truth nav state and logic.
--   **`ChromeService`**: Orchestrates the UI and bridges the service layer with React.
+- **Plugins for Stateful Deployment**: Register navigation trees via the `addSolutionNavigation` service from `@kbn/shared-navigation-plugin`.
+- **Serverless Plugins**: Register navigation trees via the `initNavigation` method from the serverless plugin's start contract.
+- **`ProjectNavigationService`**: Manages the source-of-truth nav state and logic.
+- **`ChromeService`**: Orchestrates the UI and bridges the service layer with React.
 
 ## Data Flow
 
@@ -34,7 +34,7 @@ The following diagram illustrates how navigation state flows through the system
                                         |                 |
                                         +--------+--------+
                                                  | Props passed directly
-                                                 | via useObservable()  
+                                                 | via useObservable()
                                                  v
                                         +------------------+
                                         | Navigation       |
@@ -56,20 +56,21 @@ This service has three primary responsibilities:
 
 The service does not contain any UI. Instead, it processes navigation trees registered by plugins. This allows the navigation to be extended and customized by different parts of Kibana.
 
--   **Plugins for Stateful Deployment**: Register navigation trees via the `addSolutionNavigation` service from `@kbn/shared-navigation-plugin`.
--   **Serverless Plugins**: Register navigation trees via the `initNavigation` method from the serverless plugin's start contract.
+- **Plugins for Stateful Deployment**: Register navigation trees via the `addSolutionNavigation` service from `@kbn/shared-navigation-plugin`.
+- **Serverless Plugins**: Register navigation trees via the `initNavigation` method from the serverless plugin's start contract.
 
--   **How it works**: Plugins register their components, and the `ChromeService` selects the appropriate one to render based on the current context.
+- **How it works**: Plugins register their components, and the `ChromeService` selects the appropriate one to render based on the current context.
 
 ### 2. Tracking Active State
 
 This is the most common function of the service. It determines the currently active link and broadcasts it to the UI.
 
 **State Stream**: The active state is exposed as an RxJS observable, `activeNodes$`, which streams the active link and its parent nodes.
--   **UI Consumption**: The `ChromeService` subscribes to this stream using the `useObservable` hook and passes the result directly to the Navigation component as props.
--   **Detection Algorithm**: The active node is found by the `findActiveNodes` utility, which uses two methods:
-    1.  **Custom Logic (`getIsActive`)**: A node can define its own function for complex activation logic.
-    2.  **Longest URL Match**: As a fallback, the utility finds the most specific link by matching the longest URL prefix.
+
+- **UI Consumption**: The `ChromeService` subscribes to this stream using the `useObservable` hook and passes the result directly to the Navigation component as props.
+- **Detection Algorithm**: The active node is found by the `findActiveNodes` utility, which uses two methods:
+  1.  **Custom Logic (`getIsActive`)**: A node can define its own function for complex activation logic.
+  2.  **Longest URL Match**: As a fallback, the utility finds the most specific link by matching the longest URL prefix.
 
 #### Breadcrumbs Generation
 
@@ -88,12 +89,3 @@ The Navigation component uses the active nodes information to highlight the curr
 2. When rendering the navigation tree, each item compares its ID with the active node's ID
 3. If they match, the item is rendered with an "active" state (different styling)
 4. Parent nodes of the active item may also receive special styling to show the active path
-
-### 3. Managing Solution Navigation
-
-The service also manages the top-level navigation structure for different **Solutions** (major sections of Kibana like Observability or Security).
-
--   **What it is**: This allows for entirely different navigation trees to be swapped out.
--   **Key Methods**:
-    -   `changeActiveSolutionNavigation()`: Swaps the active solution.
-    -   `getNavState$()`: Provides a combined observable with all relevant nav state (active nodes, breadcrumbs, etc.).

src/core/packages/chrome/browser-internal/src/project_navigation/project_navigation_service.test.ts

@@ -21,7 +21,6 @@ import type {
   AppDeepLinkId,
   ChromeProjectNavigationNode,
   NavigationTreeDefinition,
-  GroupDefinition,
   SolutionNavigationDefinition,
 } from '@kbn/core-chrome-browser';
 import { ProjectNavigationService } from './project_navigation_service';
@@ -302,94 +301,6 @@ describe('initNavigation()', () => {
         ],
       });
     });
-
-    test('should leave "recentlyAccessed" as is', async () => {
-      const treeDefinition = await getNavigationTree();
-      const nodes = treeDefinition.body as ChromeProjectNavigationNode[];
-      expect(nodes[2]).toEqual({
-        type: 'recentlyAccessed',
-      });
-    });
-
-    test('should load preset', async () => {
-      const treeDefinition = await getNavigationTree();
-      const nodes = treeDefinition.body as ChromeProjectNavigationNode[];
-
-      expect(nodes[3]).toMatchInlineSnapshot(`
-        Object {
-          "children": Array [
-            Object {
-              "deepLink": Object {
-                "baseUrl": "/app",
-                "href": "/app/discover",
-                "id": "discover",
-                "title": "DISCOVER",
-                "url": "/app/discover",
-                "visibleIn": Array [
-                  "globalSearch",
-                ],
-              },
-              "href": "/app/discover",
-              "id": "discover",
-              "isExternalLink": false,
-              "onClick": undefined,
-              "path": "rootNav:analytics.discover",
-              "sideNavStatus": "visible",
-              "title": "DISCOVER",
-            },
-            Object {
-              "deepLink": Object {
-                "baseUrl": "/app",
-                "href": "/app/dashboards",
-                "id": "dashboards",
-                "title": "DASHBOARDS",
-                "url": "/app/dashboards",
-                "visibleIn": Array [
-                  "globalSearch",
-                ],
-              },
-              "href": "/app/dashboards",
-              "id": "dashboards",
-              "isExternalLink": false,
-              "onClick": undefined,
-              "path": "rootNav:analytics.dashboards",
-              "sideNavStatus": "visible",
-              "title": "DASHBOARDS",
-            },
-            Object {
-              "deepLink": Object {
-                "baseUrl": "/app",
-                "href": "/app/visualize",
-                "id": "visualize",
-                "title": "VISUALIZE",
-                "url": "/app/visualize",
-                "visibleIn": Array [
-                  "globalSearch",
-                ],
-              },
-              "href": "/app/visualize",
-              "id": "visualize",
-              "isExternalLink": false,
-              "onClick": undefined,
-              "path": "rootNav:analytics.visualize",
-              "sideNavStatus": "visible",
-              "title": "VISUALIZE",
-            },
-          ],
-          "deepLink": undefined,
-          "href": undefined,
-          "icon": "stats",
-          "id": "rootNav:analytics",
-          "isExternalLink": false,
-          "onClick": undefined,
-          "path": "rootNav:analytics",
-          "renderAs": "accordion",
-          "sideNavStatus": "visible",
-          "title": "Data exploration",
-          "type": "navGroup",
-        }
-      `);
-    });
   });
 
   test('should handle race condition when initNavigation() is called after getNavigationTreeUi$()', async () => {
@@ -578,7 +489,6 @@ describe('breadcrumbs', () => {
           id: 'root',
           title: 'Root',
           breadcrumbStatus: 'hidden' as 'hidden',
-          type: 'navGroup',
           children: [
             {
               id: 'subNav',
@@ -822,7 +732,7 @@ describe('breadcrumbs', () => {
     expect(breadcrumbs).toHaveLength(4);
 
     // navigation node contents changed, but not the path
-    const [node] = mockNavigation.body as [GroupDefinition];
+    const [node] = mockNavigation.body;
     updateDefinition({
       body: [{ ...node, title: 'Changed title' }, ...mockNavigation.body],
     });