Skip to content

[9.1] [Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)#240040

Merged
damian-polewski merged 4 commits intoelastic:9.1from
damian-polewski:backport/9.1/pr-239720
Oct 23, 2025
Merged

[9.1] [Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)#240040
damian-polewski merged 4 commits intoelastic:9.1from
damian-polewski:backport/9.1/pr-239720

Conversation

@damian-polewski
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

elastic#239720)

## Summary

Closes elastic#217956, closes elastic#218207

This PR fixes an issue with add/edit processor flyouts not returning
focus to the correct element after closure.

Changes:

- Added a optional `buttonRef` property to the `EditorMode` that allows
to pass the trigger element reference using `onTreeAction` or
`editor.setMode`.
- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`
to allow focusing of the trigger element after flyout closure.

(cherry picked from commit 6526f44)

# Conflicts:
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/add_processor_button.tsx
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_empty_prompt.tsx
#	x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/components/tree_node.tsx
@damian-polewski
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@damian-polewski
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kapral18 kapral18 self-requested a review October 22, 2025 16:44
@damian-polewski damian-polewski merged commit 607e017 into elastic:9.1 Oct 23, 2025
12 checks passed
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #91 / Unified Tabs Examples Managing Unified Tabs can edit tab label with keyboard events

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 338.6KB 339.3KB +655.0B

History

@damian-polewski damian-polewski deleted the backport/9.1/pr-239720 branch October 23, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants