[Ingest Pipelines] Fix add/edit processor flyout return focus behavior#239720
Merged
damian-polewski merged 1 commit intoelastic:mainfrom Oct 22, 2025
Conversation
damian-polewski
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
damian-polewski
changed the title
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
sabarasaba
approved these changes
Oct 22, 2025
Member
sabarasaba
left a comment
sabarasaba
left a comment
There was a problem hiding this comment.
changes lgtm, tested locally. Nice job @damian-polewski 🥳
damian-polewski
deleted the
ingest_pipelines/fix_add_edit_processor_flyouts_return_focus_behavior
branch
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 https://github.com/elastic/kibana/actions/runs/18710834199 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2025
elastic#239720) ## Summary Closes elastic#217956, closes elastic#218207 This PR fixes an issue with add/edit processor flyouts not returning focus to the correct element after closure. Changes: - Added a optional `buttonRef` property to the `EditorMode` that allows to pass the trigger element reference using `onTreeAction` or `editor.setMode`. - Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm` to allow focusing of the trigger element after flyout closure. (cherry picked from commit 6526f44)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
damian-polewski
added a commit
to damian-polewski/kibana
that referenced
this pull request
Oct 22, 2025
elastic#239720) ## Summary Closes elastic#217956, closes elastic#218207 This PR fixes an issue with add/edit processor flyouts not returning focus to the correct element after closure. Changes: - Added a optional `buttonRef` property to the `EditorMode` that allows to pass the trigger element reference using `onTreeAction` or `editor.setMode`. - Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm` to allow focusing of the trigger element after flyout closure. (cherry picked from commit 6526f44) # Conflicts: # x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/add_processor_button.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_empty_prompt.tsx # x-pack/platform/plugins/shared/ingest_pipelines/public/application/components/pipeline_editor/components/processors_tree/components/tree_node.tsx
Contributor
Author
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
|
|
damian-polewski
added
backport:version
kibanamachine
added
backport:skip
kibanamachine
added a commit
that referenced
this pull request
Oct 22, 2025
…ehavior (#239720) (#240030) # Backport This will backport the following commits from `main` to `9.2`: - [[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)](#239720) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Damian Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-22T08:55:12Z","message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Ingest Node Pipelines","backport:all-open","v9.3.0"],"title":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior","number":239720,"url":"https://github.com/elastic/kibana/pull/239720","mergeCommit":{"message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239720","number":239720,"mergeCommit":{"message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09"}}]}] BACKPORT--> Co-authored-by: Damian Polewski <125268832+damian-polewski@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
damian-polewski
added a commit
that referenced
this pull request
Oct 23, 2025
…ehavior (#239720) (#240040) # Backport This will backport the following commits from `main` to `9.1`: - [[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)](#239720) <!--- Backport version: 10.1.0 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Damian Polewski","email":"125268832+damian-polewski@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-22T08:55:12Z","message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","Feature:Ingest Node Pipelines","backport:all-open","v9.3.0"],"title":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior","number":239720,"url":"https://github.com/elastic/kibana/pull/239720","mergeCommit":{"message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/239720","number":239720,"mergeCommit":{"message":"[Ingest Pipelines] Fix add/edit processor flyout return focus behavior (#239720)\n\n## Summary\n\nCloses #217956, closes #218207\n\nThis PR fixes an issue with add/edit processor flyouts not returning\nfocus to the correct element after closure.\n\nChanges:\n\n- Added a optional `buttonRef` property to the `EditorMode` that allows\nto pass the trigger element reference using `onTreeAction` or\n`editor.setMode`.\n- Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm`\nto allow focusing of the trigger element after flyout closure.","sha":"6526f446cbe3a83877af3e44cb3a18832b770d09"}},{"url":"https://github.com/elastic/kibana/pull/240030","number":240030,"branch":"9.2","state":"OPEN"}]}] BACKPORT--> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
elastic#239720) ## Summary Closes elastic#217956, closes elastic#218207 This PR fixes an issue with add/edit processor flyouts not returning focus to the correct element after closure. Changes: - Added a optional `buttonRef` property to the `EditorMode` that allows to pass the trigger element reference using `onTreeAction` or `editor.setMode`. - Added `returnFocus` prop to `AddProcessorForm` and `EditProcessorForm` to allow focusing of the trigger element after flyout closure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #217956, closes #218207
This PR fixes an issue with add/edit processor flyouts not returning focus to the correct element after closure.
Changes:
buttonRefproperty to theEditorModethat allows to pass the trigger element reference usingonTreeActionoreditor.setMode.returnFocusprop toAddProcessorFormandEditProcessorFormto allow focusing of the trigger element after flyout closure.Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.