[Data set quality] Implement FS modal in data quality table #239916
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import React from 'react'; | ||
| import { screen, fireEvent, waitFor } from '@testing-library/react'; | ||
| import { renderWithI18n } from '@kbn/test-jest-helpers'; | ||
| import { FailureStoreHoverLink } from './failure_store_link'; | ||
| import type { DataStreamStat } from '../../../../common/data_streams_stats'; | ||
|
|
||
| const mockUpdateFailureStore = jest.fn(); | ||
| jest.mock('../../../hooks', () => ({ | ||
| useDatasetQualityTable: () => ({ | ||
| updateFailureStore: mockUpdateFailureStore, | ||
| }), | ||
| })); | ||
|
|
||
| describe('FailureStoreHoverLink', () => { | ||
| const mockDataStreamStat: DataStreamStat = { | ||
| rawName: 'logs-test-stream-default', | ||
| type: 'logs', | ||
| name: 'test-stream', | ||
| namespace: 'default', | ||
| title: 'Test Stream', | ||
| hasFailureStore: false, | ||
| defaultRetentionPeriod: '30d', | ||
| customRetentionPeriod: undefined, | ||
| } as DataStreamStat; | ||
|
|
||
| beforeEach(() => { | ||
| mockUpdateFailureStore.mockClear(); | ||
| }); | ||
|
|
||
| describe('table', () => { | ||
| it('renders the button with "N/A" text by default', () => { | ||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={mockDataStreamStat} />); | ||
|
|
||
| const button = screen.getByTestId('datasetQualitySetFailureStoreLink'); | ||
| expect(button).toBeInTheDocument(); | ||
| expect(button).toHaveTextContent('N/A'); | ||
| }); | ||
|
|
||
| it('shows tooltip with correct message', async () => { | ||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={mockDataStreamStat} />); | ||
|
|
||
| const button = screen.getByTestId('datasetQualitySetFailureStoreLink'); | ||
| fireEvent.mouseEnter(button); | ||
|
|
||
| await waitFor(() => { | ||
| expect(screen.getByTestId('failureStoreNotEnabledTooltip')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
|
|
||
| it('changes text to "Set failure store" on hover', () => { | ||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={mockDataStreamStat} />); | ||
|
|
||
| const button = screen.getByTestId('datasetQualitySetFailureStoreLink'); | ||
| expect(button).toHaveTextContent('N/A'); | ||
|
|
||
| fireEvent.mouseEnter(button); | ||
| expect(button).toHaveTextContent('Set failure store'); | ||
|
|
||
| fireEvent.mouseLeave(button); | ||
| expect(button).toHaveTextContent('N/A'); | ||
| }); | ||
|
|
||
| it('opens modal when button is clicked', () => { | ||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={mockDataStreamStat} />); | ||
|
|
||
| const button = screen.getByTestId('datasetQualitySetFailureStoreLink'); | ||
| fireEvent.click(button); | ||
|
|
||
| expect(screen.getByTestId('editFailureStoreModal')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('opens modal for a data stream with failure store disabled', () => { | ||
| const disabledFsDataStream = { | ||
| ...mockDataStreamStat, | ||
| hasFailureStore: false, | ||
| } as DataStreamStat; | ||
|
|
||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={disabledFsDataStream} />); | ||
|
|
||
| const button = screen.getByTestId('datasetQualitySetFailureStoreLink'); | ||
| fireEvent.click(button); | ||
|
|
||
| expect(screen.getByTestId('editFailureStoreModal')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('calls updateFailureStore with custom retention period when provided', async () => { | ||
| renderWithI18n(<FailureStoreHoverLink dataStreamStat={mockDataStreamStat} />); | ||
|
|
||
| fireEvent.click(screen.getByTestId('datasetQualitySetFailureStoreLink')); | ||
| fireEvent.click(screen.getByTestId('enableFailureStoreToggle')); | ||
| fireEvent.click(screen.getByTestId('failureStoreModalSaveButton')); | ||
|
|
||
| await waitFor(() => { | ||
| expect(mockUpdateFailureStore).toHaveBeenCalledWith({ | ||
| failureStoreEnabled: true, | ||
| customRetentionPeriod: undefined, | ||
| dataStreamName: 'logs-test-stream-default', | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { EuiButtonEmpty, EuiToolTip } from '@elastic/eui'; | ||
| import { FailureStoreModal } from '@kbn/failure-store-modal'; | ||
| import { i18n } from '@kbn/i18n'; | ||
| import React, { useState } from 'react'; | ||
| import { useDatasetQualityTable } from '../../../hooks'; | ||
| import type { DataStreamStat } from '../../../../common/data_streams_stats'; | ||
|
|
||
| export const FailureStoreHoverLink: React.FC<{ | ||
| dataStreamStat: DataStreamStat; | ||
| }> = ({ dataStreamStat }) => { | ||
| const [hovered, setHovered] = React.useState(false); | ||
| const [isFailureStoreModalOpen, setIsFailureStoreModalOpen] = useState(false); | ||
| const { updateFailureStore } = useDatasetQualityTable(); | ||
|
|
||
| const closeModal = () => { | ||
| setIsFailureStoreModalOpen(false); | ||
| }; | ||
| const handleSaveModal = async (data: { | ||
| failureStoreEnabled: boolean; | ||
| customRetentionPeriod?: string; | ||
| }) => { | ||
| updateFailureStore({ | ||
| dataStreamName: dataStreamStat.rawName, | ||
| failureStoreEnabled: data.failureStoreEnabled, | ||
| customRetentionPeriod: data.customRetentionPeriod, | ||
| }); | ||
| closeModal(); | ||
| }; | ||
|
|
||
| const onClick = () => { | ||
| setIsFailureStoreModalOpen(true); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <EuiToolTip | ||
| content={i18n.translate('xpack.datasetQuality.failureStore.notEnabled', { | ||
| defaultMessage: | ||
| 'Failure store is not enabled for this data stream. Enable failure store.', | ||
| })} | ||
| data-test-subj="failureStoreNotEnabledTooltip" | ||
| > | ||
| <EuiButtonEmpty | ||
| data-test-subj="datasetQualitySetFailureStoreLink" | ||
| onMouseEnter={() => setHovered(true)} | ||
| onMouseLeave={() => setHovered(false)} | ||
| css={{ fontWeight: 'normal' }} | ||
| aria-label={i18n.translate('xpack.datasetQuality.failureStore.setAriaLabel', { | ||
| defaultMessage: 'Set failure store for data stream {dataStreamName}', | ||
| values: { dataStreamName: dataStreamStat.rawName }, | ||
| })} | ||
| onClick={onClick} | ||
| > | ||
| {hovered | ||
| ? i18n.translate('xpack.datasetQuality.failureStore.enable', { | ||
| defaultMessage: 'Set failure store', | ||
| }) | ||
| : i18n.translate('xpack.datasetQuality.failureStore.notAvailable', { | ||
| defaultMessage: 'N/A', | ||
| })} | ||
| </EuiButtonEmpty> | ||
| </EuiToolTip> | ||
| {isFailureStoreModalOpen && ( | ||
| <FailureStoreModal | ||
| onCloseModal={closeModal} | ||
| onSaveModal={handleSaveModal} | ||
| failureStoreProps={{ | ||
| failureStoreEnabled: dataStreamStat.hasFailureStore ?? false, | ||
| defaultRetentionPeriod: dataStreamStat.defaultRetentionPeriod, | ||
| customRetentionPeriod: dataStreamStat.customRetentionPeriod, | ||
| }} | ||
| /> | ||
| )} | ||
| </> | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.