Skip to content

[Data set quality] Implement FS modal in data quality table#239916

Merged
SoniaSanzV merged 9 commits intoelastic:mainfrom
SoniaSanzV:data_quality/failure_store_modal_in_table
Nov 13, 2025
Merged

[Data set quality] Implement FS modal in data quality table#239916
SoniaSanzV merged 9 commits intoelastic:mainfrom
SoniaSanzV:data_quality/failure_store_modal_in_table

Conversation

@SoniaSanzV
Copy link
Contributor

@SoniaSanzV SoniaSanzV commented Oct 21, 2025

Closes #232736

Summary

In #231846 we implemented the failure store modal in the Data set detail page but the main page still redirects to Index Management.This PR implements new modal also in the Data quality main page.

Screen.Recording.2025-10-21.at.15.27.01.mov

@SoniaSanzV SoniaSanzV self-assigned this Oct 21, 2025
@SoniaSanzV SoniaSanzV requested a review from a team as a code owner October 21, 2025 13:32
@SoniaSanzV SoniaSanzV added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes Feature:Dataset Health backport:version Backport to applied version labels v9.2.0 v9.3.0 labels Oct 21, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

Comment on lines +325 to +326
name: failedDocsColumnName,
'data-test-subj': 'datasetQualityFailedPercentageColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

Comment on lines +294 to +295
name: degradedDocsColumnName,
'data-test-subj': 'datasetQualityPercentageColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

Comment on lines +277 to +278
name: datasetQualityColumnName,
'data-test-subj': 'datasetQualityQualityColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

Comment on lines +248 to +249
name: sizeColumnName,
'data-test-subj': 'datasetQualitySizeColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

Comment on lines +198 to +199
name: nameColumnName,
'data-test-subj': 'datasetQualityNameColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

Comment on lines +227 to +228
name: namespaceColumnName,
'data-test-subj': 'datasetQualityNamespaceColumn',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly related with this issue but it has been changed to avoid this console error:
Warning: validateDOMNesting(...): Text nodes cannot appear as a child of <tr>.

@SoniaSanzV SoniaSanzV added v9.2.1 and removed v9.2.0 labels Oct 24, 2025
@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 28, 2025

Not sure if we should backport this at all, @LucaWintergerst, @flash1293 @gbamparop wdyt?

@yngrdyn
Copy link
Contributor

yngrdyn commented Oct 28, 2025

/oblt-deploy

@LucaWintergerst
Copy link
Contributor

I don't think we need to backport, but curious if Joe or Giorgos think differently

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoniaSanzV SoniaSanzV enabled auto-merge (squash) November 13, 2025 14:01
@SoniaSanzV SoniaSanzV merged commit b625245 into elastic:main Nov 13, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/19338448694

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
datasetQuality 888 889 +1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
datasetQuality 49 51 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
datasetQuality 423.4KB 425.7KB +2.3KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
datasetQuality 11 12 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
datasetQuality 44.2KB 44.6KB +375.0B
Unknown metric groups

API count

id before after diff
datasetQuality 49 51 +2

History

cc @SoniaSanzV

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Nov 13, 2025
…239916)

Closes elastic#232736

## Summary
In elastic#231846 we implemented the
failure store modal in the Data set detail page but the main page still
redirects to Index Management.This PR implements new modal also in the
Data quality main page.

https://github.com/user-attachments/assets/93d5ae87-ad5b-4f18-b271-185c05691ddb

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b625245)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@SoniaSanzV SoniaSanzV added backport:skip This PR does not require backporting and removed v9.2.1 backport:version Backport to applied version labels labels Nov 13, 2025
@SoniaSanzV SoniaSanzV deleted the data_quality/failure_store_modal_in_table branch November 13, 2025 18:38
eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Dec 2, 2025
…239916)

Closes elastic#232736

## Summary
In elastic#231846 we implemented the
failure store modal in the Data set detail page but the main page still
redirects to Index Management.This PR implements new modal also in the
Data quality main page.




https://github.com/user-attachments/assets/93d5ae87-ad5b-4f18-b271-185c05691ddb

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Dataset Health release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Data Quality] Implement new failure store modal in Data quality main page

5 participants