-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[9.2] fix violations of @elastic/eui/no-unnamed-interactive-element (#237317)
#238577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tic#237317) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate aria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`, `EuiComboBox`, `EuiSelect`, `EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`, `EuiBreadcrumbs`. Without this rule, screen reader users lose context, keyboard navigation can be confusing. ## Changes 1. 🎯 Added missing ARIA attributes to elements flagged by `@elastic/eui/no-unnamed-interactive-element` — accessibility leveled up! ## Related - [elastic/eui#8843](elastic/eui#8973) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Pete Harverson <[email protected]> Co-authored-by: Cristina Amico <[email protected]> Co-authored-by: Julia Rechkunova <[email protected]> Co-authored-by: Paulina Shakirova <[email protected]> (cherry picked from commit b419244) # Conflicts: # x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_timeline.tsx
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/fleet (Team:Fleet) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History |
Backport
This will backport the following commits from
mainto9.2:@elastic/eui/no-unnamed-interactive-element(#237317)Questions ?
Please refer to the Backport tool documentation