fix violations of @elastic/eui/no-unnamed-interactive-element#237317
Merged
alexwizp merged 38 commits intoelastic:mainfrom Oct 10, 2025
Merged
fix violations of @elastic/eui/no-unnamed-interactive-element#237317alexwizp merged 38 commits intoelastic:mainfrom
@elastic/eui/no-unnamed-interactive-element#237317alexwizp merged 38 commits intoelastic:mainfrom
Conversation
# Conflicts: # src/platform/plugins/shared/workflows_management/public/features/workflow_execution_detail/ui/workflow_step_execution_flyout.tsx
shahzad31
approved these changes
Oct 9, 2025
src/core/packages/chrome/browser-internal/src/ui/project/breadcrumbs.tsx
Outdated
Show resolved
Hide resolved
paulinashakirova
approved these changes
Oct 9, 2025
paulinashakirova
approved these changes
Oct 9, 2025
Contributor
paulinashakirova
left a comment
paulinashakirova
left a comment
There was a problem hiding this comment.
SharedUX code review only lgtm
…crumbs.tsx Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
mbondyra
reviewed
Oct 9, 2025
...platform/plugins/private/canvas/canvas_plugin_src/renderers/error/components/error/error.tsx
Show resolved
Hide resolved
mbondyra
approved these changes
Oct 9, 2025
sorenlouv
approved these changes
Oct 9, 2025
Contributor
Author
|
@elastic/security-entity-analytics, @elastic/kibana-visualizations please review |
Contributor
Author
|
@elastic/security-entity-analytics, @elastic/kibana-visualizations please review |
nickofthyme
approved these changes
Oct 10, 2025
# Conflicts: # x-pack/solutions/search/plugins/search_playground/public/components/edit_context/context_fields_select.tsx
CAWilson94
approved these changes
Oct 10, 2025
Contributor
CAWilson94
left a comment
CAWilson94
left a comment
There was a problem hiding this comment.
LGTM from @elastic/security-entity-analytics - thanks for the work 🚀
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
|
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Oct 13, 2025
…tic#237317) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate aria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`, `EuiComboBox`, `EuiSelect`, `EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`, `EuiBreadcrumbs`. Without this rule, screen reader users lose context, keyboard navigation can be confusing. ## Changes 1. 🎯 Added missing ARIA attributes to elements flagged by `@elastic/eui/no-unnamed-interactive-element` — accessibility leveled up! ## Related - [elastic/eui#8843](elastic/eui#8973) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co> (cherry picked from commit b419244) # Conflicts: # x-pack/platform/plugins/shared/ml/public/application/explorer/anomaly_timeline.tsx
alexwizp
added a commit
that referenced
this pull request
Oct 13, 2025
…#237317) (#238577) # Backport This will backport the following commits from `main` to `9.2`: - [fix violations of `@elastic/eui/no-unnamed-interactive-element` (#237317)](#237317) <!--- Backport version: 10.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-10-10T19:30:11Z","message":"fix violations of `@elastic/eui/no-unnamed-interactive-element` (#237317)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate\naria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`,\n`EuiComboBox`, `EuiSelect`,\n`EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`,\n`EuiBreadcrumbs`. Without this rule, screen reader users lose context,\nkeyboard navigation can be confusing.\n\n## Changes\n\n1. 🎯 Added missing ARIA attributes to elements flagged by\n`@elastic/eui/no-unnamed-interactive-element` — accessibility leveled\nup!\n\n## Related\n- [elastic/eui#8843](https://github.com/elastic/eui/pull/8973)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: Cristina Amico <criamico@users.noreply.github.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>\nCo-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>","sha":"b41924466f0db68cb2766ba8ff1c08c6b2f13d4c","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","Team:Fleet","Team:Obs AI Assistant","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.2.0","v9.3.0","v9.1.6"],"title":"fix violations of `@elastic/eui/no-unnamed-interactive-element`","number":237317,"url":"https://github.com/elastic/kibana/pull/237317","mergeCommit":{"message":"fix violations of `@elastic/eui/no-unnamed-interactive-element` (#237317)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate\naria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`,\n`EuiComboBox`, `EuiSelect`,\n`EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`,\n`EuiBreadcrumbs`. Without this rule, screen reader users lose context,\nkeyboard navigation can be confusing.\n\n## Changes\n\n1. 🎯 Added missing ARIA attributes to elements flagged by\n`@elastic/eui/no-unnamed-interactive-element` — accessibility leveled\nup!\n\n## Related\n- [elastic/eui#8843](https://github.com/elastic/eui/pull/8973)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: Cristina Amico <criamico@users.noreply.github.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>\nCo-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>","sha":"b41924466f0db68cb2766ba8ff1c08c6b2f13d4c"}},"sourceBranch":"main","suggestedTargetBranches":["9.2","9.1"],"targetPullRequestStates":[{"branch":"9.2","label":"v9.2.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/237317","number":237317,"mergeCommit":{"message":"fix violations of `@elastic/eui/no-unnamed-interactive-element` (#237317)\n\n> [!CAUTION]\n>⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them\ncarefully, but your code owners’ expert eyes will ensure they’re 100%\nright.\n\n## Summary\nThis PR applies the auto-fix for the newly introduced\n`@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate\naria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`,\n`EuiComboBox`, `EuiSelect`,\n`EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`,\n`EuiBreadcrumbs`. Without this rule, screen reader users lose context,\nkeyboard navigation can be confusing.\n\n## Changes\n\n1. 🎯 Added missing ARIA attributes to elements flagged by\n`@elastic/eui/no-unnamed-interactive-element` — accessibility leveled\nup!\n\n## Related\n- [elastic/eui#8843](https://github.com/elastic/eui/pull/8973)\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\nCo-authored-by: Pete Harverson <pete@elastic.co>\nCo-authored-by: Cristina Amico <criamico@users.noreply.github.com>\nCo-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com>\nCo-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>","sha":"b41924466f0db68cb2766ba8ff1c08c6b2f13d4c"}},{"branch":"9.1","label":"v9.1.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…tic#237317) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate aria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`, `EuiComboBox`, `EuiSelect`, `EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`, `EuiBreadcrumbs`. Without this rule, screen reader users lose context, keyboard navigation can be confusing. ## Changes 1. 🎯 Added missing ARIA attributes to elements flagged by `@elastic/eui/no-unnamed-interactive-element` — accessibility leveled up! ## Related - [elastic/eui#8843](elastic/eui#8973) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Oct 23, 2025
…tic#237317) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate aria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`, `EuiComboBox`, `EuiSelect`, `EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`, `EuiBreadcrumbs`. Without this rule, screen reader users lose context, keyboard navigation can be confusing. ## Changes 1. 🎯 Added missing ARIA attributes to elements flagged by `@elastic/eui/no-unnamed-interactive-element` — accessibility leveled up! ## Related - [elastic/eui#8843](elastic/eui#8973) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Oct 27, 2025
…tic#237317) > [!CAUTION] >⚠️ **Changes / translations were made by GenAI**. I’ve reviewed them carefully, but your code owners’ expert eyes will ensure they’re 100% right. ## Summary This PR applies the auto-fix for the newly introduced `@elastic/eui/no-unnamed-interactive-element` Ensure that appropriate aria-attributes are set for `EuiBetaBadge`, `EuiButtonIcon`, `EuiComboBox`, `EuiSelect`, `EuiSelectWithWidth`,`EuiSuperSelect`,`EuiPagination`, `EuiTreeView`, `EuiBreadcrumbs`. Without this rule, screen reader users lose context, keyboard navigation can be confusing. ## Changes 1. 🎯 Added missing ARIA attributes to elements flagged by `@elastic/eui/no-unnamed-interactive-element` — accessibility leveled up! ## Related - [elastic/eui#8843](elastic/eui#8973) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Pete Harverson <pete@elastic.co> Co-authored-by: Cristina Amico <criamico@users.noreply.github.com> Co-authored-by: Julia Rechkunova <julia.rechkunova@gmail.com> Co-authored-by: Paulina Shakirova <paulina.shakirova@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Summary
This PR applies the auto-fix for the newly introduced
@elastic/eui/no-unnamed-interactive-elementEnsure that appropriate aria-attributes are set forEuiBetaBadge,EuiButtonIcon,EuiComboBox,EuiSelect,EuiSelectWithWidth,EuiSuperSelect,EuiPagination,EuiTreeView,EuiBreadcrumbs. Without this rule, screen reader users lose context, keyboard navigation can be confusing.Changes
@elastic/eui/no-unnamed-interactive-element— accessibility leveled up!Related