[Infra UI] Add timepicker and chart dragging to Node detail page#23830
[Infra UI] Add timepicker and chart dragging to Node detail page#23830XavierM merged 14 commits intoelastic:feature-infra-uifrom
Conversation
💔 Build Failed |
|
looks like the CI failures are caused by genuine type errors |
22c3383 to
3cd42d6
Compare
💔 Build Failed |
💔 Build Failed |
|
FYI @weltenwort, I talked to @simianhacker
|
💚 Build Succeeded |
💚 Build Succeeded |
|
@simianhacker what the default value for the crosshair? for now, I put it in the middle of the chart |
|
@simianhacker @XavierM I checked out the PR and used it a bit. I think it's functional, but I'm confused why we can't just use the same logic as Kibana's timepicker, where in most cases we see "Last 30 minutes" type of display? If we can't fix it for Beta, I'm okay with it as is, but we should get together and discuss how working with time ranges really should work. |
Reset and Cancel was not really working
8df08d0 to
ae7bf92
Compare
|
@tbragin |
💔 Build Failed |
simianhacker
left a comment
There was a problem hiding this comment.
LGTM
I think for this version we should go with what we have "as is" but in the next release I would like to have @elastic/eui-design team look at the time picker and come up with a better UX. I agree with Tanya I like the old Kibana time picker but unfortunately that's only available in Angular (as far as I know).
|
jenkins, test this |
💚 Build Succeeded |
|
@tbragin @simianhacker A eui/kibana datepicker will be available early in 6.6. You can mess with the UI side of it in elastic/eui#1219 Since most of it is fairly Kibana specific it'll have a Kibana component to handle all the logic and be a pure replacement of the angular UI available currently. It's likely in the couple weeks, not couple months timeframe. |
|
Thanks for the update @snide! Now I'm even more convinced that this PR will get us to 6.5, then we can switch over to the new one in 6.6 |
|
Nice job @XavierM :) |



#23394
and fixes #23828