Conversation
|
@snide Ready for a look through. I've incorporated the extra stuff. |
|
I'll scan this tonight. Thanks! |
|
Hmm. Either my local got messed or I think you forgot to commit. 😈 |
|
Yeah... I forgot to push.... |
snide
left a comment
snide
left a comment
There was a problem hiding this comment.
This is great. All minor comments.
Might want to set a min-width on the button to avoid the jumpy grid?
Might want to add an isLoading state when it's in live update mode? Right now that Kibana Pink Bar Line of Death handles this, so it's not 100% necessary.
- overflow scrolling per section - time range arrows - timer options
cchaos
force-pushed
the
update-global-date-picker
branch
from
3e949bd to
9e44a7e
Compare
|
Ok, this is now done. @chandlerprall can you do a real quick pass at the code (esp the TS defs?) |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
couple type changes
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
Co-Authored-By: cchaos <549577+cchaos@users.noreply.github.com>
|
@chandlerprall , I've committed your TS def fixes |
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
Also need to import HTMLAttributes in button/index.d.ts (this is causing the CI build failure) - add HTMLAttributes to the list of imports from React in that file.
|
Ahh youp, thx. Updated |
3 participants
Summary
Altered global date/time picker to use buttons instead of date inputs and adds the update button. The component just needed a few adjustments, mostly on the pattern side.
Still needs:
---Includes a fix for #1207 (don’t shrink date picker icon)
Checklist
[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios(different PR for that)