[8.19] [Security Solution] Remove null in confirmation dialog when bulk editing index patterns for rules. (#236572)#237091
Merged
kibanamachine merged 2 commits intoelastic:8.19from Oct 1, 2025
Conversation
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details> (cherry picked from commit dff0cac)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
cc @sdesalas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:nullin confirmation dialog when bulk editing index patterns for rules. (#236572)Questions ?
Please refer to the Backport tool documentation