[Security Solution] Remove null in confirmation dialog when bulk editing index patterns for rules.#236572
Merged
sdesalas merged 1 commit intoelastic:mainfrom Oct 1, 2025
Conversation
sdesalas
added
Team:Detections and Resp
sdesalas
changed the title
null for empty string in confirmation dialog when bulk editing rules.null in confirmation dialog when bulk editing rules.
sdesalas
changed the title
null in confirmation dialog when bulk editing rules.null in confirmation dialog when bulk editing index patterns for rules.
sdesalas
force-pushed
the
confirmation-dialog-shows-null-when-bulk-editing-index-patterns
branch
from
220bef3 to
5971d98
Compare
sdesalas
force-pushed
the
confirmation-dialog-shows-null-when-bulk-editing-index-patterns
branch
from
acbfdbf to
c39e12f
Compare
sdesalas
added
v8.18.8
v8.19.5
v9.0.8
v9.1.5
backport:version
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @sdesalas |
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/18158695819 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2025
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details> (cherry picked from commit dff0cac)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2025
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details> (cherry picked from commit dff0cac)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2025
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details> (cherry picked from commit dff0cac)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2025
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details> (cherry picked from commit dff0cac)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2025
…ulk editing index patterns for rules. (#236572) (#237093) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)](#236572) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steven de Salas","email":"sdesalas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-01T10:05:33Z","message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","ci:cloud-deploy","ci:project-deploy-security","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules.","number":236572,"url":"https://github.com/elastic/kibana/pull/236572","mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236572","number":236572,"mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steven de Salas <sdesalas@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2025
…ulk editing index patterns for rules. (#236572) (#237092) # Backport This will backport the following commits from `main` to `9.0`: - [[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)](#236572) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steven de Salas","email":"sdesalas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-01T10:05:33Z","message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","ci:cloud-deploy","ci:project-deploy-security","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules.","number":236572,"url":"https://github.com/elastic/kibana/pull/236572","mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236572","number":236572,"mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Steven de Salas <sdesalas@users.noreply.github.com> Co-authored-by: Steven de Salas <steven.desalas@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2025
…bulk editing index patterns for rules. (#236572) (#237090) # Backport This will backport the following commits from `main` to `8.18`: - [[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)](#236572) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steven de Salas","email":"sdesalas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-01T10:05:33Z","message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","ci:cloud-deploy","ci:project-deploy-security","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules.","number":236572,"url":"https://github.com/elastic/kibana/pull/236572","mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236572","number":236572,"mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Steven de Salas <sdesalas@users.noreply.github.com> Co-authored-by: Steven de Salas <steven.desalas@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2025
…bulk editing index patterns for rules. (#236572) (#237091) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)](#236572) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Steven de Salas","email":"sdesalas@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-10-01T10:05:33Z","message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix","Team:Detections and Resp","Team: SecuritySolution","Feature:Rule Management","Team:Detection Rule Management","ci:cloud-deploy","ci:project-deploy-security","backport:version","v9.2.0","v8.18.8","v8.19.5","v9.0.8","v9.1.5"],"title":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules.","number":236572,"url":"https://github.com/elastic/kibana/pull/236572","mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},"sourceBranch":"main","suggestedTargetBranches":["8.18","8.19","9.0","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/236572","number":236572,"mergeCommit":{"message":"[Security Solution] Remove `null` in confirmation dialog when bulk editing index patterns for rules. (#236572)\n\n**Resolves: #235794**\n\n## Summary\n\nThis PR removes a `null` value appearing on a success confirmation\ndialog when bulk-editing multiple security rules and setting a new index\npattern.\n\n<img width=\"500\"\nsrc=\"https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d\"\n/>\n\nThis is done by swapping `null` for empty string and adding unit tests\nfor `explainBulkExitSucess()`.\n\n### Testing\n\nTo test this PR please checkout the relevant branch and run kibana\nlocally.\n\n1. Security App > `Rules` > `Detection Rules (SIEM)`\n2. Make sure several rules are created or pre installed.\n3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index\npatterns`\n4. Add index pattern (ie test123-*) > `Save`\n\nExpected Result:\n\n5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.`\n\n<details>\n<summary><h3>Click to see detailed testing steps\n(screenshots)</h3></summary>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7\"\n/>\n\n<img width=\"800\"\nsrc=\"https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0\"\n/>\n\n</details>","sha":"dff0cacee82714765a8463753789d191ebf5c65a"}},{"branch":"8.18","label":"v8.18.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.0","label":"v9.0.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steven de Salas <sdesalas@users.noreply.github.com>
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
…iting index patterns for rules. (elastic#236572) **Resolves: elastic#235794** ## Summary This PR removes a `null` value appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern. <img width="500" src="https://github.com/user-attachments/assets/06241840-3bc0-4eec-93b0-94755c77cd9d" /> This is done by swapping `null` for empty string and adding unit tests for `explainBulkExitSucess()`. ### Testing To test this PR please checkout the relevant branch and run kibana locally. 1. Security App > `Rules` > `Detection Rules (SIEM)` 2. Make sure several rules are created or pre installed. 3. Select 3 rules > `Bulk actions` > `Index patterns` > `Add Index patterns` 4. Add index pattern (ie test123-*) > `Save` Expected Result: 5. Dialog shows: `Rules Updated: You've successfully updated 3 rules.` <details> <summary><h3>Click to see detailed testing steps (screenshots)</h3></summary> <img width="800" src="https://github.com/user-attachments/assets/b5cdb962-7e01-4cec-8021-0ff3928b2615" /> <img width="800" src="https://github.com/user-attachments/assets/07692af9-7f61-499a-b813-359aeee6def7" /> <img width="800" src="https://github.com/user-attachments/assets/9332be94-41ab-4325-81d6-acf7ee947fb0" /> </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #235794
Summary
This PR removes a
nullvalue appearing on a success confirmation dialog when bulk-editing multiple security rules and setting a new index pattern.This is done by swapping
nullfor empty string and adding unit tests forexplainBulkExitSucess().Testing
To test this PR please checkout the relevant branch and run kibana locally.
Rules>Detection Rules (SIEM)Bulk actions>Index patterns>Add Index patternsSaveExpected Result:
Rules Updated: You've successfully updated 3 rules.Click to see detailed testing steps (screenshots)