Skip to content

[9.1] Update registered rule types test snapshot with the missing props (#235922)#235939

Closed
kibanamachine wants to merge 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-235922
Closed

[9.1] Update registered rule types test snapshot with the missing props (#235922)#235939
kibanamachine wants to merge 1 commit intoelastic:9.1from
kibanamachine:backport/9.1/pr-235922

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 9.1:

Questions ?

Please refer to the Backport tool documentation

…astic#235922)

Adds the missing props added by
elastic#235394 to the registered rule
types schema snapshot.

(cherry picked from commit fa205bc)
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 22, 2025

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.eqlRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.eqlRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.indicatorRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.indicatorRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.mlRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.mlRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.newTermsRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.newTermsRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.queryRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.queryRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.savedQueryRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.savedQueryRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.thresholdRule
  • [job] [logs] Jest Integration Tests #4 / Serverless upgrade and rollback checks detect param changes to review for: siem.thresholdRule

Metrics [docs]

✅ unchanged

History

cc @ersin-erdal

@dplumlee
Copy link
Contributor

Is there any git reason that would prevent us or make things difficult if we just added these changes to the existing backport for the PR that introduced these fields without adding the test updates? We'd then close this PR

@ersin-erdal
Copy link
Contributor

Is there any git reason that would prevent us or make things difficult if we just added these changes to the existing backport for the PR that introduced these fields without adding the test updates? We'd then close this PR

Yeah that would be better indeed.
I created this backport because I thought the original PR was already backported to 9.1 as well.
If you can add these changes to #235897, we can close this.

@dplumlee
Copy link
Contributor

Putting these changes in #235897 and closing this PR to not break CI again.

@dplumlee dplumlee closed this Sep 23, 2025
auto-merge was automatically disabled September 23, 2025 04:25

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants