Skip to content

Update registered rule types test snapshot with the missing props#235922

Merged
delanni merged 1 commit intoelastic:mainfrom
ersin-erdal:fix-broken-pipeline
Sep 22, 2025
Merged

Update registered rule types test snapshot with the missing props#235922
delanni merged 1 commit intoelastic:mainfrom
ersin-erdal:fix-broken-pipeline

Conversation

@ersin-erdal
Copy link
Contributor

@ersin-erdal ersin-erdal commented Sep 22, 2025 •
edited by kibanamachine
Loading

Adds the missing props added by #235394 to the registered rule types schema snapshot.

@ersin-erdal ersin-erdal requested a review from a team as a code owner September 22, 2025 08:27
@ersin-erdal ersin-erdal added Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// backport:version Backport to applied version labels v9.2.0 v9.1.5 labels Sep 22, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 22, 2025

Pinging @elastic/response-ops (Team:ResponseOps)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

@ersin-erdal, it looks like you're updating the parameters for a rule type!

Please review the guidelines for making additive changes to rule type parameters and determine if your changes require an intermediate release.

@ersin-erdal ersin-erdal enabled auto-merge (squash) September 22, 2025 08:27
@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:fix labels Sep 22, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 22, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #128 / dashboard sync colors should sync colors on dashboard for legacy default palette
  • [job] [logs] FTR Configs #128 / dashboard sync colors should sync colors on dashboard for legacy default palette
  • [job] [logs] FTR Configs #34 / InfraOps App Metrics UI Home page with metrics present renders the kubernetes tour component and allows user to dismiss it without seeing it again
  • [job] [logs] FTR Configs #102 / Observability AI Assistant Functional tests knowledge_base_management/index.spec.ts Knowledge management tab Bulk import knowledge base entries successfully imports multiple entries from a NDJSON file

Metrics [docs]

✅ unchanged

History

@adcoelho adcoelho mentioned this pull request Sep 22, 2025
Open
@delanni
Copy link
Contributor

delanni commented Sep 22, 2025

Seeing how it's a schema change, and it shouldn't be causing the other errors, I'm going to admin-merge this to redeem the on-merge pipeline at once

@delanni delanni disabled auto-merge September 22, 2025 10:03
@delanni delanni merged commit fa205bc into elastic:main Sep 22, 2025
27 of 28 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 22, 2025

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/17911793573

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2025
@ersin-erdal
Update registered rule types test snapshot with the missing props (el…
802390b 
…astic#235922)

Adds the missing props added by
elastic#235394 to the registered rule
types schema snapshot.

(cherry picked from commit fa205bc)
@kibanamachine kibanamachine mentioned this pull request Sep 22, 2025
Closed
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 22, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Sep 24, 2025
@ersin-erdal @CAWilson94
Update registered rule types test snapshot with the missing props (el…
9ba3ef2 
…astic#235922)

Adds the missing props added by
elastic#235394 to the registered rule
types schema snapshot.
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 24, 2025
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 235922 locally
cc: @ersin-erdal

1 similar comment
@kibanamachine
Copy link
Contributor

kibanamachine commented Sep 25, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 235922 locally
cc: @ersin-erdal

@ersin-erdal ersin-erdal removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels v9.1.5 labels Sep 25, 2025
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Sep 25, 2025
This was referenced Sep 25, 2025
Open
Open
Open
Open
Open
Open
niros1 pushed a commit that referenced this pull request Sep 30, 2025
@ersin-erdal @niros1
Update registered rule types test snapshot with the missing props (#2…
f674feb 
…35922)

Adds the missing props added by
#235394 to the registered rule
types schema snapshot.
rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025
@ersin-erdal
Update registered rule types test snapshot with the missing props (el…
1dca29c 
…astic#235922)

Adds the missing props added by
elastic#235394 to the registered rule
types schema snapshot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adcoelho adcoelho adcoelho approved these changes

@jcger jcger jcger approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ersin-erdal @elasticmachine @delanni @kibanamachine @adcoelho @jcger @cnasikas