[Embeddable] Allow panels to pause data fetching by ThomThomson · Pull Request #235266 · elastic/kibana

ThomThomson · 2025-09-16T19:55:29Z

Summary

Gives the Embeddable system the ability to arbitrarily pause and unpause fetching, while allowing panels to continue with code-loading tasks.

This will be used to increase performance of the double fetch bug fix for controls, and will be used to fetch data for visible panels only.

Notice how in the gif above the panels are finished their initialization but there are no network requests for data yet. When isFetchPaused$ is turned back to false the network requests begin.

How to test

This code is currently unused in the actual product, however you can test its behaviour by adding isFetchPaused$ to the Dashboard API. Add isFetchPaused$: concat(of(true), of(false).pipe(delay(10000))), after line 129 of src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.ts

ThomThomson · 2025-09-16T19:57:56Z

/ci

…no-cache --fix'

ThomThomson · 2025-09-16T20:29:39Z

/ci

ThomThomson · 2025-10-01T20:21:38Z

/ci

ThomThomson · 2025-10-02T16:34:04Z

/ci

elasticmachine · 2025-10-02T18:36:40Z

💚 Build Succeeded

Buildkite Build
Commit: e20c6b5

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	605	607	+2
`apm`	2013	2015	+2
`canvas`	1384	1386	+2
`cases`	1174	1176	+2
`controls`	398	400	+2
`dashboard`	706	708	+2
`dashboardEnhanced`	124	126	+2
`dashboardMarkdown`	102	104	+2
`dataVisualizer`	812	814	+2
`discover`	1616	1618	+2
`discoverEnhanced`	85	87	+2
`embeddable`	110	112	+2
`embeddableAlertsTable`	546	548	+2
`embeddableEnhanced`	84	86	+2
`imageEmbeddable`	159	161	+2
`inputControlVis`	109	111	+2
`lens`	1418	1420	+2
`links`	136	138	+2
`maps`	1288	1290	+2
`ml`	2539	2541	+2
`presentationPanel`	156	158	+2
`reporting`	227	229	+2
`securitySolution`	8294	8296	+2
`slo`	1271	1273	+2
`synthetics`	1368	1370	+2
`triggersActionsUi`	997	999	+2
`urlDrilldown`	87	89	+2
`visTypeVega`	567	569	+2
`visualizations`	550	552	+2
total			+58

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/presentation-publishing`	230	234	+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	525.4KB	526.3KB	+904.0B
`cases`	1.4MB	1.4MB	+6.0B
`controls`	489.1KB	489.1KB	+61.0B
`dashboard`	660.5KB	660.5KB	+6.0B
`dashboardEnhanced`	66.6KB	66.6KB	+6.0B
`dashboardMarkdown`	71.2KB	71.2KB	+6.0B
`dataVisualizer`	594.1KB	595.0KB	+908.0B
`discover`	1.2MB	1.2MB	+909.0B
`embeddable`	59.4KB	59.4KB	-1.0B
`embeddableAlertsTable`	1003.7KB	1004.6KB	+911.0B
`imageEmbeddable`	111.8KB	111.8KB	+6.0B
`lens`	1.5MB	1.5MB	+2.0B
`links`	100.7KB	100.7KB	+6.0B
`maps`	3.1MB	3.1MB	+1.4KB
`ml`	5.4MB	5.4MB	+904.0B
`presentationPanel`	99.0KB	99.0KB	+6.0B
`reporting`	181.3KB	181.3KB	+1.0B
`securitySolution`	11.1MB	11.1MB	+12.0B
`slo`	974.1KB	975.0KB	+918.0B
`synthetics`	1.0MB	1.0MB	+904.0B
`visTypeVega`	2.1MB	2.1MB	+1.0B
`visualizations`	350.2KB	351.0KB	+904.0B
total			+8.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`embeddable`	17.0KB	17.0KB	-2.0B
`lens`	61.2KB	62.0KB	+836.0B
`reporting`	41.4KB	41.4KB	+1.0B
`visTypeVega`	34.2KB	34.2KB	+1.0B
total			+836.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/presentation-publishing`	276	280	+4

History

elasticmachine · 2025-10-02T20:54:35Z

Pinging @elastic/kibana-presentation (Team:Presentation)

davismcphee

Code-only review, Data Discovery changes LGTM 👍

drewdaemon · 2025-10-03T13:49:13Z

will be used to fetch data for visible panels only.

@ThomThomson will this be on by default?

ThomThomson · 2025-10-03T14:35:22Z

@drewdaemon this PR doesn't actually add this functionality. That will be added in a followup. You can see how it will work by taking a look at #225372.

In short, it will be a Dashboard-level setting. And it will be on by default for new Dashboards. If the deferBelowFold setting is on, every Dashboard will have that setting turned on and the Dashboard authors will be unable to turn it off.

...rm/packages/shared/presentation/presentation_publishing/interfaces/fetch/publishes_reload.ts

nreese · 2025-10-03T17:52:03Z

src/platform/plugins/shared/discover/public/embeddable/get_search_embeddable_factory.test.tsx


      // trigger a refetch
-      dashboadFilters.next([]);
+      dashboadFilters.next([{ meta: {} }]);


What does meta do? Should this use reload API?

This PR introduces diffing into the keys of the fetch context before firing the requests. Adding this blank filter object triggers a diff which makes the request fire again. Meta is there because it's required by the type.

In this test, firing an update with a blank array fails the diff and doesn't trigger a refetch. I thought that using filters here would retain the spirit of the test better than switching to reload, but either would work IMO.

Thanks for the explanation. Makes sense and its only a test

nreese

kibana-presentation changes LGTM
code review only

kibanamachine · 2025-10-03T18:22:04Z

Starting backport for target branches: 9.2

https://github.com/elastic/kibana/actions/runs/18230425368

Gives the Embeddable system the ability to arbitrarily pause and unpause data fetching (cherry picked from commit b54c117)

kibanamachine · 2025-10-03T18:29:39Z

💚 All backports created successfully

Status	Branch	Result
✅	9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ThomThomson · 2025-10-03T19:13:19Z

Canceling the backport of this PR to 9.2 as the existing bugfix is enough. This will allow a performance improvement in 9.3 and above.

Gives the Embeddable system the ability to arbitrarily pause and unpause data fetching

Gives the embeddable system the ability to pause and unpause fetching

4525467

ThomThomson changed the title ~~Gives the embeddable system the ability to pause and unpause fetching~~ [Embeddable] Allow panels to pause data fetching Sep 16, 2025

[CI] Auto-commit changed files from 'node scripts/eslint_all_files --…

2a17542

…no-cache --fix'

ThomThomson mentioned this pull request Oct 1, 2025

[Controls] Controls cause double fetch #237147

Closed

ThomThomson added 2 commits October 1, 2025 13:46

Merge remote-tracking branch 'upstream/main' into embeddable/pauseFetch

b7bf464

update jest test

0fbc323

Merge remote-tracking branch 'upstream/main' into embeddable/pauseFetch

e20c6b5

ThomThomson marked this pull request as ready for review October 2, 2025 20:54

ThomThomson requested review from a team as code owners October 2, 2025 20:54

ThomThomson added the backport:version Backport to applied version labels label Oct 2, 2025

davismcphee approved these changes Oct 2, 2025

View reviewed changes

nreese self-requested a review October 3, 2025 17:36

nreese reviewed Oct 3, 2025

View reviewed changes

nreese approved these changes Oct 3, 2025

View reviewed changes

ThomThomson merged commit b54c117 into elastic:main Oct 3, 2025
29 checks passed

kibanamachine added the v9.3.0 label Oct 3, 2025

kibanamachine mentioned this pull request Oct 3, 2025

[9.2] [Embeddable] Allow panels to pause data fetching (#235266) #237524

Closed

ThomThomson added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v9.2.0 labels Oct 3, 2025

rylnd pushed a commit to rylnd/kibana that referenced this pull request Oct 17, 2025

[Embeddable] Allow panels to pause data fetching (elastic#235266)

c98f44b

Gives the Embeddable system the ability to arbitrarily pause and unpause data fetching

ThomThomson mentioned this pull request Oct 20, 2025

[Controls] Pause fetch until initialized #239228

Merged

Conversation

ThomThomson commented Sep 16, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How to test

Uh oh!

ThomThomson commented Sep 16, 2025

Uh oh!

ThomThomson commented Sep 16, 2025

Uh oh!

ThomThomson commented Oct 1, 2025

Uh oh!

ThomThomson commented Oct 2, 2025

Uh oh!

elasticmachine commented Oct 2, 2025

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

elasticmachine commented Oct 2, 2025

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

drewdaemon commented Oct 3, 2025

Uh oh!

ThomThomson commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nreese Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

ThomThomson Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

nreese Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented Oct 3, 2025

Uh oh!

kibanamachine commented Oct 3, 2025

💚 All backports created successfully

Questions ?

Uh oh!

ThomThomson commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ThomThomson commented Sep 16, 2025 •

edited by kibanamachine

Loading

ThomThomson commented Oct 3, 2025 •

edited

Loading