[Dashboard] Fetch only visible panels#225372
Draft
ThomThomson wants to merge 24 commits intoelastic:mainfrom
Draft
[Dashboard] Fetch only visible panels#225372ThomThomson wants to merge 24 commits intoelastic:mainfrom
ThomThomson wants to merge 24 commits intoelastic:mainfrom
Conversation
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
10 tasks
Contributor
Author
|
/ci |
…Visible' into dashboard/fetchOnlyVisible
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
… for no fetch setting in parent
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
Total ESLint disabled count
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #150459
This PR removes the Labs concept from Dashboard and Canvas, as well as deleting all related code.
This PR also migrates the useful setting,
deferBelowFoldto a Dashboard-level setting which is on by default for new Dashboards, and off by default for existing Dashboards to avoid unwanted changes.This new setting works by allowing panels to become initialized when they are off screen, but delaying the data-fetch until they enter the viewport. This is a more robust solution which allows for all related code to be pre-loaded, but delays performance heavy data fetching and rendering.
Note for Data-Discovery reviewers
The delay to fetching works by injecting a
pauseFetch$stream into the API when it's finalized. The Discover Session embeddable started the data fetch process before finalizing the API, so that code has been moved.