Skip to content

[Agent Builder] Support optional ES|QL parameters #235218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennis-tismenko merged 7 commits into from
Sep 22, 2025
Merged

[Agent Builder] Support optional ES|QL parameters #235218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ac5fab0
[Agent Builder] Support optional ES|QL params, testing flyout UX impr…
dennis-tismenko Sep 17, 2025
0f00c69
fix: i18n, styling, optional field label rename
dennis-tismenko Sep 19, 2025
a23d20c
fix: add documentation link
dennis-tismenko Sep 20, 2025
d43e5b3
Merge branch 'main' into onechat/bugfix/test-tool-flyout
elasticmachine Sep 22, 2025
89bc025
Merge branch 'main' into onechat/bugfix/test-tool-flyout
elasticmachine Sep 22, 2025
e709ba1
Merge branch 'main' into onechat/bugfix/test-tool-flyout
elasticmachine Sep 22, 2025
e46ddc8
Merge branch 'main' into onechat/bugfix/test-tool-flyout
elasticmachine Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x-pack/platform/packages/shared/onechat/onechat-common/tools/esql.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ export interface EsqlToolParam {
* Description of the parameter's purpose or expected values.
*/
description: string;
/**
* Whether the parameter is optional.
*/
optional?: boolean;
}

// To make compatible with ToolDefinition['configuration']
Expand Down
8 changes: 4 additions & 4 deletions ...rm/plugins/shared/onechat/public/application/components/agents/edit/tabs/settings_tab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ export const AgentSettingsTab: React.FC<AgentSettingsTabProps> = ({
})}
labelAppend={
<EuiText size="xs" color="subdued">
{labels.agents.settings.optionalLabel}
{labels.common.optional}
</EuiText>
}
isInvalid={!!formState.errors.configuration?.instructions}
Expand Down Expand Up @@ -212,7 +212,7 @@ export const AgentSettingsTab: React.FC<AgentSettingsTabProps> = ({
})}
labelAppend={
<EuiText size="xs" color="subdued">
{labels.agents.settings.optionalLabel}
{labels.common.optional}
</EuiText>
}
isInvalid={!!formState.errors.labels}
Expand Down Expand Up @@ -379,7 +379,7 @@ export const AgentSettingsTab: React.FC<AgentSettingsTabProps> = ({
})}
labelAppend={
<EuiText size="xs" color="subdued">
{labels.agents.settings.optionalLabel}
{labels.common.optional}
</EuiText>
}
isInvalid={!!formState.errors.avatar_color}
Expand Down Expand Up @@ -409,7 +409,7 @@ export const AgentSettingsTab: React.FC<AgentSettingsTabProps> = ({
})}
labelAppend={
<EuiText size="xs" color="subdued">
{labels.agents.settings.optionalLabel}
{labels.common.optional}
</EuiText>
}
isInvalid={!!formState.errors.avatar_symbol}
Expand Down
Loading