[Agent Builder] Support optional ES|QL parameters #235218
Merged
+401
−242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tismenko
force-pushed
the
onechat/bugfix/test-tool-flyout
branch
from
63c9295 to
8f50b5f
Compare
dennis-tismenko
changed the title
dennis-tismenko
added
release_note:skip
dennis-tismenko
force-pushed
the
onechat/bugfix/test-tool-flyout
branch
from
8f50b5f to
c61407a
Compare
zacharyparikh
requested changes
Sep 19, 2025
...k/platform/plugins/shared/onechat/public/application/components/tools/execute/test_tools.tsx
Outdated
Show resolved
Hide resolved
| </EuiTitle> | ||
| </EuiFlexItem> | ||
| <EuiFlexItem> | ||
| <EuiLink href="#" external> |
Contributor
There was a problem hiding this comment.
once #235804 is merged, this should reference the correct docLinks. I guess that would just be docLinks.tools? Unless there is a more specific link for testing tools.
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. If there's a relevant section in there, we could always link them directly to that section
...k/platform/plugins/shared/onechat/public/application/components/tools/execute/test_tools.tsx
Outdated
Show resolved
Hide resolved
x-pack/platform/plugins/shared/onechat/public/application/components/tools/form/i18n.ts
Outdated
Show resolved
Hide resolved
zacharyparikh
approved these changes
Sep 19, 2025
Contributor
Author
|
@elasticmachine merge upstream |
dennis-tismenko
force-pushed
the
onechat/bugfix/test-tool-flyout
branch
from
4c863d2 to
95a0a9b
Compare
Contributor
|
@elasticmachine merge upstream |
jedrazb
approved these changes
Sep 22, 2025
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
dennis-tismenko
force-pushed
the
onechat/bugfix/test-tool-flyout
branch
from
4f9af8f to
a23d20c
Compare
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
⏳ Build in-progress, with failures
Failed CI StepsTest Failures
History
|
Contributor
Author
|
@elasticmachine merge upstream |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
## Summary Adds support for optional ES|QL parameters and cleans up some tool testing flyout UX. https://github.com/user-attachments/assets/a41048bd-ce2a-494d-b751-93fcd4fdf8ee ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
## Summary Adds support for optional ES|QL parameters and cleans up some tool testing flyout UX. https://github.com/user-attachments/assets/a41048bd-ce2a-494d-b751-93fcd4fdf8ee ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
rylnd
pushed a commit
to rylnd/kibana
that referenced
this pull request
Oct 17, 2025
## Summary Adds support for optional ES|QL parameters and cleans up some tool testing flyout UX. https://github.com/user-attachments/assets/a41048bd-ce2a-494d-b751-93fcd4fdf8ee ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for optional ES|QL parameters and cleans up some tool testing flyout UX.
Screen.Recording.2025-09-18.at.3.20.12.PM.mov
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.