[a11y] Fix EuiCallout eslint rule errors by adding a new prop announceOnMount in conditional rendered instances#235054
Merged
paulinashakirova merged 67 commits intoelastic:mainfrom Oct 30, 2025
Conversation
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
paulinashakirova
changed the title
announceonmount in conditional rendered instances
paulinashakirova
changed the title
announceonmount in conditional rendered instancesannounceOnMount in conditional rendered instances
paulinashakirova
force-pushed
the
a11y-euiCallout-autofix-eslint-announceonmount
branch
from
5ccb9de to
4d41f85
Compare
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
Contributor
Author
|
Hi, teams! |
tiansivive
approved these changes
Oct 20, 2025
Contributor
tiansivive
left a comment
tiansivive
left a comment
There was a problem hiding this comment.
Code LGTM now from EA
dplumlee
approved these changes
Oct 20, 2025
Contributor
dplumlee
left a comment
dplumlee
left a comment
There was a problem hiding this comment.
@paulinashakirova thanks for addressing my comments, rule management changes now look good!
sphilipse
approved these changes
Oct 20, 2025
rbrtj
approved these changes
Oct 21, 2025
NicholasPeretti
approved these changes
Oct 22, 2025
pgayvallet
approved these changes
Oct 23, 2025
maxcold
reviewed
Oct 24, 2025
Contributor
maxcold
left a comment
maxcold
left a comment
There was a problem hiding this comment.
contextual-security-apps owned files LGTM
maxcold
approved these changes
Oct 24, 2025
yuliia-fryshko
approved these changes
Oct 27, 2025
Contributor
Author
|
Hi! |
gsoldevila
approved these changes
Oct 29, 2025
Contributor
gsoldevila
left a comment
gsoldevila
left a comment
There was a problem hiding this comment.
Core changes LGTM (code review only)
pickypg
approved these changes
Oct 29, 2025
talboren
approved these changes
Oct 30, 2025
Contributor
talboren
left a comment
talboren
left a comment
There was a problem hiding this comment.
lgtm on workflows related files
jbudz
approved these changes
Oct 30, 2025
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces fix for our new eslint rule
@elastic/eui/callout-announce-on-mount.Problem
tldr; When callouts appear dynamically (e.g., after user interactions, form validation errors, or status changes), screen readers may not announce their content to users.
The
announceOnMountprop ensures these messages are properly announced to users with assistive technologies.Please double check your code - to make sure that if
EuiCalloutappears dynamically after a user interaction, theannounceOnMountis NOT set to false. I did my best, but might have missed some because of my lacking context.Note
If
EuiCallOutis inside a condition, announceOnMount must be set explicitly.