[ML] Overview page: Fixes Incorrectly announced Nodes panel#229868
Merged
rbrtj merged 4 commits intoelastic:mainfrom Jul 31, 2025
Merged
[ML] Overview page: Fixes Incorrectly announced Nodes panel#229868rbrtj merged 4 commits intoelastic:mainfrom
rbrtj merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @rbrtj |
peteharverson
approved these changes
Jul 30, 2025
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
LGTM. Tested (VoiceOver on MacOS) and confirmed that the Nodes panel is now announced correctly.
Contributor
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/16642206900 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 31, 2025
…229868) Fix for: elastic#215899 The Nodes panel had an incorrect `aria-label` value, the rest of the panels seems to be working fine. This PR also removes the `x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx` component, which appears to be a (not used) leftover after moving the job management pages into Stack Management (cherry picked from commit c05e27a)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
rbrtj
added a commit
to rbrtj/kibana
that referenced
this pull request
Jul 31, 2025
…229868) Fix for: elastic#215899 The Nodes panel had an incorrect `aria-label` value, the rest of the panels seems to be working fine. This PR also removes the `x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx` component, which appears to be a (not used) leftover after moving the job management pages into Stack Management (cherry picked from commit c05e27a) # Conflicts: # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/ml/public/application/overview/overview_page.tsx
This was referenced Jul 31, 2025
rbrtj
added a commit
to rbrtj/kibana
that referenced
this pull request
Jul 31, 2025
…229868) Fix for: elastic#215899 The Nodes panel had an incorrect `aria-label` value, the rest of the panels seems to be working fine. This PR also removes the `x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx` component, which appears to be a (not used) leftover after moving the job management pages into Stack Management (cherry picked from commit c05e27a) # Conflicts: # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/ml/public/application/overview/overview_page.tsx
rbrtj
added a commit
to rbrtj/kibana
that referenced
this pull request
Jul 31, 2025
…229868) Fix for: elastic#215899 The Nodes panel had an incorrect `aria-label` value, the rest of the panels seems to be working fine. This PR also removes the `x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx` component, which appears to be a (not used) leftover after moving the job management pages into Stack Management (cherry picked from commit c05e27a) # Conflicts: # x-pack/platform/plugins/private/translations/translations/fr-FR.json # x-pack/platform/plugins/private/translations/translations/ja-JP.json # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/platform/plugins/shared/ml/public/application/overview/overview_page.tsx
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 31, 2025
…29868) (#230027) # Backport This will backport the following commits from `main` to `9.1`: - [[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)](#229868) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T07:00:34Z","message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Team:ML","backport:version","platform-accessibility","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[ML] Overview page: Fixes Incorrectly announced Nodes panel","number":229868,"url":"https://github.com/elastic/kibana/pull/229868","mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229868","number":229868,"mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
rbrtj
added a commit
that referenced
this pull request
Jul 31, 2025
…229868) (#230033) # Backport This will backport the following commits from `main` to `8.19`: - [[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)](#229868) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T07:00:34Z","message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Team:ML","backport:version","platform-accessibility","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[ML] Overview page: Fixes Incorrectly announced Nodes panel","number":229868,"url":"https://github.com/elastic/kibana/pull/229868","mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229868","number":229868,"mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/230027","number":230027,"state":"OPEN"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
rbrtj
added a commit
that referenced
this pull request
Jul 31, 2025
…29868) (#230032) # Backport This will backport the following commits from `main` to `9.0`: - [[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)](#229868) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T07:00:34Z","message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Team:ML","backport:version","platform-accessibility","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[ML] Overview page: Fixes Incorrectly announced Nodes panel","number":229868,"url":"https://github.com/elastic/kibana/pull/229868","mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229868","number":229868,"mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/230027","number":230027,"state":"OPEN"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
rbrtj
added a commit
that referenced
this pull request
Jul 31, 2025
This caused a failure on main, likely due to a PR being merged around the same time as #229868, which removes the usage of the translation.
rbrtj
added a commit
that referenced
this pull request
Jul 31, 2025
…229868) (#230034) # Backport This will backport the following commits from `main` to `8.18`: - [[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)](#229868) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T07:00:34Z","message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility",":ml","release_note:skip","Team:ML","backport:version","platform-accessibility","v9.2.0","v9.0.5","v9.1.1","v8.18.5","v8.19.1"],"title":"[ML] Overview page: Fixes Incorrectly announced Nodes panel","number":229868,"url":"https://github.com/elastic/kibana/pull/229868","mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229868","number":229868,"mergeCommit":{"message":"[ML] Overview page: Fixes Incorrectly announced Nodes panel (#229868)\n\nFix for: https://github.com/elastic/kibana/issues/215899\nThe Nodes panel had an incorrect `aria-label` value, the rest of the\npanels seems to be working fine.\nThis PR also removes the\n`x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx`\ncomponent, which appears to be a (not used) leftover after moving the\njob management pages into Stack Management","sha":"c05e27af8358cd450fe53f5b30e29a2fb3706fe4"}},{"branch":"9.0","label":"v9.0.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/230027","number":230027,"state":"OPEN"},{"branch":"8.18","label":"v8.18.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
…229868) Fix for: elastic#215899 The Nodes panel had an incorrect `aria-label` value, the rest of the panels seems to be working fine. This PR also removes the `x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsx` component, which appears to be a (not used) leftover after moving the job management pages into Stack Management
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 6, 2025
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 7, 2025
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
paulinashakirova
pushed a commit
to paulinashakirova/kibana
that referenced
this pull request
Dec 9, 2025
This caused a failure on main, likely due to a PR being merged around the same time as elastic#229868, which removes the usage of the translation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for: #215899
The Nodes panel had an incorrect
aria-labelvalue, the rest of the panels seems to be working fine.This PR also removes the
x-pack/platform/plugins/shared/ml/public/application/overview/overview_management.tsxcomponent, which appears to be a (not used) leftover after moving the job management pages into Stack Management