[Security Solution] Fix toggle column not working from anywhere but the alerts page#234278
Conversation
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
NicholasPeretti
left a comment
There was a problem hiding this comment.
Great stuff! Thanks for taking care of this 😄
I've left one minor comment, let me know what you think!
...rity/plugins/security_solution/public/app/actions/toggle_column/cell_action/toggle_column.ts
Show resolved
Hide resolved
|
Starting backport for target branches: 8.18, 8.19, 9.0, 9.1 https://github.com/elastic/kibana/actions/runs/17568280355 |
💚 Build Succeeded
Metrics [docs]Async chunks
Saved Objects .kibana field count
History
|
…he alerts page (elastic#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. elastic#234223 (cherry picked from commit 890f7e9)
…he alerts page (elastic#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. elastic#234223 (cherry picked from commit 890f7e9)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
…e but the alerts page (#234278) (#234379) # Backport This will backport the following commits from `main` to `8.19`: - [[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)](#234278) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-09-09T00:49:03Z","message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","backport:version","v9.2.0","v9.0.6","v9.1.4","v8.18.7","v8.19.4"],"title":"[Security Solution] Fix toggle column not working from anywhere but the alerts page","number":234278,"url":"https://github.com/elastic/kibana/pull/234278","mergeCommit":{"message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234278","number":234278,"mergeCommit":{"message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb"}},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
… but the alerts page (#234278) (#234380) # Backport This will backport the following commits from `main` to `9.1`: - [[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)](#234278) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2025-09-09T00:49:03Z","message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Threat Hunting:Investigations","backport:version","v9.2.0","v9.0.6","v9.1.4","v8.18.7","v8.19.4"],"title":"[Security Solution] Fix toggle column not working from anywhere but the alerts page","number":234278,"url":"https://github.com/elastic/kibana/pull/234278","mergeCommit":{"message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","9.1","8.18","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/234278","number":234278,"mergeCommit":{"message":"[Security Solution] Fix toggle column not working from anywhere but the alerts page (#234278)\n\n## Summary\n\nThis PR fixes an issue related to the alert flyout toggle column\nfunctionality not working anywhere but from the alerts page.\n\nWe noticed in the code that we when toggling on/off columns, were\nfiltering out all the usages of the alerts table that were not the\nalerts page. This means that the rule details, case details, attack\ndiscovery and entity analytics pages had a bug where the toggle column\ncell actions was not working.\n\n<details>\n<summary>Alerts page remains unchanged</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565\n\n</details>\n\n<details>\n<summary>Timeline remains unchanged</summary>\n\nBefore fix\n| Before fix | After fix |\n| ------------- | ------------- |\n|\nhttps://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc\n|\nhttps://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e\n|\n\n</details>\n\n<details>\n<summary>Explore pages remain unchanged</summary>\n\nBefore fix\n\nhttps://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b\n\n</details>\n\n<details>\n<summary>Case details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17\n\n</details>\n\n<details>\n<summary>Rule details page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be\n\n</details>\n\n<details>\n<summary>Attack discovery page is fixed</summary>\n\nBefore fix\n\n\nhttps://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37\n\nAfter fix\n\n\nhttps://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024\n\n</details>\n\n### Checklist\n\n- [x] [Unit or functional\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\nwere updated or added to match the most common scenarios\n- [x] The PR description includes the appropriate Release Notes section,\nand the correct `release_note:*` label is applied per the\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\n- [x] Review the [backport\nguidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)\nand apply applicable `backport:*` labels.\n\nhttps://github.com//issues/234223","sha":"890f7e9c631938443e3c8910350877f87f2a87bb"}},{"branch":"9.0","label":"v9.0.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.7","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
|
I'm removing the |
…he alerts page (elastic#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. elastic#234223
…he alerts page (elastic#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. elastic#234223
…he alerts page (elastic#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. elastic#234223
…he alerts page (#234278) ## Summary This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page. We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working. <details> <summary>Alerts page remains unchanged</summary> Before fix https://github.com/user-attachments/assets/f713e70a-8a13-452c-8b9c-c468448b967a After fix https://github.com/user-attachments/assets/7383783e-69a8-452c-9d83-ad8d6e2a1565 </details> <details> <summary>Timeline remains unchanged</summary> Before fix | Before fix | After fix | | ------------- | ------------- | | https://github.com/user-attachments/assets/6088856d-f884-4a2e-819e-a6df12b31fbc | https://github.com/user-attachments/assets/4916b382-54fc-4210-9576-11cc8ebc2f2e | </details> <details> <summary>Explore pages remain unchanged</summary> Before fix https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e After fix https://github.com/user-attachments/assets/69561c31-f69c-4ef9-9d8e-a7862e634e0b </details> <details> <summary>Case details page is fixed</summary> Before fix https://github.com/user-attachments/assets/9a73f413-606e-4245-b827-023677130d2b After fix https://github.com/user-attachments/assets/b7c0827a-4abc-4824-9b9e-8b86f545de17 </details> <details> <summary>Rule details page is fixed</summary> Before fix https://github.com/user-attachments/assets/560ddf58-7047-4258-aa21-6fd5bdb5e285 After fix https://github.com/user-attachments/assets/1d41244a-5482-4833-8887-d883a9f537be </details> <details> <summary>Attack discovery page is fixed</summary> Before fix https://github.com/user-attachments/assets/692e9af4-4cd8-4cb5-ac86-ce99706f6d37 After fix https://github.com/user-attachments/assets/5984c404-9d6b-4c1e-9af3-0877bd660024 </details> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. #234223
Summary
This PR fixes an issue related to the alert flyout toggle column functionality not working anywhere but from the alerts page.
We noticed in the code that we when toggling on/off columns, were filtering out all the usages of the alerts table that were not the alerts page. This means that the rule details, case details, attack discovery and entity analytics pages had a bug where the toggle column cell actions was not working.
Alerts page remains unchanged
Before fix
alerts-before.mov
After fix
alerts-after.mov
Timeline remains unchanged
Before fix
Explore pages remain unchanged
Before fix
https://github.com/user-attachments/assets/8c42e3f2-ab26-4632-9bba-e1c7f8957b6e
After fix
explore-after.mov
Case details page is fixed
Before fix
case-before.mov
After fix
case-after.mov
Rule details page is fixed
Before fix
rule-before.mov
After fix
rule-after.mov
Attack discovery page is fixed
Before fix
attack.discovery-before.mov
After fix
attack.discovery-after.mov
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.#234223