[Data set quality] Allow edit failure store

x-pack/platform/plugins/shared/dataset_quality/common/api_types.ts

@@ -10,6 +10,7 @@ import * as rt from 'io-ts';
 const userPrivilegesRt = rt.type({
   canMonitor: rt.boolean,
   canReadFailureStore: rt.boolean,
+  canManageFailureStore: rt.boolean,
 });
 
 const datasetPrivilegeRt = rt.record(

x-pack/platform/plugins/shared/dataset_quality/common/constants.ts

@@ -54,3 +54,4 @@ export const FAILURE_STORE_SELECTOR = '::failures';
 export const DATA_SELECTOR = '::data';
 
 export const FAILURE_STORE_PRIVILEGE = 'read_failure_store';
+export const MANAGE_FAILURE_STORE_PRIVILEGE = 'manage_failure_store';

x-pack/platform/plugins/shared/dataset_quality/common/translations.ts

@@ -771,6 +771,10 @@ export const createAlertText = i18n.translate('xpack.datasetQuality.createAlert'
   defaultMessage: 'Create rule',
 });
 
+export const editFailureStoreText = i18n.translate('xpack.datasetQuality.editFailureStore', {
+  defaultMessage: 'Edit failure store',
+});
+
 export const issueTypeFilterSearchPlaceholder = i18n.translate(
   'xpack.datasetQuality.details.qualityIssuesTable.issueTypeFilterSearchPlaceholder',
   {

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/document_trends/index.tsx

@@ -20,8 +20,13 @@ import {
   discoverAriaText,
   openInDiscoverText,
   createAlertText,
+  editFailureStoreText,
 } from '../../../../../common/translations';
-import { useDatasetQualityDetailsState, useQualityIssuesDocsChart } from '../../../../hooks';
+import {
+  useDatasetQualityDetailsState,
+  useFailureStoreModal,
+  useQualityIssuesDocsChart,
+} from '../../../../hooks';
 import { TrendDocsChart } from './trend_docs_chart';
 import { useKibanaContextForPlugin } from '../../../../utils/use_kibana';
 import { getAlertingCapabilities } from '../../../../alerts/get_alerting_capabilities';
@@ -30,12 +35,15 @@ import { getAlertingCapabilities } from '../../../../alerts/get_alerting_capabil
 // eslint-disable-next-line import/no-default-export
 export default function DocumentTrends({
   lastReloadTime,
-  displayCreateRuleButton,
   openAlertFlyout,
+  displayActions: { displayCreateRuleButton, displayEditFailureStore },
 }: {
   lastReloadTime: number;
-  displayCreateRuleButton: boolean;
   openAlertFlyout: () => void;
+  displayActions: {
+    displayCreateRuleButton: boolean;
+    displayEditFailureStore: boolean;
+  };
 }) {
   const { timeRange, updateTimeRange } = useDatasetQualityDetailsState();
   const {
@@ -59,6 +67,12 @@ export default function DocumentTrends({
     [updateTimeRange, timeRange.refresh]
   );
 
+  const {
+    openModal: openFailureStoreModal,
+    canUserManageFailureStore,
+    renderModal: renderFailureStoreModal,
+  } = useFailureStoreModal();
+
   return (
     <>
       <EuiSpacer size="m" />
@@ -90,7 +104,7 @@ export default function DocumentTrends({
               />
             </EuiToolTip>
             {displayCreateRuleButton && isAlertingAvailable && (
-              <EuiToolTip content={createAlertText}>
+              <EuiToolTip content={createAlertText} disableScreenReaderOutput>
                 <EuiButtonIcon
                   display="base"
                   iconType="bell"
@@ -101,6 +115,18 @@ export default function DocumentTrends({
                 />
               </EuiToolTip>
             )}
+            {displayEditFailureStore && canUserManageFailureStore && (
+              <EuiToolTip content={editFailureStoreText} disableScreenReaderOutput>
+                <EuiButtonIcon
+                  display="base"
+                  iconType="pencil"
+                  aria-label={editFailureStoreText}
+                  size="s"
+                  data-test-subj="datasetQualityDetailsEditFailureStore"
+                  onClick={openFailureStoreModal}
+                />
+              </EuiToolTip>
+            )}
           </EuiFlexGroup>
         </EuiFlexItem>
       </EuiFlexGroup>
@@ -111,6 +137,7 @@ export default function DocumentTrends({
         lastReloadTime={lastReloadTime}
         onTimeRangeChange={onTimeRangeChange}
       />
+      {renderFailureStoreModal()}
     </>
   );
 }

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/index.tsx

@@ -73,8 +73,11 @@ export function Overview({ openAlertFlyout }: { openAlertFlyout: () => void }) {
         <EuiSplitPanel.Inner grow={true}>
           <DocumentTrends
             lastReloadTime={lastReloadTime}
-            displayCreateRuleButton={selectedQualityCard === 'degraded'}
             openAlertFlyout={openAlertFlyout}
+            displayActions={{
+              displayCreateRuleButton: selectedQualityCard === 'degraded',
+              displayEditFailureStore: selectedQualityCard === 'failed',
+            }}
           />
         </EuiSplitPanel.Inner>
       </EuiSplitPanel.Outer>

x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/quality_summary_cards/index.tsx

@@ -6,10 +6,9 @@
  */
 
 import { EuiButtonEmpty, EuiFlexGroup, EuiFlexItem, EuiCode } from '@elastic/eui';
-import React, { useState } from 'react';
+import React from 'react';
 import { i18n } from '@kbn/i18n';
 import { FormattedMessage } from '@kbn/i18n-react';
-import { FailureStoreModal } from '@kbn/failure-store-modal';
 import {
   overviewPanelDatasetQualityIndicatorDegradedDocs,
   overviewPanelDatasetQualityIndicatorFailedDocs,
@@ -18,6 +17,7 @@ import {
 import { useOverviewSummaryPanel } from '../../../../hooks/use_overview_summary_panel';
 import { useQualityIssuesDocsChart } from '../../../../hooks/use_quality_issues_docs_chart';
 import { useDatasetQualityDetailsState } from '../../../../hooks/use_dataset_quality_details_state';
+import { useFailureStoreModal } from '../../../../hooks/use_failure_store_modal';
 import { DatasetQualityIndicator, QualityPercentageIndicator } from '../../../quality_indicator';
 import { Card } from './card';
 
@@ -60,35 +60,16 @@ export default function QualitySummaryCards({
   } = useOverviewSummaryPanel();
   const { handleDocsTrendChartChange } = useQualityIssuesDocsChart();
   const {
-    canUserReadFailureStore,
-    hasFailureStore,
     loadingState: { dataStreamSettingsLoading },
-    defaultRetentionPeriod,
-    customRetentionPeriod,
-    updateFailureStore,
   } = useDatasetQualityDetailsState();
 
-  const [isFailureStoreModalOpen, setIsFailureStoreModalOpen] = useState(false);
-
-  const closeModal = () => {
-    setIsFailureStoreModalOpen(false);
-  };
-
-  const handleSaveModal = async (data: {
-    failureStoreEnabled: boolean;
-    customRetentionPeriod?: string;
-  }) => {
-    updateFailureStore({
-      failureStoreEnabled: data.failureStoreEnabled,
-      customRetentionPeriod: data.customRetentionPeriod,
-    });
-    closeModal();
-  };
-
-  const onClick = () => {
-    setIsFailureStoreModalOpen(true);
-  };
-
+  const {
+    openModal,
+    canUserReadFailureStore,
+    canUserManageFailureStore,
+    hasFailureStore,
+    renderModal: renderFailureStoreModal,
+  } = useFailureStoreModal();
   return (
     <EuiFlexGroup gutterSize="m" direction="column" style={{ height: '100%' }}>
       <EuiFlexItem grow={true}>
@@ -139,9 +120,9 @@ export default function QualitySummaryCards({
                 defaultMessage: 'No failure store',
               })}
               footer={
-                canUserReadFailureStore && (
+                canUserManageFailureStore && (
                   <EuiButtonEmpty
-                    onClick={onClick}
+                    onClick={openModal}
                     data-test-subj="datasetQualityDetailsEnableFailureStoreButton"
                   >
                     {i18n.translate('xpack.datasetQuality.enableFailureStore', {
@@ -151,17 +132,7 @@ export default function QualitySummaryCards({
                 )
               }
             />
-            {canUserReadFailureStore && isFailureStoreModalOpen && defaultRetentionPeriod && (
-              <FailureStoreModal
-                onCloseModal={closeModal}
-                onSaveModal={handleSaveModal}
-                failureStoreProps={{
-                  failureStoreEnabled: hasFailureStore,
-                  defaultRetentionPeriod,
-                  customRetentionPeriod,
-                }}
-              />
-            )}
+            {renderFailureStoreModal()}
           </>
         ) : (
           <Card

x-pack/platform/plugins/shared/dataset_quality/public/hooks/index.ts

@@ -17,3 +17,4 @@ export * from './use_quality_issues_filters';
 export * from './use_integration_actions';
 export * from './use_dataset_telemetry';
 export * from './use_dataset_details_telemetry';
+export * from './use_failure_store_modal';

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_dataset_quality_details_state.ts

@@ -103,6 +103,11 @@ export const useDatasetQualityDetailsState = () => {
     dataStreamSettings?.datasetUserPrivileges?.datasetsPrivilages?.[dataStream]?.canReadFailureStore
   );
 
+  const canUserManageFailureStore = Boolean(
+    dataStreamSettings?.datasetUserPrivileges?.datasetsPrivilages?.[dataStream]
+      ?.canManageFailureStore
+  );
+
   const dataStreamDetails = useSelector(service, (state) =>
     state.matches('initializing.dataStreamDetails.done')
       ? state.context.dataStreamDetails
@@ -214,5 +219,6 @@ export const useDatasetQualityDetailsState = () => {
     isQualityIssueFlyoutOpen,
     defaultRetentionPeriod,
     customRetentionPeriod,
+    canUserManageFailureStore,
   };
 };

x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_failure_store_modal.ts

@@ -0,0 +1,70 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import React, { useState } from 'react';
+import { FailureStoreModal } from '@kbn/failure-store-modal';
+import { useDatasetQualityDetailsState } from './use_dataset_quality_details_state';
+
+export function useFailureStoreModal() {
+  const {
+    canUserReadFailureStore,
+    hasFailureStore,
+    defaultRetentionPeriod,
+    customRetentionPeriod,
+    updateFailureStore,
+    canUserManageFailureStore,
+  } = useDatasetQualityDetailsState();
+
+  const [isFailureStoreModalOpen, setIsFailureStoreModalOpen] = useState(false);
+
+  const openModal = () => {
+    setIsFailureStoreModalOpen(true);
+  };
+
+  const closeModal = () => {
+    setIsFailureStoreModalOpen(false);
+  };
+
+  const handleSaveModal = async (data: {
+    failureStoreEnabled: boolean;
+    customRetentionPeriod?: string;
+  }) => {
+    updateFailureStore({
+      failureStoreEnabled: data.failureStoreEnabled,
+      customRetentionPeriod: data.customRetentionPeriod,
+    });
+    closeModal();
+  };
+
+  const renderModal = (): React.ReactElement | null => {
+    if (canUserManageFailureStore && isFailureStoreModalOpen && defaultRetentionPeriod) {
+      return React.createElement(FailureStoreModal, {
+        onCloseModal: closeModal,
+        onSaveModal: handleSaveModal,
+        failureStoreProps: {
+          failureStoreEnabled: hasFailureStore,
+          defaultRetentionPeriod,
+          customRetentionPeriod,
+        },
+      });
+    }
+    return null;
+  };
+
+  return {
+    isFailureStoreModalOpen,
+    openModal,
+    closeModal,
+    handleSaveModal,
+    canUserReadFailureStore,
+    canUserManageFailureStore,
+    hasFailureStore,
+    defaultRetentionPeriod,
+    customRetentionPeriod,
+    renderModal,
+  };
+}

x-pack/platform/plugins/shared/dataset_quality/public/state_machines/dataset_quality_details_controller/state_machine.ts

@@ -1008,7 +1008,7 @@ export const createDatasetQualityDetailsControllerStateMachine = ({
         if (
           'dataStreamDetails' in context &&
           context.dataStreamDetails &&
-          context.dataStreamDetails.hasFailureStore
+          context.dataStreamDetails.hasFailureStore !== undefined
         ) {
           return dataStreamDetailsClient.updateFailureStore({
             dataStream: context.dataStream,

x-pack/platform/plugins/shared/dataset_quality/public/utils/generate_datasets.test.ts

@@ -46,6 +46,7 @@ describe('generateDatasets', () => {
       userPrivileges: {
         canMonitor: true,
         canReadFailureStore: true,
+        canManageFailureStore: true,
       },
     },
     {
@@ -58,6 +59,7 @@ describe('generateDatasets', () => {
       userPrivileges: {
         canMonitor: true,
         canReadFailureStore: true,
+        canManageFailureStore: true,
       },
     },
   ];
@@ -114,6 +116,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         docsInTimeRange: 102,
         quality: 'degraded',
@@ -141,6 +144,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         docsInTimeRange: 100,
         quality: 'poor',
@@ -181,6 +185,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         docsInTimeRange: 2,
         quality: 'poor',
@@ -208,6 +213,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         docsInTimeRange: 0,
         quality: 'good',
@@ -379,6 +385,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         quality: 'good',
         docsInTimeRange: 100,
@@ -406,6 +413,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         quality: 'good',
         docsInTimeRange: 100,
@@ -434,6 +442,7 @@ describe('generateDatasets', () => {
       userPrivileges: {
         canMonitor: true,
         canReadFailureStore: true,
+        canManageFailureStore: true,
       },
     };
 
@@ -453,6 +462,7 @@ describe('generateDatasets', () => {
         userPrivileges: {
           canMonitor: true,
           canReadFailureStore: true,
+          canManageFailureStore: true,
         },
         quality: 'good',
         totalDocs: 100,