[Data set quality] Allow edit failure store#233858
Merged
SoniaSanzV merged 8 commits intoelastic:mainfrom Sep 5, 2025
Merged
Conversation
SoniaSanzV
added
Team:Kibana Management
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
yngrdyn
reviewed
Sep 4, 2025
| /> | ||
| </EuiToolTip> | ||
| )} | ||
| {displayEditFailureStore && canUserReadFailureStore && ( |
Contributor
There was a problem hiding this comment.
Would canUserReadFailureStore be enough for enabling/disabling/updating failure store?
afaik we have read_failure_store and manage_failure_store, shouldn't all these actions tight to manage_failure_store?
yngrdyn
reviewed
Sep 4, 2025
| lastReloadTime={lastReloadTime} | ||
| displayCreateRuleButton={selectedQualityCard === 'degraded'} | ||
| openAlertFlyout={openAlertFlyout} | ||
| displayEditFailureStore={selectedQualityCard === 'failed'} |
Contributor
There was a problem hiding this comment.
[nit] we could group the display features into one property, e.g.
actions: {
createRule,
editFailureStore,
}
57479c5 to
cc1804d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables editing and disabling of failure store functionality from the dataset quality plugin. Previously, users could only enable failure store from the plugin but couldn't modify or disable it.
Key changes:
- Introduces a new
canManageFailureStoreprivilege to control edit permissions - Adds an edit button (pencil icon) to the failure store card in the document trends section
- Creates a reusable failure store modal hook for managing modal state and operations
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
x-pack/platform/plugins/shared/dataset_quality/common/constants.ts |
Adds new MANAGE_FAILURE_STORE_PRIVILEGE constant |
x-pack/platform/plugins/shared/dataset_quality/common/api_types.ts |
Updates API types to include canManageFailureStore privilege |
x-pack/platform/plugins/shared/dataset_quality/server/services/privileges.ts |
Updates privilege service to check manage failure store permissions |
x-pack/platform/plugins/shared/dataset_quality/server/routes/data_streams/ |
Updates data stream routes to include manage failure store privilege |
x-pack/platform/plugins/shared/dataset_quality/public/hooks/use_failure_store_modal.ts |
New hook for managing failure store modal state and operations |
x-pack/platform/plugins/shared/dataset_quality/public/components/dataset_quality_details/overview/ |
Updates UI components to display edit button and use new modal hook |
x-pack/platform/plugins/shared/dataset_quality/public/state_machines/ |
Fixes condition check for failure store updates |
| Test files | Adds comprehensive test coverage for the new edit functionality |
...dataset_quality/public/components/dataset_quality_details/overview/document_trends/index.tsx
Show resolved
Hide resolved
...dataset_quality/public/components/dataset_quality_details/overview/document_trends/index.tsx
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
cc @SoniaSanzV |
shahargl
pushed a commit
to shahargl/kibana
that referenced
this pull request
Sep 7, 2025
Closes elastic#231848 ## Summary With elastic#231846 we introduced the possibility for the users to enabling failure store from the data quality plugin, but they couldn't edit or disable it from there. With this PR, we introduce the option of editing failure store from data set quality. ### How to test * Go to data quality plugin * Select a data set * Enable the failure store if disabled * Click the failure store card * Click the new pen icon * Verify the failure store modal opens * Verify that you can edit data and disable the failure store Note: Despite that in the mocks the icon is on the left, I add it to the right so the discover button is consisten with the one that the other card enables. ### Mocks <img width="1846" height="690" alt="image" src="https://github.com/user-attachments/assets/3069ae8c-b276-487a-9104-106f4adfa948" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
KodeRad
pushed a commit
to KodeRad/kibana
that referenced
this pull request
Sep 15, 2025
Closes elastic#231848 ## Summary With elastic#231846 we introduced the possibility for the users to enabling failure store from the data quality plugin, but they couldn't edit or disable it from there. With this PR, we introduce the option of editing failure store from data set quality. ### How to test * Go to data quality plugin * Select a data set * Enable the failure store if disabled * Click the failure store card * Click the new pen icon * Verify the failure store modal opens * Verify that you can edit data and disable the failure store Note: Despite that in the mocks the icon is on the left, I add it to the right so the discover button is consisten with the one that the other card enables. ### Mocks <img width="1846" height="690" alt="image" src="https://github.com/user-attachments/assets/3069ae8c-b276-487a-9104-106f4adfa948" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Sep 24, 2025
Closes elastic#231848 ## Summary With elastic#231846 we introduced the possibility for the users to enabling failure store from the data quality plugin, but they couldn't edit or disable it from there. With this PR, we introduce the option of editing failure store from data set quality. ### How to test * Go to data quality plugin * Select a data set * Enable the failure store if disabled * Click the failure store card * Click the new pen icon * Verify the failure store modal opens * Verify that you can edit data and disable the failure store Note: Despite that in the mocks the icon is on the left, I add it to the right so the discover button is consisten with the one that the other card enables. ### Mocks <img width="1846" height="690" alt="image" src="https://github.com/user-attachments/assets/3069ae8c-b276-487a-9104-106f4adfa948" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
niros1
pushed a commit
that referenced
this pull request
Sep 30, 2025
Closes #231848 ## Summary With #231846 we introduced the possibility for the users to enabling failure store from the data quality plugin, but they couldn't edit or disable it from there. With this PR, we introduce the option of editing failure store from data set quality. ### How to test * Go to data quality plugin * Select a data set * Enable the failure store if disabled * Click the failure store card * Click the new pen icon * Verify the failure store modal opens * Verify that you can edit data and disable the failure store Note: Despite that in the mocks the icon is on the left, I add it to the right so the discover button is consisten with the one that the other card enables. ### Mocks <img width="1846" height="690" alt="image" src="https://github.com/user-attachments/assets/3069ae8c-b276-487a-9104-106f4adfa948" /> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231848
Summary
With #231846 we introduced the possibility for the users to enabling failure store from the data quality plugin, but they couldn't edit or disable it from there. With this PR, we introduce the option of editing failure store from data set quality.
How to test
Note: Despite that in the mocks the icon is on the left, I add it to the right so the discover button is consisten with the one that the other card enables.
Mocks