[8.19] [ES|QL] Fixes lookup indexes route failures on read permissions (#233282)#233499
Closed
stratoula wants to merge 2 commits intoelastic:8.19from
Closed
[8.19] [ES|QL] Fixes lookup indexes route failures on read permissions (#233282)#233499stratoula wants to merge 2 commits intoelastic:8.19from
stratoula wants to merge 2 commits intoelastic:8.19from
Conversation
…tic#233282) ## Summary This PR is fixing a bunch of bugs all related with lookup join route. When you are on an instance with read privileges on indexes and try to use the ES|QL editor you will see 2 problems: 1. The lookup join route fails with 500 2. The failure makes the history component to not save anything at the local storage. The reason is that our validation api fails so we cant get the status so the item is not saved at the local storage After an investigation I found out that: - client.indices.getSettings fails when you have read priviliges - the client.indices.getAlias fails if you pass an empty array What I did: - changed the client.indices.getSettings to client.indices.resolveIndex which works on read and doesnt return hidden indices - I am fetching the aliases from the same api - I added the parseMessages to a try catch loop to be sure that even if something fails on the validation the history component will work (cherry picked from commit 3adac4b) # Conflicts: # src/platform/plugins/shared/esql/server/services/esql_service.ts
Contributor
Author
|
The api is different in 8.19 so I cant backport this bug fix |
auto-merge was automatically disabled
September 4, 2025 06:53
Pull request was closed
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation