[8.19] [Index management] Clean all tests after execution and navigate directly to the tab (#232198)#233439
Closed
kibanamachine wants to merge 1 commit intoelastic:8.19from
Closed
[8.19] [Index management] Clean all tests after execution and navigate directly to the tab (#232198)#233439kibanamachine wants to merge 1 commit intoelastic:8.19from
kibanamachine wants to merge 1 commit intoelastic:8.19from
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…tly to the tab (elastic#232198) ## Summary Space time project. I'm trying to improve the test for Kibana Management. In this PR, I did two things: * Clean up all created resources after execution. This suite contained a lot of resources that wasn't deleted after execution. That complicates local testing and leads to failures if you re-run the tests. * Navigates directly to the desired tab when setting up the tests. This is not an anti-patter, but it was time consuming. We were doing this: ``` await pageObjects.common.navigateToApp('indexManagement'); // Navigate to the data streams tab await pageObjects.indexManagement.changeTabs('data_streamsTab'); await pageObjects.header.waitUntilLoadingHasFinished(); ``` But the `navigateToApp` method already contains a path parameter, so doing it this way, we can get rid of unnecessaries `waitUntilLoadingHasFinished` calls. With this simple change, the execution time of serverless tests locally dropped from 2 minutes to 1 minute. * Also, changes the data-test-subj for creating a component template from `createPipelineButton` to `createComponentTemplateButton`, that wasn't reflecting what the button really does. Flay test runner stateful tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9177 Flay test runner serverless tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9182 (cherry picked from commit 1abc780)
kibanamachine
force-pushed
the
backport/8.19/pr-232198
branch
from
8e6034b to
68420b6
Compare
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @SoniaSanzV |
auto-merge was automatically disabled
September 25, 2025 08:15
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation