[Index management] Clean all tests after execution and navigate directly to the tab by SoniaSanzV · Pull Request #232198 · elastic/kibana

SoniaSanzV · 2025-08-19T09:44:09Z

Summary

Space time project. I'm trying to improve the test for Kibana Management. In this PR, I did two things:

Clean up all created resources after execution. This suite contained a lot of resources that wasn't deleted after execution. That complicates local testing and leads to failures if you re-run the tests.
Navigates directly to the desired tab when setting up the tests. This is not an anti-patter, but it was time consuming. We were doing this:

      await pageObjects.common.navigateToApp('indexManagement');
      // Navigate to the data streams tab
      await pageObjects.indexManagement.changeTabs('data_streamsTab');
      await pageObjects.header.waitUntilLoadingHasFinished();

But the navigateToApp method already contains a path parameter, so doing it this way, we can get rid of unnecessaries waitUntilLoadingHasFinished calls.
With this simple change, the execution time of serverless tests locally dropped from 2 minutes to 1 minute.

Also, changes the data-test-subj for creating a component template from createPipelineButton to createComponentTemplateButton, that wasn't reflecting what the button really does.

Flay test runner stateful tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9177
Flay test runner serverless tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9182

elasticmachine · 2025-08-19T09:44:14Z

Pinging @elastic/kibana-management (Team:Kibana Management)

kibanamachine · 2025-08-19T11:07:46Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#9177

[✅] x-pack/platform/test/functional/apps/index_management/config.ts: 100/100 tests passed.

see run history

kibanamachine · 2025-08-19T16:35:37Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#9182

[✅] x-pack/platform/test/serverless/functional/configs/search/config.group1.ts: 100/100 tests passed.

see run history

ElenaStoeva

Great job @SoniaSanzV - it's nice to see the test running time reduction! Changes lgtm with one suggestion for an improvement.

ElenaStoeva · 2025-08-28T14:17:41Z

.../platform/test/functional/apps/index_management/create_enrich_policy/create_enrich_policy.ts

      } catch (e) {
-        log.debug('[Teardown error] Error deleting test policy');
-        throw e;
+        log.debug(`[Teardown error] Error deleting test index: ${e.message}`);


We could separate these into two try-catch blocks so that if one fails the other resource is still deleted, and the log message would be more helpful (i.e. right now, if the policy deletion failed, the logs will say that the index deletion failed).

ElenaStoeva · 2025-08-28T14:18:36Z

...ck/platform/test/functional/apps/index_management/enrich_policies_tab/enrich_policies_tab.ts

      } catch (e) {
-        log.debug('[Teardown error] Error deleting test policy');
-        throw e;
+        log.debug(`[Teardown error] Error deleting test policy: ${e.message}`);


Same comment here

ElenaStoeva · 2025-08-28T14:21:10Z

...m/test/serverless/functional/test_suites/management/index_management/create_enrich_policy.ts

      } catch (e) {
-        log.debug('[Teardown error] Error deleting test policy');
-        throw e;
+        log.debug(`[Teardown error] Error deleting test index: ${e.message}`);


Same comment here

ElenaStoeva · 2025-08-28T14:21:30Z

...atform/test/serverless/functional/test_suites/management/index_management/enrich_policies.ts

      } catch (e) {
-        log.debug('[Teardown error] Error deleting test policy');
-        throw e;
+        log.debug(`[Teardown error] Error deleting test index: ${e.message}`);


Same comment here

SoniaSanzV · 2025-08-28T17:10:41Z

Great job @SoniaSanzV - it's nice to see the test running time reduction! Changes lgtm with one suggestion for an improvement.

Thank you for the review! I've addressed your suggestions in my last commit!

elasticmachine · 2025-08-28T19:17:00Z

💚 Build Succeeded

Buildkite Build
Commit: d74139c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`indexManagement`	686.9KB	686.9KB	+18.0B

History

💚 Build #333599 succeeded c8bf852
💚 Build #330832 succeeded 8fa330e
💚 Build #330714 succeeded 2dc1357

cc @SoniaSanzV

ElenaStoeva

Lgtm, thanks for the last changes!

kibanamachine · 2025-08-29T09:21:23Z

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/17319957952

…tly to the tab (elastic#232198) ## Summary Space time project. I'm trying to improve the test for Kibana Management. In this PR, I did two things: * Clean up all created resources after execution. This suite contained a lot of resources that wasn't deleted after execution. That complicates local testing and leads to failures if you re-run the tests. * Navigates directly to the desired tab when setting up the tests. This is not an anti-patter, but it was time consuming. We were doing this: ``` await pageObjects.common.navigateToApp('indexManagement'); // Navigate to the data streams tab await pageObjects.indexManagement.changeTabs('data_streamsTab'); await pageObjects.header.waitUntilLoadingHasFinished(); ``` But the `navigateToApp` method already contains a path parameter, so doing it this way, we can get rid of unnecessaries `waitUntilLoadingHasFinished` calls. With this simple change, the execution time of serverless tests locally dropped from 2 minutes to 1 minute. * Also, changes the data-test-subj for creating a component template from `createPipelineButton` to `createComponentTemplateButton`, that wasn't reflecting what the button really does. Flay test runner stateful tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9177 Flay test runner serverless tests: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/9182 (cherry picked from commit 1abc780)

kibanamachine · 2025-08-29T09:29:06Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts
✅	8.19
❌	9.0	Backport failed because of merge conflicts You might need to backport the following PRs to 9.0: - [Docs] Adds security advisory note to release notes (#233347)
✅	9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 232198