[Entity Analytics][Chore] Tidy Privmon URLs, imports and routes#233400
Merged
hop-dev merged 8 commits intoelastic:mainfrom Sep 2, 2025
Merged
[Entity Analytics][Chore] Tidy Privmon URLs, imports and routes#233400hop-dev merged 8 commits intoelastic:mainfrom
hop-dev merged 8 commits intoelastic:mainfrom
Conversation
hop-dev
added
release_note:skip
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
commented
Aug 28, 2025
| export const PRIVMON_USERS_CSV_SIZE_TOLERANCE_BYTES = 1024 * 50; // ~= 50kb | ||
| export const PRIVMON_USERS_CSV_MAX_SIZE_BYTES_WITH_TOLERANCE = | ||
| PRIVMON_USERS_CSV_MAX_SIZE_BYTES + PRIVMON_USERS_CSV_SIZE_TOLERANCE_BYTES; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
the shiny new URL consts all organised
hop-dev
commented
Aug 28, 2025
| dataClient.audit( | ||
| PrivilegeMonitoringEngineActions.INIT, | ||
| EngineComponentResourceEnum.privmon_engine, | ||
| MonitoringEngineComponentResourceEnum.privmon_engine, |
Contributor
Author
There was a problem hiding this comment.
this variable name conflicted with a variable name in the entity store
Contributor
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @hop-dev |
CAWilson94
reviewed
Sep 2, 2025
| }); | ||
| } | ||
| } | ||
| ); |
Contributor
There was a problem hiding this comment.
Nice, thank you! 🚀 Just to double-check I’ve got the diffs right:
• Updated the URL to use the constant
• Logger now passed in
• Route registered via the createMonitoringEntitySourceRoute factory
Did I miss anything? 😄
CAWilson94
reviewed
Sep 2, 2025
| try { | ||
| await assertAdvancedSettingsEnabled( | ||
| await context.core, | ||
| ENABLE_PRIVILEGED_USER_MONITORING_SETTING |
CAWilson94
approved these changes
Sep 2, 2025
Contributor
CAWilson94
left a comment
CAWilson94
left a comment
There was a problem hiding this comment.
LOOKS_GOOD_TO_ME thanks for taking the time to do this 🎉
MichelLosier
pushed a commit
to MichelLosier/kibana
that referenced
this pull request
Sep 2, 2025
…tic#233400) ## Summary Currently blocked by elastic#233112 Some tidying of the privmon code: - move all privmon URLs to constants - split monitoring entity source routes into their own files - tidy .gen imports by creating a few .index.ts files (allows us to consolidate imports and makes the paths a lot shorter) It might be nicer to review commit by commit
kowalczyk-krzysztof
pushed a commit
to kowalczyk-krzysztof/kibana
that referenced
this pull request
Sep 3, 2025
…tic#233400) ## Summary Currently blocked by elastic#233112 Some tidying of the privmon code: - move all privmon URLs to constants - split monitoring entity source routes into their own files - tidy .gen imports by creating a few .index.ts files (allows us to consolidate imports and makes the paths a lot shorter) It might be nicer to review commit by commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently blocked by #233112
Some tidying of the privmon code:
It might be nicer to review commit by commit