[SKA] move generated integration API test clients to a new location#233112

Merged

maximpn merged 1 commit intoelastic:mainfrom

maximpn:ska-security-solution-move-auto-generated-files

Aug 29, 2025

Contributor

maximpn commented Aug 27, 2025 •

edited by kibanamachine

Loading

Relates to: #231416

Summary

This PR reconfigures the generation script to output Security Solution auto-generated integration API test clients to the new x-pack/solutions/security/test/api_integration/services location.

maximpn self-assigned this

maximpn added release_note:skip Team:Detections and Resp Team: SecuritySolution Team:Detection Rule Management backport:version v9.1.3 v8.19.3 v9.2.0 labels

maximpn force-pushed the ska-security-solution-move-auto-generated-files branch 2 times, most recently from c23ab04 to 368760c Compare

August 28, 2025 07:25

maximpn requested a review from jkelas

August 28, 2025 11:48

maximpn marked this pull request as ready for review

August 28, 2025 11:48

maximpn requested review from a team as code owners

August 28, 2025 11:48

maximpn requested a review from rylnd

August 28, 2025 11:48

Contributor

elasticmachine commented Aug 28, 2025

Pinging @elastic/security-detections-response (Team:Detections and Resp)

maximpn requested review from pzl and szwarckonrad

August 28, 2025 11:48

Contributor

elasticmachine commented Aug 28, 2025

Pinging @elastic/security-solution (Team: SecuritySolution)

Contributor

elasticmachine commented Aug 28, 2025

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

dmlemeshko approved these changes

View reviewed changes

Contributor

dmlemeshko left a comment

x-pack/test/tsconfig.json changes LGTM.

Thank a lot for the fix, I missed generation during relocation PR.

maximpn changed the title ~~[SKA] move generated integration API tests client to a new location~~ [SKA] move generated integration API test clients to a new location

dmlemeshko reviewed

View reviewed changes

x-pack/solutions/security/test/api_integration/services/security_solution_osquery_api.gen.ts Outdated

-              import type { FtrProviderContext } from '../ftr_provider_context';
+              import { getRouteUrlForSpace } from '@kbn/spaces-plugin/common';
+              import type { FtrProviderContext } from '@kbn/test-suites-xpack/api_integration/ftr_provider_context';

Contributor

dmlemeshko Aug 28, 2025

@maximpn you need use the one located in solution test directory (or create a new one)

dmlemeshko reviewed

View reviewed changes

x-pack/solutions/security/test/api_integration/services/security_solution_lists_api.gen.ts Outdated

-              import type { FtrProviderContext } from '../ftr_provider_context';
+              import { getRouteUrlForSpace } from '@kbn/spaces-plugin/common';
+              import type { FtrProviderContext } from '@kbn/test-suites-xpack/api_integration/ftr_provider_context';

Contributor

dmlemeshko Aug 28, 2025 •

edited

Loading

same here, x-pack/test will be gone asap

jkelas approved these changes

View reviewed changes

Contributor

jkelas left a comment

From the Rules Management perspective LGTM, Kibana works fine, approving.

rylnd approved these changes

View reviewed changes

Contributor

rylnd left a comment

Other than @dmlemeshko's comments about the FTRProviderContext, detection engine changes LGTM.

Contributor

kibanamachine commented Sep 2, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

maximpn mentioned this pull request

[Security Solution] Get rid of esArchiver in import custom rules integration tests #229492

Merged

hop-dev added a commit that referenced this pull request


          [Entity Analytics][Chore] Tidy Privmon URLs, imports and routes (#233400

08da8a2

)

## Summary

Currently blocked by #233112

Some tidying of the privmon code:

- move all privmon URLs to constants
- split monitoring entity source routes into their own files
- tidy .gen imports by creating a few .index.ts files (allows us to
consolidate imports and makes the paths a lot shorter)

It might be nicer to review commit by commit

MichelLosier pushed a commit to MichelLosier/kibana that referenced this pull request


          [Entity Analytics][Chore] Tidy Privmon URLs, imports and routes (elas…

f511972

…tic#233400)

## Summary

Currently blocked by elastic#233112

Some tidying of the privmon code:

- move all privmon URLs to constants
- split monitoring entity source routes into their own files
- tidy .gen imports by creating a few .index.ts files (allows us to
consolidate imports and makes the paths a lot shorter)

It might be nicer to review commit by commit

kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this pull request


          [Entity Analytics][Chore] Tidy Privmon URLs, imports and routes (elas…

1a03d1e

…tic#233400)

## Summary

Currently blocked by elastic#233112

Some tidying of the privmon code:

- move all privmon URLs to constants
- split monitoring entity source routes into their own files
- tidy .gen imports by creating a few .index.ts files (allows us to
consolidate imports and makes the paths a lot shorter)

It might be nicer to review commit by commit

Contributor

kibanamachine commented Sep 3, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

5 similar comments

Contributor

kibanamachine commented Sep 4, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 5, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 8, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 9, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 10, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

maximpn mentioned this pull request

[Security Solution] Get rid of services duplicates in API integration tests #234642

Closed

6 tasks

Contributor

kibanamachine commented Sep 11, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

10 similar comments

Contributor

kibanamachine commented Sep 12, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 15, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 16, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 17, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 18, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 19, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 22, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 23, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 24, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

Contributor

kibanamachine commented Sep 26, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

kibanamachine mentioned this pull request

[Security Solution] Remove duplicated services used in integration tests #235221

Merged

Contributor

kibanamachine commented Sep 29, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

1 similar comment

Contributor

kibanamachine commented Sep 30, 2025

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233112 locally
cc: @maximpn

maximpn added backport:skip and removed backport:version labels

kibanamachine removed the backport missing label

kibanamachine mentioned this pull request

[Security Solution] Allow generated API services to be re-scoped to other users #241909

Merged

7 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dmlemeshko dmlemeshko approved these changes

rylnd rylnd approved these changes

szwarckonrad szwarckonrad approved these changes

pzl Awaiting requested review from pzl pzl is a code owner automatically assigned from elastic/security-defend-workflows

+1 more reviewer

jkelas jkelas approved these changes

Labels

backport:skip release_note:skip Team:Detection Rule Management Team:Detections and Resp Team: SecuritySolution v8.19.3 v9.1.3 v9.2.0