Ensure run_message_email required attribute is valid by tobio · Pull Request #233249 · elastic/kibana

tobio · 2025-08-28T06:11:42Z

Summary

From the spec, the required attribute is simply a list of property names and does not support more complex forms.

Related to #228077

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
Flaky Test Runner was used on any tests changed
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
Review the backport guidelines and apply applicable backport:* labels.

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'

elasticmachine · 2025-09-01T15:03:11Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1e13ff8

Failed CI Steps

FTR Configs #8

Metrics [docs]

✅ unchanged

History

💚 Build #333458 succeeded ab26be3

cc @tobio

…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'

kibanamachine · 2025-09-02T01:04:55Z

Starting backport for target branches: 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/17390290317

kibanamachine · 2025-09-02T01:12:21Z

💔 All backports failed

Status	Branch	Result
❌	8.18	Backport failed because of merge conflicts You might need to backport the following PRs to 8.18: - [Discover][Enzyme Test Migration] Migrate discover plugin unit tests to RTL (#231693) - Use optimistic concurrency in SO migrations (#231406)
❌	8.19	Backport failed because of merge conflicts You might need to backport the following PRs to 8.19: - [Discover][Enzyme Test Migration] Migrate discover plugin unit tests to RTL (#231693) - Use optimistic concurrency in SO migrations (#231406) - apache-arrow: ensure v20+ (#233625) - [Remote Clusters] Add IPv6 support (#233415) - [ska] remove kbn/test-suites-xpack imports (#233427)
❌	9.0	Backport failed because of merge conflicts You might need to backport the following PRs to 9.0: - [Discover][Enzyme Test Migration] Migrate discover plugin unit tests to RTL (#231693) - Use optimistic concurrency in SO migrations (#231406)
❌	9.1	Backport failed because of merge conflicts You might need to backport the following PRs to 9.1: - [Discover][Enzyme Test Migration] Migrate discover plugin unit tests to RTL (#231693) - Add overlay for Fleet remote synced integrations API (#233493) - [Remote Clusters] Add IPv6 support (#233415) - [ska] remove kbn/test-suites-xpack imports (#233427) - [Fleet] remove sync integrations APIs in serverless (#233482)

Manual backport

To create the backport manually run:

node scripts/backport --pr 233249

Questions ?

Please refer to the Backport tool documentation

## Summary From the [spec](https://swagger.io/docs/specification/v3_0/data-models/data-types/#required-properties), the `required` attribute is simply a list of property names and does not support more complex forms. Related to elastic#228077 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2025-09-03T01:49:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233249 locally
cc: @tobio

## Summary From the [spec](https://swagger.io/docs/specification/v3_0/data-models/data-types/#required-properties), the `required` attribute is simply a list of property names and does not support more complex forms. Related to elastic#228077 ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2025-09-04T02:48:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 233249 locally
cc: @tobio

Ensure run_message_email required attribute is valid

459f931

tobio self-assigned this Aug 28, 2025

tobio added the backport:all-open Backport to all branches that could still receive a release label Aug 28, 2025

tobio requested review from a team as code owners August 28, 2025 06:11

tobio added the release_note:skip Skip the PR/issue when compiling release notes label Aug 28, 2025

elastic-vault-github-plugin-prod bot requested a review from a team as a code owner August 28, 2025 06:25

mdbirnstiehl approved these changes Aug 28, 2025

View reviewed changes

tobio enabled auto-merge (squash) August 28, 2025 22:00

tobio mentioned this pull request Aug 28, 2025

[OAS] Fix validation errors in generated spec #228077

Open

tobio and others added 2 commits September 1, 2025 10:55

Merge branch 'main' into fix-run-message-email-api-spec

d37de93

adcoelho approved these changes Sep 1, 2025

View reviewed changes

tobio and others added 2 commits September 1, 2025 22:34

Merge branch 'main' into fix-run-message-email-api-spec

512afe9

afharo approved these changes Sep 1, 2025

View reviewed changes

tobio and others added 2 commits September 2, 2025 09:05

Merge branch 'main' into fix-run-message-email-api-spec

5753ee2

tobio merged commit 110ee15 into elastic:main Sep 2, 2025
13 checks passed

kibanamachine added the v9.2.0 label Sep 2, 2025

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Sep 3, 2025

tobio added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. backport:all-open Backport to all branches that could still receive a release labels Sep 4, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure run_message_email required attribute is valid#233249

Ensure run_message_email required attribute is valid#233249
tobio merged 8 commits intoelastic:mainfrom
tobio:fix-run-message-email-api-spec

tobio commented Aug 28, 2025 •

edited by kibanamachine

Loading

Uh oh!

elasticmachine commented Sep 1, 2025

Uh oh!

Uh oh!

kibanamachine commented Sep 2, 2025

Uh oh!

kibanamachine commented Sep 2, 2025

Uh oh!

kibanamachine commented Sep 3, 2025

Uh oh!

kibanamachine commented Sep 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

tobio commented Aug 28, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elasticmachine commented Sep 1, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

History

Uh oh!

Uh oh!

kibanamachine commented Sep 2, 2025

Uh oh!

kibanamachine commented Sep 2, 2025

💔 All backports failed

Manual backport

Questions ?

Uh oh!

kibanamachine commented Sep 3, 2025

Uh oh!

kibanamachine commented Sep 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tobio commented Aug 28, 2025 •

edited by kibanamachine

Loading