Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c476cff
[Security Solution] Skipped tests: flaky Suricata tests
agusruidiazgd Aug 12, 2025
bb57870
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 13, 2025
c9af01c
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 13, 2025
c79ce3d
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 13, 2025
083da4f
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 14, 2025
6e40b31
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 14, 2025
0cf6193
flaky test runner
agusruidiazgd Aug 18, 2025
d1d8997
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 20, 2025
8080cd2
isolate suricata test
agusruidiazgd Aug 22, 2025
bfadaf9
Merge branch 'main' into fix/row_renderer-issue-126894
elasticmachine Aug 25, 2025
69f818b
undo package.json changes
agusruidiazgd Aug 25, 2025
dee7223
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 26, 2025
3fc6f1f
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 26, 2025
2c5b635
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Aug 27, 2025
a4cada5
Merge branch 'main' into fix/row_renderer-issue-126894
elasticmachine Sep 22, 2025
8dc6e6e
Merge branch 'main' into fix/row_renderer-issue-126894
elasticmachine Sep 29, 2025
cd328c2
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Sep 30, 2025
2a79276
Merge branch 'main' into fix/row_renderer-issue-126894
elasticmachine Oct 2, 2025
958f203
Merge branch 'main' into fix/row_renderer-issue-126894
agusruidiazgd Oct 27, 2025
818d549
Merge branch 'main' into fix/row_renderer-issue-126894
PhilippeOberti Nov 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,11 @@
* 2.0.
*/

import { elementsOverlap } from '../../../helpers/rules';
import {
TIMELINE_ROW_RENDERERS_DISABLE_ALL_BTN,
TIMELINE_ROW_RENDERERS_MODAL_ITEMS_CHECKBOX,
TIMELINE_ROW_RENDERERS_SEARCHBOX,
TIMELINE_SHOW_ROW_RENDERERS_GEAR,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP,
TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP,
TIMELINE_ROW_RENDERERS_MODAL_CLOSE_BUTTON,
TIMELINE_ROW_RENDERERS_WRAPPER,
} from '../../../screens/timeline';
Expand Down Expand Up @@ -130,22 +126,4 @@ describe('Row renderers', { tags: ['@ess', '@serverless'] }, () => {

cy.wait('@updateTimeline').its('response.statusCode').should('eq', 200);
});

describe('Suricata', () => {
// This test has become very flaky over time and was blocking a lot of PRs.
// A follw-up ticket to tackle this issue has been created.
it.skip('Signature tooltips do not overlap', () => {
// Hover the signature to show the tooltips
cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE).parents('.euiPopover').realHover();

cy.get(TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP).then(($googleLinkTooltip) => {
cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP).then(($signatureTooltip) => {
expect(
elementsOverlap($googleLinkTooltip, $signatureTooltip),
'tooltips do not overlap'
).to.equal(false);
});
});
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License
* 2.0; you may not use this file except in compliance with the Elastic License
* 2.0.
*/

import { elementsOverlap } from '../../../helpers/rules';
import {
TIMELINE_ROW_RENDERERS_SEARCHBOX,
TIMELINE_SHOW_ROW_RENDERERS_GEAR,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE,
TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP,
TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP,
} from '../../../screens/timeline';
import { deleteTimelines } from '../../../tasks/api_calls/timelines';
import { waitForWelcomePanelToBeLoaded } from '../../../tasks/common';
import { waitForAllHostsToBeLoaded } from '../../../tasks/hosts/all_hosts';

import { login } from '../../../tasks/login';
import { visitWithTimeRange } from '../../../tasks/navigation';
import { openTimelineUsingToggle } from '../../../tasks/security_main';
import { populateTimeline } from '../../../tasks/timeline';

import { hostsUrl } from '../../../urls/navigation';

describe('Row renderers - Suricata', { tags: ['@ess', '@serverless'] }, () => {
before(() => {
cy.task('esArchiverLoad', { archiveName: 'bulk_process' });
});

after(() => {
cy.task('esArchiverUnload', { archiveName: 'bulk_process' });
});
beforeEach(() => {
deleteTimelines();
login();
visitWithTimeRange(hostsUrl('allHosts'), {
visitOptions: {
onLoad: () => {
waitForWelcomePanelToBeLoaded();
waitForAllHostsToBeLoaded();
},
},
});
openTimelineUsingToggle();
populateTimeline();
});

it('Signature tooltips do not overlap', () => {
// Hover the signature to show the tooltips
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding a comment, the block of code that performs the hover should be extracted into a task.

cy.get(TIMELINE_SHOW_ROW_RENDERERS_GEAR).realClick();
cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).should('exist');
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cypress automatically waits for the element to exist and be visible before .type(), so should('exist') is redundant.

Moreover should('exist') might be flaky, since the element might exist in the DOM and not be visible, so in case of wanting to check something is more robust to check the visibility.

cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).type('suricata');

cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE, { timeout: 3000 }).realHover();

cy.get(TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP).then(($googleLinkTooltip) => {
cy.get(TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP).then(($signatureTooltip) => {
expect(
elementsOverlap($googleLinkTooltip, $signatureTooltip),
'tooltips do not overlap'
).to.equal(false);
});
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ export const TIMELINE_ROW_RENDERERS_SEARCHBOX = `${TIMELINE_ROW_RENDERERS_MODAL}

export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE = `${TIMELINE_ROW_RENDERERS_MODAL} [data-test-subj="render-content-suricata.eve.alert.signature"]`;

export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLinkTooltip"]`;
export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLink"]`;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used only in one test


export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE_TOOLTIP = `[data-test-subj="suricata.eve.alert.signature-tooltip"]`;

Expand Down