[Security Solution] Skipped tests: flaky Suricata tests#231473
[Security Solution] Skipped tests: flaky Suricata tests#231473agusruidiazgd merged 20 commits intoelastic:mainfrom
Conversation
agusruidiazgd
added
release_note:skip
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
| export const TIMELINE_ROW_RENDERERS_SURICATA_SIGNATURE = `${TIMELINE_ROW_RENDERERS_MODAL} [data-test-subj="render-content-suricata.eve.alert.signature"]`; | ||
|
|
||
| export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLinkTooltip"]`; | ||
| export const TIMELINE_ROW_RENDERERS_SURICATA_LINK_TOOLTIP = `[data-test-subj="externalLink"]`; |
There was a problem hiding this comment.
used only in one test
| cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).should('exist'); | ||
| cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).type('suricata'); |
There was a problem hiding this comment.
check that Suricata item is on the screen
|
Let's run theFlaky Test Runner for this one as well... Take a look at this commit to hack your way around and run the Flaky Test Runner only for that one file, it'll save you a ton of time! The link to the Flaky Test Runner is at the top of this documentation. I have ran mine 25 times for Just make sure that you undo the change to the |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9167[❌] Security Solution Investigations - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#9183[❌] Security Solution Investigations - Cypress: 0/25 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#9208[✅] Security Solution Investigations - Cypress: 25/25 tests passed. |
|
@elasticmachine merge upstream |
NicholasPeretti
left a comment
NicholasPeretti
left a comment
There was a problem hiding this comment.
Thank you for taking care of this!
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI Steps
Metrics [docs]
History
|
| }); | ||
|
|
||
| it('Signature tooltips do not overlap', () => { | ||
| // Hover the signature to show the tooltips |
There was a problem hiding this comment.
Instead of adding a comment, the block of code that performs the hover should be extracted into a task.
| it('Signature tooltips do not overlap', () => { | ||
| // Hover the signature to show the tooltips | ||
| cy.get(TIMELINE_SHOW_ROW_RENDERERS_GEAR).realClick(); | ||
| cy.get(TIMELINE_ROW_RENDERERS_SEARCHBOX).should('exist'); |
There was a problem hiding this comment.
Cypress automatically waits for the element to exist and be visible before .type(), so should('exist') is redundant.
Moreover should('exist') might be flaky, since the element might exist in the DOM and not be visible, so in case of wanting to check something is more robust to check the visibility.
|
Has this test been exercised recently using the flaky test runner? |
)" This reverts commit b66c54a.
|
Sorry for the trouble, this PR was able to accidently get through auto-merge and has been reverted |
7 participants
Summary
Closes #126894
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.