Skip to content

[Streams] Remove managed index template properties from PUT request #231394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miltonhultgren merged 1 commit into from
Aug 12, 2025
Merged

[Streams] Remove managed index template properties from PUT request #231394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions .../lib/streams/state_management/execution_plan/translate_classic_stream_pipeline_actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import type { IngestPipeline } from '@elastic/elasticsearch/lib/api/types';
import type { IndicesIndexTemplate, IngestPipeline } from '@elastic/elasticsearch/lib/api/types';
import type { IScopedClusterClient } from '@kbn/core/server';
import { isNotFoundError } from '@kbn/es-errors';
import { castArray, groupBy, omit, uniq } from 'lodash';
Expand Down Expand Up @@ -111,21 +111,28 @@ async function createStreamsManagedPipeline({
},
});

// Remove properties from the GET response that cannot be in the PUT request
// eslint-disable-next-line @typescript-eslint/naming-convention
const { created_date_millis, modified_date_millis, ...safeTemplate } =
indexTemplate.index_template as IndicesIndexTemplate & {
created_date_millis: number;
modified_date_millis: number;
};

actionsByType.upsert_index_template.push({
type: 'upsert_index_template',
request: {
name: indexTemplate.name,
...indexTemplate.index_template,
ignore_missing_component_templates: indexTemplate.index_template
.ignore_missing_component_templates
? castArray(indexTemplate.index_template.ignore_missing_component_templates)
...safeTemplate,
ignore_missing_component_templates: safeTemplate.ignore_missing_component_templates
? castArray(safeTemplate.ignore_missing_component_templates)
: [],
template: {
...(indexTemplate.index_template.template ?? {}),
...(safeTemplate.template ?? {}),
settings: {
...(indexTemplate.index_template.template?.settings ?? {}),
...(safeTemplate.template?.settings ?? {}),
index: {
...(indexTemplate.index_template.template?.settings?.index ?? {}),
...(safeTemplate.template?.settings?.index ?? {}),
default_pipeline: pipelineName,
},
},
Expand Down