Skip to content

[Streams] Remove managed index template properties from PUT request#231394

Merged
miltonhultgren merged 1 commit intoelastic:mainfrom
miltonhultgren:streams-remove-managed-index-template-properties
Aug 12, 2025
Merged

[Streams] Remove managed index template properties from PUT request#231394
miltonhultgren merged 1 commit intoelastic:mainfrom
miltonhultgren:streams-remove-managed-index-template-properties

Conversation

@miltonhultgren
Copy link
Contributor

@miltonhultgren miltonhultgren commented Aug 12, 2025

Recent changes to Elasticsearch now makes the GET index_template response include two properties (created_date, modification_date). When updating Ingest Pipelines for Classic Streams, we read this index template using GET and spread the response into our request where we modify the pipeline. This means we pass these new properties as part of the PUT index_template request which Elasticsearch rejects.
This PR just removes those two properties from the PUT request.

@miltonhultgren miltonhultgren added the release_note:skip Skip the PR/issue when compiling release notes label Aug 12, 2025
@miltonhultgren miltonhultgren requested a review from a team as a code owner August 12, 2025 08:37
@miltonhultgren miltonhultgren added backport:skip This PR does not require backporting Feature:Streams This is the label for the Streams Project labels Aug 12, 2025
@miltonhultgren miltonhultgren enabled auto-merge (squash) August 12, 2025 09:04
@miltonhultgren miltonhultgren merged commit 49b06b2 into elastic:main Aug 12, 2025
20 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
streams 4 5 +1

Total ESLint disabled count

id before after diff
streams 10 11 +1

@achyutjhunjhunwala
Copy link
Contributor

Is it possible to link the Elasticsearch issue here ?

i found an ES issue but its not resolved - elastic/elasticsearch#88225

@masseyke
Copy link
Member

masseyke commented Aug 13, 2025

Looks like it went into elastic/elasticsearch#132083.

@szybia
Copy link

szybia commented Aug 13, 2025

ES issue: elastic/elasticsearch#108754

@dmlemeshko
Copy link
Contributor

shouldn't it be backported to 9.1.x? We can see the same test failure in the branch

delanni pushed a commit that referenced this pull request Aug 15, 2025
## Summary

Skipping test to unblock backport pipelines while
#231394 is not backported itself
@miltonhultgren miltonhultgren added backport:version Backport to applied version labels v9.1.0 and removed backport:skip This PR does not require backporting labels Aug 18, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/17034704633

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 18, 2025
…lastic#231394)

Recent changes to Elasticsearch now makes the GET index_template
response include two properties (created_date, modification_date). When
updating Ingest Pipelines for Classic Streams, we read this index
template using GET and spread the response into our request where we
modify the pipeline. This means we pass these new properties as part of
the PUT index_template request which Elasticsearch rejects.
This PR just removes those two properties from the PUT request.

(cherry picked from commit 49b06b2)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 18, 2025
…uest (#231394) (#232054)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Streams] Remove managed index template properties from PUT request
(#231394)](#231394)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Milton
Hultgren","email":"milton.hultgren@elastic.co"},"sourceCommit":{"committedDate":"2025-08-12T11:11:17Z","message":"[Streams]
Remove managed index template properties from PUT request
(#231394)\n\nRecent changes to Elasticsearch now makes the GET
index_template\nresponse include two properties (created_date,
modification_date). When\nupdating Ingest Pipelines for Classic Streams,
we read this index\ntemplate using GET and spread the response into our
request where we\nmodify the pipeline. This means we pass these new
properties as part of\nthe PUT index_template request which
Elasticsearch rejects.\nThis PR just removes those two properties from
the PUT
request.","sha":"49b06b23812b287cfe1789994692895f524aa4bb","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","Feature:Streams","v9.1.0","v9.2.0"],"title":"[Streams]
Remove managed index template properties from PUT
request","number":231394,"url":"https://github.com/elastic/kibana/pull/231394","mergeCommit":{"message":"[Streams]
Remove managed index template properties from PUT request
(#231394)\n\nRecent changes to Elasticsearch now makes the GET
index_template\nresponse include two properties (created_date,
modification_date). When\nupdating Ingest Pipelines for Classic Streams,
we read this index\ntemplate using GET and spread the response into our
request where we\nmodify the pipeline. This means we pass these new
properties as part of\nthe PUT index_template request which
Elasticsearch rejects.\nThis PR just removes those two properties from
the PUT
request.","sha":"49b06b23812b287cfe1789994692895f524aa4bb"}},"sourceBranch":"main","suggestedTargetBranches":["9.1"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/231394","number":231394,"mergeCommit":{"message":"[Streams]
Remove managed index template properties from PUT request
(#231394)\n\nRecent changes to Elasticsearch now makes the GET
index_template\nresponse include two properties (created_date,
modification_date). When\nupdating Ingest Pipelines for Classic Streams,
we read this index\ntemplate using GET and spread the response into our
request where we\nmodify the pipeline. This means we pass these new
properties as part of\nthe PUT index_template request which
Elasticsearch rejects.\nThis PR just removes those two properties from
the PUT request.","sha":"49b06b23812b287cfe1789994692895f524aa4bb"}}]}]
BACKPORT-->

Co-authored-by: Milton Hultgren <milton.hultgren@elastic.co>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…lastic#231394)

Recent changes to Elasticsearch now makes the GET index_template
response include two properties (created_date, modification_date). When
updating Ingest Pipelines for Classic Streams, we read this index
template using GET and spread the response into our request where we
modify the pipeline. This means we pass these new properties as part of
the PUT index_template request which Elasticsearch rejects.
This PR just removes those two properties from the PUT request.
qn895 pushed a commit to qn895/kibana that referenced this pull request Aug 26, 2025
…lastic#231394)

Recent changes to Elasticsearch now makes the GET index_template
response include two properties (created_date, modification_date). When
updating Ingest Pipelines for Classic Streams, we read this index
template using GET and spread the response into our request where we
modify the pipeline. This means we pass these new properties as part of
the PUT index_template request which Elasticsearch rejects.
This PR just removes those two properties from the PUT request.
flash1293 added a commit that referenced this pull request Oct 30, 2025
Fixes #235000
Fixes #235001

Basically the same as #231394 ,
but for 8.19

Streams isn't even visible in 8.19, this is just to get the tests to
pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels Feature:Streams This is the label for the Streams Project release_note:skip Skip the PR/issue when compiling release notes v9.1.0 v9.1.3 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants