Skip to content

fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement #230733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexwizp merged 2 commits into from
Aug 6, 2025
Merged

fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement #230733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
589b90c
fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyo…
alexwizp Aug 6, 2025
bc52fe6
Merge branch 'main' into #216266
alexwizp Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/platform/plugins/shared/data_view_editor/public/components/data_view_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ export const DataViewEditor = ({

return (
<KibanaReactContextProvider>
<EuiFlyout onClose={() => {}} hideCloseButton={true} size="l">
<EuiFlyout
onClose={() => {}}
hideCloseButton={true}
size="l"
aria-labelledby="dataViewEditorFlyoutTitle"
>
<DataViewEditorLazy
onSave={onSave}
onCancel={onCancel}
Expand Down
2 changes: 1 addition & 1 deletion ...orm/plugins/shared/data_view_editor/public/components/data_view_editor_flyout_content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ const IndexPatternEditorFlyoutContentComponent = ({
<FlyoutPanels.Item data-test-subj="indexPatternEditorFlyout" border="right">
<FlyoutPanels.Content>
<EuiTitle data-test-subj="flyoutTitle">
<h2>{editData ? editorTitleEditMode : editorTitle}</h2>
<h2 id="dataViewEditorFlyoutTitle">{editData ? editorTitleEditMode : editorTitle}</h2>
</EuiTitle>
{showManagementLink && editData && editData.id && (
<EuiLink
Expand Down
1 change: 1 addition & 0 deletions src/platform/plugins/shared/data_view_editor/public/open_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const getEditorOpener =
// EUI TODO: This z-index override of EuiOverlayMask is a workaround, and ideally should be resolved with a cleaner UI/UX flow long-term
style: 'z-index: 1003', // we need this flyout to be above the timeline flyout (which has a z-index of 1002)
},
'aria-labelledby': 'dataViewEditorFlyoutTitle',
}
);

Expand Down