Skip to content

Conversation

@alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Aug 6, 2025

Closes: #216266

Description
Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it.

Changes made

  1. Added required ARIA attributes

Screen

Screenshot 2025-08-06 at 12 19 06

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Project:Accessibility labels Aug 6, 2025
@alexwizp alexwizp marked this pull request as ready for review August 6, 2025 09:21
@alexwizp alexwizp requested a review from a team as a code owner August 6, 2025 09:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

Copy link
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, thanks

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #20 / InfraOps App Metrics UI Home page with metrics present group nodes by custom field

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataViewEditor 42.2KB 42.2KB +28.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViewEditor 6.9KB 7.0KB +92.0B

@alexwizp alexwizp merged commit a96f781 into elastic:main Aug 6, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 9.1

https://github.com/elastic/kibana/actions/runs/16777345985

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Aug 6, 2025
…ut missing title from announcement (elastic#230733)

Closes: elastic#216266

**Description**
Dialog modal, flyout, field visible title should be announced for the
users, especially using assistive technology to know what dialog modal,
flyout opened, what field is active and what is needed to enter in it.

**Changes made**
1. Added required ARIA attributes

**Screen**

<img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06"
src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571"
/>

(cherry picked from commit a96f781)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Aug 6, 2025
…e]Flyout missing title from announcement (#230733) (#230780)

# Backport

This will backport the following commits from `main` to `9.1`:
- [fix: [Analytics:MachineLearning:AnomalyDetection:Create Job
page]Flyout missing title from announcement
(#230733)](#230733)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-06T12:47:20Z","message":"fix:
[Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout
missing title from announcement (#230733)\n\nCloses:
#216266\n\n**Description**\nDialog modal, flyout, field visible title
should be announced for the\nusers, especially using assistive
technology to know what dialog modal,\nflyout opened, what field is
active and what is needed to enter in it.\n\n**Changes made**\n1. Added
required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\"
height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19
06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix:
[Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout
missing title from
announcement","number":230733,"url":"https://github.com/elastic/kibana/pull/230733","mergeCommit":{"message":"fix:
[Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout
missing title from announcement (#230733)\n\nCloses:
#216266\n\n**Description**\nDialog modal, flyout, field visible title
should be announced for the\nusers, especially using assistive
technology to know what dialog modal,\nflyout opened, what field is
active and what is needed to enter in it.\n\n**Changes made**\n1. Added
required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\"
height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19
06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230733","number":230733,"mergeCommit":{"message":"fix:
[Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout
missing title from announcement (#230733)\n\nCloses:
#216266\n\n**Description**\nDialog modal, flyout, field visible title
should be announced for the\nusers, especially using assistive
technology to know what dialog modal,\nflyout opened, what field is
active and what is needed to enter in it.\n\n**Changes made**\n1. Added
required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\"
height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19
06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Aug 7, 2025
…ut missing title from announcement (elastic#230733)

Closes: elastic#216266

**Description**
Dialog modal, flyout, field visible title should be announced for the
users, especially using assistive technology to know what dialog modal,
flyout opened, what field is active and what is needed to enter in it.

**Changes made**
1. Added required ARIA attributes


**Screen**

<img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06"
src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571"
/>
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
@mistic mistic added v9.1.2 and removed v9.1.1 labels Aug 7, 2025
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…ut missing title from announcement (elastic#230733)

Closes: elastic#216266

**Description**
Dialog modal, flyout, field visible title should be announced for the
users, especially using assistive technology to know what dialog modal,
flyout opened, what field is active and what is needed to enter in it.

**Changes made**
1. Added required ARIA attributes


**Screen**

<img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06"
src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.1.2 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement

5 participants