-
Notifications
You must be signed in to change notification settings - Fork 8.5k
fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement #230733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ut missing title from announcement Closes: elastic#216266
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
akowalska622
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT, thanks
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
|
|
Starting backport for target branches: 9.1 https://github.com/elastic/kibana/actions/runs/16777345985 |
…ut missing title from announcement (elastic#230733) Closes: elastic#216266 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made** 1. Added required ARIA attributes **Screen** <img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06" src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571" /> (cherry picked from commit a96f781)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…e]Flyout missing title from announcement (#230733) (#230780) # Backport This will backport the following commits from `main` to `9.1`: - [fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement (#230733)](#230733) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2025-08-06T12:47:20Z","message":"fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement (#230733)\n\nCloses: #216266\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made**\n1. Added required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\" height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19 06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","backport:prev-minor","v9.2.0"],"title":"fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement","number":230733,"url":"https://github.com/elastic/kibana/pull/230733","mergeCommit":{"message":"fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement (#230733)\n\nCloses: #216266\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made**\n1. Added required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\" height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19 06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230733","number":230733,"mergeCommit":{"message":"fix: [Analytics:MachineLearning:AnomalyDetection:Create Job page]Flyout missing title from announcement (#230733)\n\nCloses: #216266\n\n**Description**\nDialog modal, flyout, field visible title should be announced for the\nusers, especially using assistive technology to know what dialog modal,\nflyout opened, what field is active and what is needed to enter in it.\n\n**Changes made**\n1. Added required ARIA attributes\n\n\n**Screen**\n\n<img width=\"1516\" height=\"692\" alt=\"Screenshot 2025-08-06 at 12 19 06\"\nsrc=\"https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571\"\n/>","sha":"a96f781740a7c863bfd9f3b92e414754709308a1"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
…ut missing title from announcement (elastic#230733) Closes: elastic#216266 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made** 1. Added required ARIA attributes **Screen** <img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06" src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571" />
…ut missing title from announcement (elastic#230733) Closes: elastic#216266 **Description** Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it. **Changes made** 1. Added required ARIA attributes **Screen** <img width="1516" height="692" alt="Screenshot 2025-08-06 at 12 19 06" src="https://github.com/user-attachments/assets/0ffb1577-1541-483c-b19d-e16696949571" />
Closes: #216266
Description
Dialog modal, flyout, field visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened, what field is active and what is needed to enter in it.
Changes made
Screen