Skip to content

[8.19] Remove react-is dependency (#230117)#230455

Merged
legrego merged 5 commits intoelastic:8.19from
legrego:backport/8.19/pr-230117
Aug 5, 2025
Merged

[8.19] Remove react-is dependency (#230117)#230455
legrego merged 5 commits intoelastic:8.19from
legrego:backport/8.19/pr-230117

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented Aug 4, 2025

Backport

This will backport the following commits from main to 8.19:

Questions ?

Please refer to the Backport tool documentation

@legrego
Remove react-is dependency (elastic#230117)
b48aeb8 
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8d27fcf)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/datasources/form_based/form_based.test.ts
@legrego legrego requested a review from kibanamachine as a code owner August 4, 2025 16:31
@legrego legrego added the backport This PR is a backport of another PR label Aug 4, 2025
@legrego legrego enabled auto-merge (squash) August 4, 2025 16:31
@legrego legrego mentioned this pull request Aug 4, 2025
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 5, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #78 / InfraOps App Metrics UI Metrics UI Anomaly Flyout anomalies table in flyout with anomalies present should take users to hosts list when 'Show affected Hosts' is clicked
  • [job] [logs] FTR Configs #28 / Search solution tests Search Classic Navigation has expected navigation

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 421 419 -2
fleet 1385 1383 -2
kibanaReact 271 269 -2
kibanaUtils 161 159 -2
security 619 617 -2
securitySolution 7602 7600 -2
total -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 63.0KB 60.9KB -2.1KB
fleet 2.0MB 2.0MB -2.1KB
kibanaReact 194.0KB 191.9KB -2.1KB
kibanaUtils 63.0KB 60.9KB -2.1KB
security 533.7KB 531.6KB -2.1KB
securitySolution 9.4MB 9.4MB -2.1KB
total -12.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.1MB 6.1MB -4.3KB

History

kc13greiner
kc13greiner approved these changes Aug 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM!

@legrego legrego merged commit dbbfdf1 into elastic:8.19 Aug 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kc13greiner kc13greiner kc13greiner approved these changes

@kibanamachine kibanamachine Awaiting requested review from kibanamachine kibanamachine is a code owner

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legrego @elasticmachine @kc13greiner @kibanamachine