Skip to content

Remove react-is dependency#230117

Merged
legrego merged 6 commits intoelastic:mainfrom
legrego:remove-react-is
Aug 4, 2025
Merged

Remove react-is dependency#230117
legrego merged 6 commits intoelastic:mainfrom
legrego:remove-react-is

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented Jul 31, 2025

Summary

Removes the react-is dependency in favor of a simple first-party check.

@legrego legrego added chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Jul 31, 2025
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'
@legrego
Copy link
Copy Markdown
Member Author

legrego commented Jul 31, 2025

/ci

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Jul 31, 2025

/ci

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Aug 1, 2025

/ci

kibanamachine and others added 2 commits August 1, 2025 19:03
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/streams --include-path /api/fleet --include-path /api/dashboards --include-path /api/saved_objects/_import --include-path /api/saved_objects/_export --include-path /api/maintenance_window --update'
@legrego legrego added the dependency-reduction initiative to reduce the number of Kibana's third-party dependencies label Aug 4, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #126 / Fleet Endpoints fleet policy secrets fleet server version requirements "after each" hook for "should not store secrets if there are no fleet servers"
  • [job] [logs] FTR Configs #33 / Search Playground - hosted Saved Playgrounds Create a Saved Playground should allow saving playground

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
core 524 522 -2
fleet 1339 1337 -2
kibanaReact 218 216 -2
kibanaUtils 161 159 -2
security 595 593 -2
securitySolution 7814 7812 -2
total -12

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
core 85.3KB 83.1KB -2.1KB
fleet 2.1MB 2.1MB -2.1KB
kibanaReact 187.5KB 185.4KB -2.1KB
kibanaUtils 63.0KB 60.9KB -2.1KB
security 503.5KB 501.4KB -2.1KB
securitySolution 10.3MB 10.3MB -2.1KB
total -12.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 6.5MB 6.5MB -4.3KB

History

@legrego legrego marked this pull request as ready for review August 4, 2025 14:07
@legrego legrego requested a review from a team as a code owner August 4, 2025 14:07
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-security (Team:Security)

@nickofthyme nickofthyme changed the title Remove react-is dependency Remove react-is dependency Aug 4, 2025
@legrego legrego merged commit 8d27fcf into elastic:main Aug 4, 2025
17 checks passed
@legrego legrego deleted the remove-react-is branch August 4, 2025 16:07
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1

https://github.com/elastic/kibana/actions/runs/16728261843

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.17 Backport failed because of merge conflicts
8.18 Backport failed because of merge conflicts
8.19 Backport failed because of merge conflicts
9.0 Backport failed because of merge conflicts
9.1 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 230117

Questions ?

Please refer to the Backport tool documentation

legrego added a commit to legrego/kibana that referenced this pull request Aug 4, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8d27fcf)

# Conflicts:
#	renovate.json
#	x-pack/platform/plugins/shared/lens/public/datasources/form_based/form_based.test.ts
legrego added a commit to legrego/kibana that referenced this pull request Aug 4, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8d27fcf)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/datasources/form_based/form_based.test.ts
legrego added a commit to legrego/kibana that referenced this pull request Aug 4, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8d27fcf)

# Conflicts:
#	x-pack/platform/plugins/shared/lens/public/datasources/form_based/form_based.test.ts
@legrego
Copy link
Copy Markdown
Member Author

legrego commented Aug 4, 2025

💚 All backports created successfully

Status Branch Result
9.1
9.0
8.19
8.18

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

legrego added a commit to legrego/kibana that referenced this pull request Aug 4, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 8d27fcf)

# Conflicts:
#	package.json
#	x-pack/platform/plugins/shared/lens/public/datasources/form_based/form_based.test.ts
#	yarn.lock
szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 5, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @legrego

legrego added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `8.19`:
- [Remove `react-is` dependency
(#230117)](#230117)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T16:07:17Z","message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v9.2.0","dependency-reduction"],"title":"Remove
`react-is`
dependency","number":230117,"url":"https://github.com/elastic/kibana/pull/230117","mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230117","number":230117,"mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `9.1`:
- [Remove `react-is` dependency
(#230117)](#230117)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T16:07:17Z","message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v9.2.0","dependency-reduction"],"title":"Remove
`react-is`
dependency","number":230117,"url":"https://github.com/elastic/kibana/pull/230117","mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230117","number":230117,"mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}}]}]
BACKPORT-->
legrego added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [Remove `react-is` dependency
(#230117)](#230117)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T16:07:17Z","message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v9.2.0","dependency-reduction"],"title":"Remove
`react-is`
dependency","number":230117,"url":"https://github.com/elastic/kibana/pull/230117","mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230117","number":230117,"mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
legrego added a commit that referenced this pull request Aug 5, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [Remove `react-is` dependency
(#230117)](#230117)

<!--- Backport version: 10.0.1 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Larry
Gregory","email":"larry.gregory@elastic.co"},"sourceCommit":{"committedDate":"2025-08-04T16:07:17Z","message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v9.2.0","dependency-reduction"],"title":"Remove
`react-is`
dependency","number":230117,"url":"https://github.com/elastic/kibana/pull/230117","mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230117","number":230117,"mergeCommit":{"message":"Remove
`react-is` dependency (#230117)\n\n## Summary\n\nRemoves the `react-is`
dependency in favor of a simple
first-party\ncheck.\n\n---------\n\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"8d27fcf531e4027e3a03251d4340d6ead74877e1"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine added v9.0.5 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Aug 5, 2025
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
## Summary

Removes the `react-is` dependency in favor of a simple first-party
check.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release chore dependency-reduction initiative to reduce the number of Kibana's third-party dependencies release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.18.5 v8.19.2 v9.0.5 v9.1.2 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants