Skip to content

[APM rules] Handle rule params being undefined in recovered alert #230125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benakansara merged 3 commits into from
Jul 31, 2025
Merged

[APM rules] Handle rule params being undefined in recovered alert #230125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4dd09a7
handle undefined
benakansara Jul 31, 2025
4b40bcb
typo
benakansara Jul 31, 2025
c2cb440
Merge branch 'main' into fix/apm-rules-error
benakansara Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...plugins/apm/server/routes/alerts/rule_types/error_count/register_error_count_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,10 +286,8 @@ export function registerErrorCountRuleType({
const alertUuid = recoveredAlert.alert.getUuid();
const alertDetailsUrl = getAlertDetailsUrl(basePath, spaceId, alertUuid);

const ruleParamsOfRecoveredAlert = alertHits?.[
ALERT_RULE_PARAMETERS
] as ErrorCountRuleTypeParams;
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert.groupBy ?? [];
const ruleParamsOfRecoveredAlert = alertHits?.[ALERT_RULE_PARAMETERS];
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert?.groupBy ?? [];
const allGroupByFieldsOfRecoveredAlert = getAllGroupByFields(
ApmRuleType.ErrorCount,
groupByFieldsOfRecoveredAlert
Expand Down
6 changes: 2 additions & 4 deletions .../routes/alerts/rule_types/transaction_duration/register_transaction_duration_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,8 @@ export function registerTransactionDurationRuleType({
const alertUuid = recoveredAlert.alert.getUuid();
const alertDetailsUrl = getAlertDetailsUrl(basePath, spaceId, alertUuid);

const ruleParamsOfRecoveredAlert = alertHits?.[
ALERT_RULE_PARAMETERS
] as TransactionDurationRuleTypeParams;
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert.groupBy ?? [];
const ruleParamsOfRecoveredAlert = alertHits?.[ALERT_RULE_PARAMETERS];
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert?.groupBy ?? [];
const allGroupByFieldsOfRecoveredAlert = getAllGroupByFields(
ApmRuleType.TransactionDuration,
groupByFieldsOfRecoveredAlert
Expand Down
6 changes: 2 additions & 4 deletions ...tes/alerts/rule_types/transaction_error_rate/register_transaction_error_rate_rule_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,8 @@ export function registerTransactionErrorRateRuleType({
const alertUuid = recoveredAlert.alert.getUuid();
const alertDetailsUrl = getAlertDetailsUrl(basePath, spaceId, alertUuid);

const ruleParamsOfRecoveredAlert = alertHits?.[
ALERT_RULE_PARAMETERS
] as TransactionErrorRateRuleTypeParams;
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert.groupBy ?? [];
const ruleParamsOfRecoveredAlert = alertHits?.[ALERT_RULE_PARAMETERS];
const groupByFieldsOfRecoveredAlert = ruleParamsOfRecoveredAlert?.groupBy ?? [];
const allGroupByFieldsOfRecoveredAlert = getAllGroupByFields(
ApmRuleType.TransactionErrorRate,
groupByFieldsOfRecoveredAlert
Expand Down