Skip to content

[APM rules] Handle rule params being undefined in recovered alert#230125

Merged
benakansara merged 3 commits intoelastic:mainfrom
benakansara:fix/apm-rules-error
Jul 31, 2025
Merged

[APM rules] Handle rule params being undefined in recovered alert#230125
benakansara merged 3 commits intoelastic:mainfrom
benakansara:fix/apm-rules-error

Conversation

@benakansara
Copy link
Contributor

@benakansara benakansara commented Jul 31, 2025

Resolves #229343

  • Handles ruleParamsOfRecoveredAlert being undefined

It's not clear what causes ruleParamsOfRecoveredAlert to be undefined, I am still investigating the root cause. But in case it becomes undefined, it will not fail rule execution.

@benakansara benakansara self-assigned this Jul 31, 2025
@benakansara benakansara requested a review from a team July 31, 2025 19:08
@benakansara benakansara added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. backport:version Backport to applied version labels v9.1.0 v8.19.0 labels Jul 31, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. label Jul 31, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@github-actions github-actions bot added the author:obs-ux-management PRs authored by the obs ux management team label Jul 31, 2025
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benakansara benakansara enabled auto-merge (squash) July 31, 2025 20:12
@benakansara benakansara merged commit a11d199 into elastic:main Jul 31, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16661029253

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @benakansara

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
…astic#230125)

Resolves elastic#229343

- Handles `ruleParamsOfRecoveredAlert` being `undefined`

It's not clear what causes `ruleParamsOfRecoveredAlert` to be
`undefined`, I am still investigating the root cause. But in case it
becomes `undefined`, it will not fail rule execution.

(cherry picked from commit a11d199)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
…astic#230125)

Resolves elastic#229343

- Handles `ruleParamsOfRecoveredAlert` being `undefined`

It's not clear what causes `ruleParamsOfRecoveredAlert` to be
`undefined`, I am still investigating the root cause. But in case it
becomes `undefined`, it will not fail rule execution.

(cherry picked from commit a11d199)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 31, 2025
…rt (#230125) (#230142)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[APM rules] Handle rule params being undefined in recovered alert
(#230125)](#230125)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T22:06:35Z","message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[APM
rules] Handle rule params being undefined in recovered
alert","number":230125,"url":"https://github.com/elastic/kibana/pull/230125","mergeCommit":{"message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230125","number":230125,"mergeCommit":{"message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Aug 1, 2025
…ert (#230125) (#230141)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[APM rules] Handle rule params being undefined in recovered alert
(#230125)](#230125)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"69037875+benakansara@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T22:06:35Z","message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-infra_services","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","author:obs-ux-management","v9.2.0"],"title":"[APM
rules] Handle rule params being undefined in recovered
alert","number":230125,"url":"https://github.com/elastic/kibana/pull/230125","mergeCommit":{"message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/230125","number":230125,"mergeCommit":{"message":"[APM
rules] Handle rule params being undefined in recovered alert
(#230125)\n\nResolves
https://github.com/elastic/kibana/issues/229343\n\n- Handles
`ruleParamsOfRecoveredAlert` being `undefined`\n\nIt's not clear what
causes `ruleParamsOfRecoveredAlert` to be\n`undefined`, I am still
investigating the root cause. But in case it\nbecomes `undefined`, it
will not fail rule
execution.","sha":"a11d199b77eb317c0e63f7454fdae80c8f87e46b"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <69037875+benakansara@users.noreply.github.com>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
…astic#230125)

Resolves elastic#229343

- Handles `ruleParamsOfRecoveredAlert` being `undefined`

It's not clear what causes `ruleParamsOfRecoveredAlert` to be
`undefined`, I am still investigating the root cause. But in case it
becomes `undefined`, it will not fail rule execution.
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
…astic#230125)

Resolves elastic#229343

- Handles `ruleParamsOfRecoveredAlert` being `undefined`

It's not clear what causes `ruleParamsOfRecoveredAlert` to be
`undefined`, I am still investigating the root cause. But in case it
becomes `undefined`, it will not fail rule execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author:obs-ux-management PRs authored by the obs ux management team backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.19.0 v8.19.1 v9.1.0 v9.1.1 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

APM transaction duration rule type throwing errors on dereferencing undefined

4 participants