Skip to content

[kbn-plugin-helpers] move jest tests to integration suite #23005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spalger merged 1 commit into from
Sep 13, 2018
Merged

[kbn-plugin-helpers] move jest tests to integration suite #23005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...tures__/build_action_test_plugin/index.js → ...tures__/build_action_test_plugin/index.js
View file
Open in desktop
File renamed without changes.
0 ...s__/build_action_test_plugin/package.json → ...s__/build_action_test_plugin/package.json
View file
Open in desktop
File renamed without changes.
0 ..._/build_action_test_plugin/public/hack.js → ..._/build_action_test_plugin/public/hack.js
View file
Open in desktop
File renamed without changes.
0 ...d_action_test_plugin/translations/es.json → ...d_action_test_plugin/translations/es.json
View file
Open in desktop
File renamed without changes.
0 ...tures__/create_build_test_plugin/index.js → ...tures__/create_build_test_plugin/index.js
View file
Open in desktop
File renamed without changes.
0 ...s__/create_build_test_plugin/package.json → ...s__/create_build_test_plugin/package.json
View file
Open in desktop
File renamed without changes.
0 ..._/create_build_test_plugin/public/hack.js → ..._/create_build_test_plugin/public/hack.js
View file
Open in desktop
File renamed without changes.
0 ...eate_build_test_plugin/public/styles.scss → ...eate_build_test_plugin/public/styles.scss
View file
Open in desktop
File renamed without changes.
0 ...te_build_test_plugin/translations/es.json → ...te_build_test_plugin/translations/es.json
View file
Open in desktop
File renamed without changes.
0 ...res__/create_package_test_plugin/index.js → ...res__/create_package_test_plugin/index.js
View file
Open in desktop
File renamed without changes.
0 ..._/create_package_test_plugin/package.json → ..._/create_package_test_plugin/package.json
View file
Open in desktop
File renamed without changes.
0 ...create_package_test_plugin/public/hack.js → ...create_package_test_plugin/public/hack.js
View file
Open in desktop
File renamed without changes.
0 ..._package_test_plugin/translations/es.json → ..._package_test_plugin/translations/es.json
View file
Open in desktop
File renamed without changes.
0 ...d/__snapshots__/build_action.test.js.snap → ...s/__snapshots__/build_action.test.js.snap
View file
Open in desktop
File renamed without changes.
40 changes: 15 additions & 25 deletions ...-helpers/tasks/build/build_action.test.js → ...ld/integration_tests/build_action.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ const del = require('del');

const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/build_action_test_plugin');
const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build');
const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
const noop = () => {};

describe('creating build zip', () => {
const buildAction = require('./build_action');
const buildAction = require('../build_action');

beforeEach(() => del(PLUGIN_BUILD_DIR));
afterEach(() => del(PLUGIN_BUILD_DIR));
Expand Down Expand Up @@ -58,8 +58,16 @@ describe('calling create_build', () => {
beforeEach(() => {
jest.resetModules();
mockBuild = jest.fn(() => Promise.resolve());
jest.mock('./create_build', () => mockBuild);
buildAction = require('./build_action');
jest.mock('../create_build', () => mockBuild);
buildAction = require('../build_action');
});

const nameArgs = ([plugin, buildTarget, buildVersion, kibanaVersion, files]) => ({
plugin,
buildTarget,
buildVersion,
kibanaVersion,
files,
});

it('takes optional build version', async () => {
Expand All @@ -72,13 +80,7 @@ describe('calling create_build', () => {

expect(mockBuild.mock.calls).toHaveLength(1);

const [
plugin, // eslint-disable-line no-unused-vars
buildTarget, // eslint-disable-line no-unused-vars
buildVersion,
kibanaVersion,
files, // eslint-disable-line no-unused-vars
] = mockBuild.mock.calls[0];
const { buildVersion, kibanaVersion } = nameArgs(mockBuild.mock.calls[0]);
expect(buildVersion).toBe('1.2.3');
expect(kibanaVersion).toBe('4.5.6');
});
Expand All @@ -88,13 +90,7 @@ describe('calling create_build', () => {

expect(mockBuild.mock.calls).toHaveLength(1);

const [
plugin, // eslint-disable-line no-unused-vars
buildTarget, // eslint-disable-line no-unused-vars
buildVersion, // eslint-disable-line no-unused-vars
kibanaVersion, // eslint-disable-line no-unused-vars
files,
] = mockBuild.mock.calls[0];
const { files } = nameArgs(mockBuild.mock.calls[0]);
PLUGIN.buildSourcePatterns.forEach(file => expect(files).toContain(file));
});

Expand All @@ -107,13 +103,7 @@ describe('calling create_build', () => {

expect(mockBuild.mock.calls).toHaveLength(1);

const [
plugin, // eslint-disable-line no-unused-vars
buildTarget, // eslint-disable-line no-unused-vars
buildVersion, // eslint-disable-line no-unused-vars
kibanaVersion, // eslint-disable-line no-unused-vars
files,
] = mockBuild.mock.calls[0];
const { files } = nameArgs(mockBuild.mock.calls[0]);
options.files.forEach(file => expect(files).toContain(file));
});

Expand Down
4 changes: 2 additions & 2 deletions ...-helpers/tasks/build/create_build.test.js → ...ld/integration_tests/create_build.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
const { resolve } = require('path');
const { readdirSync, existsSync, unlink } = require('fs');
const del = require('del');
const createBuild = require('./create_build');
const createBuild = require('../create_build');

const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/create_build_test_plugin');
const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build');
const PLUGIN_BUILD_TARGET = resolve(PLUGIN_BUILD_DIR, 'kibana', PLUGIN.id);

Expand Down
6 changes: 3 additions & 3 deletions ...elpers/tasks/build/create_package.test.js → .../integration_tests/create_package.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@
const { resolve } = require('path');
const { statSync } = require('fs');
const del = require('del');
const createBuild = require('./create_build');
const createPackage = require('./create_package');
const createBuild = require('../create_build');
const createPackage = require('../create_package');

const PLUGIN_FIXTURE = resolve(__dirname, '__fixtures__/create_package_test_plugin');
const PLUGIN = require('../../lib/plugin_config')(PLUGIN_FIXTURE);
const PLUGIN = require('../../../lib/plugin_config')(PLUGIN_FIXTURE);
const PLUGIN_BUILD_DIR = resolve(PLUGIN_FIXTURE, 'build-custom');

const buildVersion = PLUGIN.version;
Expand Down