Skip to content

[ES|QL] Fixes the font sizes of the footer links #230025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stratoula merged 3 commits into from
Aug 1, 2025
Merged

[ES|QL] Fixes the font sizes of the footer links #230025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b674a16
[ES|QL] Fixes the font sizes of the footer links
stratoula Jul 31, 2025
fff0bc8
Revert some parts
stratoula Jul 31, 2025
d3f4e12
Update src/platform/packages/private/kbn-esql-editor/src/editor_foote…
stratoula Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 19 additions & 27 deletions src/platform/packages/private/kbn-esql-editor/src/editor_footer/feedback_component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

import React from 'react';
import { i18n } from '@kbn/i18n';
import { EuiFlexItem, EuiIcon, useEuiTheme, EuiLink, EuiToolTip, EuiFlexGroup } from '@elastic/eui';
import { EuiFlexItem, EuiIconTip, useEuiTheme, EuiLink, EuiButtonEmpty } from '@elastic/eui';
import { css } from '@emotion/react';
import { FEEDBACK_LINK } from '@kbn/esql-utils';

Expand All @@ -25,46 +25,38 @@ export function SubmitFeedbackComponent({ isSpaceReduced }: { isSpaceReduced?: b
target="_blank"
data-test-subj="ESQLEditor-feedback-link"
>
<EuiToolTip
position="top"
<EuiIconTip
type="editorComment"
color="primary"
size="m"
css={css`
margin-right: ${euiTheme.size.s};
`}
content={i18n.translate('esqlEditor.query.feedback', {
defaultMessage: 'Feedback',
})}
>
<EuiIcon
type="editorComment"
color="primary"
size="m"
css={css`
margin-right: ${euiTheme.size.s};
`}
/>
</EuiToolTip>
position="top"
/>
</EuiLink>
</EuiFlexItem>
)}
{!isSpaceReduced && (
<EuiLink
<EuiButtonEmpty
size="xs"
color="primary"
flush="both"
href={FEEDBACK_LINK}
external={false}
target="_blank"
css={css`
font-size: 12px;
margin-right: ${euiTheme.size.m};
`}
iconType="editorComment"
data-test-subj="ESQLEditor-feedback-link"
>
<EuiFlexGroup gutterSize="s" alignItems="center">
<EuiFlexItem grow={false}>
<EuiIcon type="editorComment" color="primary" size="s" />
</EuiFlexItem>
<EuiFlexItem grow={false}>
{i18n.translate('esqlEditor.query.submitFeedback', {
defaultMessage: 'Submit feedback',
})}
</EuiFlexItem>
</EuiFlexGroup>
</EuiLink>
{i18n.translate('esqlEditor.query.submitFeedback', {
defaultMessage: 'Submit feedback',
})}
</EuiButtonEmpty>
)}
</>
);
Expand Down
39 changes: 19 additions & 20 deletions src/platform/packages/private/kbn-esql-editor/src/editor_footer/history_starred_queries.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import { i18n } from '@kbn/i18n';
import {
EuiFlexGroup,
EuiFlexItem,
EuiIcon,
useEuiTheme,
EuiInMemoryTable,
EuiBasicTableColumn,
Expand All @@ -26,6 +25,9 @@ import {
EuiTabs,
EuiNotificationBadge,
EuiText,
EuiIconTip,
EuiLink,
EuiIcon,
} from '@elastic/eui';
import { useKibana } from '@kbn/kibana-react-plugin/public';
import { cssFavoriteHoverWithinEuiTableRow } from '@kbn/content-management-favorites-public';
Expand Down Expand Up @@ -53,34 +55,31 @@ export function QueryHistoryAction({
isHistoryOpen: boolean;
isSpaceReduced?: boolean;
}) {
const { euiTheme } = useEuiTheme();
return (
<>
{isSpaceReduced && (
<EuiFlexItem grow={false} data-test-subj="ESQLEditor-toggle-query-history-icon">
<EuiToolTip
position="top"
content={
isHistoryOpen
? i18n.translate('esqlEditor.query.hideQueriesLabel', {
defaultMessage: 'Hide recent queries',
})
: i18n.translate('esqlEditor.query.showQueriesLabel', {
defaultMessage: 'Show recent queries',
})
}
<EuiLink
onClick={toggleHistory}
external={false}
data-test-subj="ESQLEditor-hide-queries-link"
>
<EuiIcon
<EuiIconTip
type="clockCounter"
color="primary"
size="m"
onClick={toggleHistory}
css={css`
margin-right: ${euiTheme.size.s};
cursor: pointer;
`}
content={
isHistoryOpen
? i18n.translate('esqlEditor.query.hideQueriesLabel', {
defaultMessage: 'Hide recent queries',
})
: i18n.translate('esqlEditor.query.showQueriesLabel', {
defaultMessage: 'Show recent queries',
})
}
position="top"
/>
</EuiToolTip>
</EuiLink>
</EuiFlexItem>
)}
{!isSpaceReduced && (
Expand Down