Skip to content

[ES|QL] Fixes the font sizes of the footer links#230025

Merged
stratoula merged 3 commits intoelastic:mainfrom
stratoula:fix-font-sized-editor
Aug 1, 2025
Merged

[ES|QL] Fixes the font sizes of the footer links#230025
stratoula merged 3 commits intoelastic:mainfrom
stratoula:fix-font-sized-editor

Conversation

@stratoula
Copy link
Contributor

@stratoula stratoula commented Jul 31, 2025

Summary

Fixes the editor footer links to:

  • use the same DOM structure
  • the above fixed and the font sizes inconsistency
image

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.2.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// labels Aug 1, 2025
@stratoula stratoula marked this pull request as ready for review August 1, 2025 04:53
@stratoula stratoula requested a review from a team as a code owner August 1, 2025 04:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@sddonne sddonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

<EuiLink
onClick={toggleHistory}
external={false}
data-test-subj="ESQLEditor-feedback-link"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong test subject :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boooh, fixed d3f4e12

@stratoula stratoula enabled auto-merge (squash) August 1, 2025 08:01
@stratoula stratoula merged commit a00149d into elastic:main Aug 1, 2025
13 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 257.6KB 257.4KB -221.0B

History

szaffarano pushed a commit to szaffarano/kibana that referenced this pull request Aug 5, 2025
## Summary

Fixes the editor footer links to:

- use the same DOM structure
- the above fixed and the font sizes inconsistency


<img width="794" height="106" alt="image"
src="https://github.com/user-attachments/assets/24d77677-ce3f-42b4-8cb1-027ed937c782"
/>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
## Summary

Fixes the editor footer links to:

- use the same DOM structure
- the above fixed and the font sizes inconsistency


<img width="794" height="106" alt="image"
src="https://github.com/user-attachments/assets/24d77677-ce3f-42b4-8cb1-027ed937c782"
/>
@wildemat wildemat mentioned this pull request Aug 7, 2025
10 tasks
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Aug 18, 2025
## Summary

Fixes the editor footer links to:

- use the same DOM structure
- the above fixed and the font sizes inconsistency


<img width="794" height="106" alt="image"
src="https://github.com/user-attachments/assets/24d77677-ce3f-42b4-8cb1-027ed937c782"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants