[ES|QL] remove superfluous validation checks

src/platform/packages/shared/kbn-esql-ast/scripts/functions.ts

@@ -8,7 +8,6 @@
  */
 import type { RecursivePartial } from '@kbn/utility-types';
 import { FunctionDefinition, FunctionDefinitionTypes } from '../src/definitions/types';
-import { validateLogFunctions } from './validators';
 import {
   defaultScalarFunctionLocations,
   dateDiffSuggestions,
@@ -48,12 +47,6 @@ export const extraFunctions: FunctionDefinition[] = [
  * and, hence, won't be present in the JSON file.
  */
 export const functionEnrichments: Record<string, RecursivePartial<FunctionDefinition>> = {
-  log10: {
-    validate: validateLogFunctions,
-  },
-  log: {
-    validate: validateLogFunctions,
-  },
   date_diff: {
     signatures: [
       {

src/platform/packages/shared/kbn-esql-ast/scripts/generate_function_definitions.ts

@@ -18,7 +18,6 @@ import {
 } from '../src/definitions/types';
 import { Location } from '../src/commands_registry/types';
 import { FULL_TEXT_SEARCH_FUNCTIONS } from '../src/definitions/constants';
-import { mathValidators } from './validators';
 import {
   aliasTable,
   aliases,
@@ -149,7 +148,6 @@ const enrichGrouping = (
 const enrichOperators = (
   operatorsFunctionDefinitions: FunctionDefinition[]
 ): FunctionDefinition[] => {
-  // @ts-expect-error Stringified version of the validator function
   return operatorsFunctionDefinitions.map((op) => {
     const isMathOperator = MATH_OPERATORS.includes(op.name);
     const isComparisonOperator = COMPARISON_OPERATORS.includes(op.name);
@@ -231,7 +229,6 @@ const enrichOperators = (
       // so we are overriding to add proper support
       locationsAvailable,
       type: FunctionDefinitionTypes.OPERATOR,
-      validate: mathValidators[op.name],
     };
   });
 };
@@ -315,7 +312,6 @@ const ${getDefinitionName(name)}: FunctionDefinition = {
   signatures: ${JSON.stringify(signatures, null, 2)},
   locationsAvailable: [${locationsAvailable.join(', ')}],
   ${licenseField}
-  validate: ${functionDefinition.validate || 'undefined'},
   examples: ${JSON.stringify(functionDefinition.examples || [])},${
       customParametersSnippet
         ? `\ncustomParametersSnippet: ${JSON.stringify(customParametersSnippet)},`
@@ -346,17 +342,6 @@ const ${getDefinitionName(name)}: FunctionDefinition = {
 import { i18n } from '@kbn/i18n';
 import { Location } from '../../commands_registry/types';
 import { type FunctionDefinition, FunctionDefinitionTypes } from '../types';
-${
-  functionsType === FunctionDefinitionTypes.SCALAR
-    ? `import type { ESQLFunction } from '../../types';
-import { isLiteral } from '../../ast/is';;`
-    : ''
-}
-${
-  functionsType === FunctionDefinitionTypes.OPERATOR
-    ? `import { isNumericType } from '../types';`
-    : ''
-}
 
 
 

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/enrich/validate.test.ts

@@ -67,9 +67,6 @@ describe('ENRICH Validation', () => {
     enrichExpectErrors('from a_index | enrich `this``is fine`', ['Unknown policy [`this``is]']);
     enrichExpectErrors('from a_index | enrich this is fine', ['Unknown policy [this]']);
     enrichExpectErrors(`from a_index |enrich missing-policy `, ['Unknown policy [missing-policy]']);
-    enrichExpectErrors('from a_index | enrich my-pol*', [
-      'Using wildcards (*) in ENRICH is not allowed [my-pol*]',
-    ]);
   });
 
   test('validates the columns', () => {

src/platform/packages/shared/kbn-esql-ast/src/commands_registry/commands/enrich/validate.ts

@@ -12,10 +12,6 @@ import { ENRICH_MODES } from './util';
 import type { ESQLPolicy, ICommandContext, ICommandCallbacks } from '../../types';
 import { validateCommandArguments } from '../../../definitions/utils/validation';
 
-function hasWildcard(name: string) {
-  return /\*/.test(name);
-}
-
 export const validate = (
   command: ESQLCommand,
   ast: ESQLAst,
@@ -28,24 +24,14 @@ export const validate = (
   const index = source.index;
   const policies = context?.policies || new Map<string, ESQLPolicy>();
 
-  if (index) {
-    if (hasWildcard(index.valueUnquoted)) {
-      messages.push(
-        getMessageFromId({
-          messageId: 'wildcardNotSupportedForCommand',
-          values: { command: 'ENRICH', value: index.valueUnquoted },
-          locations: index.location,
-        })
-      );
-    } else if (!policies.has(index.valueUnquoted)) {
-      messages.push(
-        getMessageFromId({
-          messageId: 'unknownPolicy',
-          values: { name: index.valueUnquoted },
-          locations: index.location,
-        })
-      );
-    }
+  if (index && !policies.has(index.valueUnquoted)) {
+    messages.push(
+      getMessageFromId({
+        messageId: 'unknownPolicy',
+        values: { name: index.valueUnquoted },
+        locations: index.location,
+      })
+    );
   }
 
   if (cluster) {