[ES|QL] remove superfluous validation checks#230016
Merged
drewdaemon merged 43 commits intoelastic:mainfrom Aug 1, 2025
Merged
[ES|QL] remove superfluous validation checks#230016drewdaemon merged 43 commits intoelastic:mainfrom
drewdaemon merged 43 commits intoelastic:mainfrom
Conversation
drewdaemon
force-pushed
the
221230/remove-superfluous-checks
branch
from
3127be0 to
a56c928
Compare
15 tasks
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
|
drewdaemon
added
release_note:skip
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
stratoula
approved these changes
Aug 1, 2025
Contributor
stratoula
left a comment
stratoula
left a comment
There was a problem hiding this comment.
LGTM! Code review only
szaffarano
pushed a commit
to szaffarano/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Part of elastic#221230 **To remove** General - [x] Field shadowing (shadowFieldType) elastic@a56c928 - [x] Wild-card support in commands (wildcardNotSupportedForCommand) elastic@e82f11e Functions - [ ] Nested agg functions (will address these in elastic#180518) - [ ] Fields in constant-only positions (will address these in elastic#180518) - [x] Wild-card support (* — should mostly be covered by syntactical validation) elastic@e82f11e - [x] Specific functions (fnDefinition.validate) elastic@1c56b1b - [x] MATCH and QSTR after certain commands elastic@1c56b1b - [x] logOfNegativeValue warning for log functions elastic@1c56b1b - [x] divideByZero warning (4 / 0) elastic@1c56b1b - [x] moduleByZero warning (4 % 0) elastic@1c56b1b STATS - [x] No agg function elastic@ab71567 - [x] Combining agg and non-agg values elastic@ab71567 - [x] DISSECT append_separator unknownDissectKeyword elastic@ab71567 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
delanni
pushed a commit
to delanni/kibana
that referenced
this pull request
Aug 5, 2025
## Summary Part of elastic#221230 **To remove** General - [x] Field shadowing (shadowFieldType) elastic@a56c928 - [x] Wild-card support in commands (wildcardNotSupportedForCommand) elastic@e82f11e Functions - [ ] Nested agg functions (will address these in elastic#180518) - [ ] Fields in constant-only positions (will address these in elastic#180518) - [x] Wild-card support (* — should mostly be covered by syntactical validation) elastic@e82f11e - [x] Specific functions (fnDefinition.validate) elastic@1c56b1b - [x] MATCH and QSTR after certain commands elastic@1c56b1b - [x] logOfNegativeValue warning for log functions elastic@1c56b1b - [x] divideByZero warning (4 / 0) elastic@1c56b1b - [x] moduleByZero warning (4 % 0) elastic@1c56b1b STATS - [x] No agg function elastic@ab71567 - [x] Combining agg and non-agg values elastic@ab71567 - [x] DISSECT append_separator unknownDissectKeyword elastic@ab71567 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
NicholasPeretti
pushed a commit
to NicholasPeretti/kibana
that referenced
this pull request
Aug 18, 2025
## Summary Part of elastic#221230 **To remove** General - [x] Field shadowing (shadowFieldType) elastic@a56c928 - [x] Wild-card support in commands (wildcardNotSupportedForCommand) elastic@e82f11e Functions - [ ] Nested agg functions (will address these in elastic#180518) - [ ] Fields in constant-only positions (will address these in elastic#180518) - [x] Wild-card support (* — should mostly be covered by syntactical validation) elastic@e82f11e - [x] Specific functions (fnDefinition.validate) elastic@1c56b1b - [x] MATCH and QSTR after certain commands elastic@1c56b1b - [x] logOfNegativeValue warning for log functions elastic@1c56b1b - [x] divideByZero warning (4 / 0) elastic@1c56b1b - [x] moduleByZero warning (4 % 0) elastic@1c56b1b STATS - [x] No agg function elastic@ab71567 - [x] Combining agg and non-agg values elastic@ab71567 - [x] DISSECT append_separator unknownDissectKeyword elastic@ab71567 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
|
Hello @drewdaemon ! |
Contributor
Author
|
Hi @rodrigomadalozzo ! We didn't really see this particular change as a bug fix, just a strategic simplification. If you're encountering incorrect validation errors on an older version, unfortunately there isn't much to do except ignore them and submit your query. We know the validation has had bugs... Feel free to reach out if you have more questions or a specific issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #221230
To remove
General
Functions
STATS
Checklist