[9.1] [ska] remove test-helper imports that lead to circular dependencies issue (#229587)#230006
Merged
dmlemeshko merged 2 commits intoelastic:9.1from Jul 31, 2025
Merged
Conversation
…ssue (elastic#229587) ## Summary This PR is a preparation before moving solution tests from `x-pack/test_serverless`. Since we move tests in chunks, having backward imports (solution imports in "platform" code) will lead to circular dependency issue. And we can't move all in 1 PR, it is just too much code. This PR temporarily copies helpers/constants/page objects to `x-pack/test_serverless` so that directory has only imports from `kbn/test-suites-xpack-platform` and not solutions. Duplicates will be removed after we finish relocating all the Security Solution tests. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 83029af) # Conflicts: # x-pack/test_serverless/tsconfig.json
Contributor
💚 Build Succeeded
Metrics [docs]
|
fake-haris
approved these changes
Jul 31, 2025
dmlemeshko
added a commit
that referenced
this pull request
Aug 12, 2025
…ncies issue (#229587) (#231326) # Backport This will backport the following commits from `main` to `8.19`: - [[ska] remove test-helper imports that lead to circular dependencies issue (#229587)](#229587) <!--- Backport version: 10.0.1 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Dzmitry Lemechko","email":"dzmitry.lemechko@elastic.co"},"sourceCommit":{"committedDate":"2025-07-28T14:21:14Z","message":"[ska] remove test-helper imports that lead to circular dependencies issue (#229587)\n\n## Summary\n\nThis PR is a preparation before moving solution tests from\n`x-pack/test_serverless`. Since we move tests in chunks, having backward\nimports (solution imports in \"platform\" code) will lead to circular\ndependency issue. And we can't move all in 1 PR, it is just too much\ncode.\n\nThis PR temporarily copies helpers/constants/page objects to\n`x-pack/test_serverless` so that directory has only imports from\n`kbn/test-suites-xpack-platform` and not solutions. Duplicates will be\nremoved after we finish relocating all the Security Solution tests.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83029af8a13b74b4f3c70da2cb4c330ac03edcf1","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[ska] remove test-helper imports that lead to circular dependencies issue","number":229587,"url":"https://github.com/elastic/kibana/pull/229587","mergeCommit":{"message":"[ska] remove test-helper imports that lead to circular dependencies issue (#229587)\n\n## Summary\n\nThis PR is a preparation before moving solution tests from\n`x-pack/test_serverless`. Since we move tests in chunks, having backward\nimports (solution imports in \"platform\" code) will lead to circular\ndependency issue. And we can't move all in 1 PR, it is just too much\ncode.\n\nThis PR temporarily copies helpers/constants/page objects to\n`x-pack/test_serverless` so that directory has only imports from\n`kbn/test-suites-xpack-platform` and not solutions. Duplicates will be\nremoved after we finish relocating all the Security Solution tests.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83029af8a13b74b4f3c70da2cb4c330ac03edcf1"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229587","number":229587,"mergeCommit":{"message":"[ska] remove test-helper imports that lead to circular dependencies issue (#229587)\n\n## Summary\n\nThis PR is a preparation before moving solution tests from\n`x-pack/test_serverless`. Since we move tests in chunks, having backward\nimports (solution imports in \"platform\" code) will lead to circular\ndependency issue. And we can't move all in 1 PR, it is just too much\ncode.\n\nThis PR temporarily copies helpers/constants/page objects to\n`x-pack/test_serverless` so that directory has only imports from\n`kbn/test-suites-xpack-platform` and not solutions. Duplicates will be\nremoved after we finish relocating all the Security Solution tests.\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"83029af8a13b74b4f3c70da2cb4c330ac03edcf1"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/230006","number":230006,"state":"MERGED","mergeCommit":{"sha":"d4b9bb4c78f908e4460100d50cd952128419269c","message":"[9.1] [ska] remove test-helper imports that lead to circular dependencies issue (#229587) (#230006)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.1`:\n- [[ska] remove test-helper imports that lead to circular dependencies\nissue (#229587)](https://github.com/elastic/kibana/pull/229587)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.1:Questions ?
Please refer to the Backport tool documentation