[8.19] [ska] remove test-helper imports that lead to circular dependencies issue (#229587) #231326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssue (elastic#229587) ## Summary This PR is a preparation before moving solution tests from `x-pack/test_serverless`. Since we move tests in chunks, having backward imports (solution imports in "platform" code) will lead to circular dependency issue. And we can't move all in 1 PR, it is just too much code. This PR temporarily copies helpers/constants/page objects to `x-pack/test_serverless` so that directory has only imports from `kbn/test-suites-xpack-platform` and not solutions. Duplicates will be removed after we finish relocating all the Security Solution tests. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 83029af) # Conflicts: # x-pack/test_serverless/api_integration/test_suites/security/cloud_security_posture/serverless_metering/cloud_security_metering.ts # x-pack/test_serverless/api_integration/test_suites/security/cloud_security_posture/status/status_indexed.ts # x-pack/test_serverless/tsconfig.json
…a into backport/8.19/pr-229587
csr
approved these changes
Aug 12, 2025
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation