Skip to content

[Lens] Fix extra padding below Advanced Options when in inline editing #229967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dej611 merged 2 commits into from
Jul 31, 2025
Merged

[Lens] Fix extra padding below Advanced Options when in inline editing #229967

dej611 merged 2 commits into from
Jul 31, 2025

Conversation

@dej611
Copy link
Contributor

@dej611 dej611 commented Jul 30, 2025 •
edited by kibanamachine
Loading

Summary

Fixes #229941

This PR scopes a specific regression introduced by a fix in #228957 to ES|QL editing only where Advanced Options are not available.

Chrome:

Screenshot 2025-07-30 at 16 07 04 Screenshot 2025-07-30 at 16 06 52

Showing Safari as well for the Query result panel:
Screenshot 2025-07-30 at 16 08 23
Screenshot 2025-07-30 at 16 08 09

@dej611 dej611 requested a review from a team as a code owner July 30, 2025 14:13
@dej611 dej611 added release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// Feature:Lens backport:version Backport to applied version labels v9.2.0 v9.1.1 v8.19.1 labels Jul 30, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2025

Pinging @elastic/kibana-visualizations (Team:Visualizations)

dej611
dej611 commented Jul 30, 2025
View reviewed changes
...m/plugins/shared/lens/public/app_plugin/shared/edit_on_the_fly/lens_configuration_flyout.tsx
padding: 2px;
}
`}
padding: 2px;
Copy link
Contributor Author

@dej611 dej611 Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've noticed a lone closing bracket here so I've removed it

@andrimal
Copy link
Contributor

andrimal commented Jul 30, 2025

Checked locally and extra padding issue is fixed 🚀

@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 30, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +13.0B

@dej611 dej611 merged commit 4f3380c into elastic:main Jul 31, 2025
12 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2025

Starting backport for target branches: 8.19, 9.1

https://github.com/elastic/kibana/actions/runs/16644249629

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
@dej611
[Lens] Fix extra padding below Advanced Options when in inline editing (
cfc588e 
elastic#229967)

## Summary

Fixes elastic#229941

This PR scopes a specific regression introduced by a fix in
elastic#228957 to ES|QL editing only
where `Advanced Options` are not available.

Chrome:

<img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04"
src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a"
/>
<img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52"
src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964"
/>

Showing Safari as well for the Query result panel:
<img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23"
src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f"
/>
<img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09"
src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42"
/>

(cherry picked from commit 4f3380c)
@kibanamachine kibanamachine mentioned this pull request Jul 31, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 31, 2025
@dej611
[Lens] Fix extra padding below Advanced Options when in inline editing (
7d084cb 
elastic#229967)

## Summary

Fixes elastic#229941

This PR scopes a specific regression introduced by a fix in
elastic#228957 to ES|QL editing only
where `Advanced Options` are not available.

Chrome:

<img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04"
src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a"
/>
<img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52"
src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964"
/>

Showing Safari as well for the Query result panel:
<img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23"
src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f"
/>
<img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09"
src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42"
/>

(cherry picked from commit 4f3380c)
@kibanamachine kibanamachine mentioned this pull request Jul 31, 2025
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 31, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.19
✅ 9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 31, 2025
@kibanamachine @dej611
[9.1] [Lens] Fix extra padding below Advanced Options when in inline …
0ec885f 
…editing (#229967) (#230040)

# Backport

This will backport the following commits from `main` to `9.1`:
- [[Lens] Fix extra padding below Advanced Options when in inline
editing (#229967)](#229967)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T08:42:23Z","message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[Lens]
Fix extra padding below Advanced Options when in inline
editing","number":229967,"url":"https://github.com/elastic/kibana/pull/229967","mergeCommit":{"message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229967","number":229967,"mergeCommit":{"message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 31, 2025
@kibanamachine @dej611
[8.19] [Lens] Fix extra padding below Advanced Options when in inline…
b4613f2 
… editing (#229967) (#230039)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[Lens] Fix extra padding below Advanced Options when in inline
editing (#229967)](#229967)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"dej611@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-31T08:42:23Z","message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Visualizations","Feature:Lens","backport:version","v9.2.0","v9.1.1","v8.19.1"],"title":"[Lens]
Fix extra padding below Advanced Options when in inline
editing","number":229967,"url":"https://github.com/elastic/kibana/pull/229967","mergeCommit":{"message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},"sourceBranch":"main","suggestedTargetBranches":["9.1","8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/229967","number":229967,"mergeCommit":{"message":"[Lens]
Fix extra padding below Advanced Options when in inline editing
(#229967)\n\n## Summary\n\nFixes #229941 \n\nThis PR scopes a specific
regression introduced by a fix
in\nhttps://github.com//pull/228957 to ES|QL editing
only\nwhere `Advanced Options` are not available.\n\nChrome:\n\n<img
width=\"1174\" height=\"889\" alt=\"Screenshot 2025-07-30 at 16 07
04\"\nsrc=\"https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a\"\n/>\n<img
width=\"1913\" height=\"892\" alt=\"Screenshot 2025-07-30 at 16 06
52\"\nsrc=\"https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964\"\n/>\n\nShowing
Safari as well for the Query result panel:\n<img width=\"973\"
height=\"725\" alt=\"Screenshot 2025-07-30 at 16 08
23\"\nsrc=\"https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f\"\n/>\n<img
width=\"1499\" height=\"754\" alt=\"Screenshot 2025-07-30 at 16 08
09\"\nsrc=\"https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42\"\n/>","sha":"4f3380cfaaf65e8f1b3a75dd1bf34ab23778965f"}},{"branch":"9.1","label":"v9.1.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
delanni pushed a commit to delanni/kibana that referenced this pull request Aug 5, 2025
@dej611 @delanni
[Lens] Fix extra padding below Advanced Options when in inline editing (
a089c8a 
elastic#229967)

## Summary

Fixes elastic#229941 

This PR scopes a specific regression introduced by a fix in
elastic#228957 to ES|QL editing only
where `Advanced Options` are not available.

Chrome:

<img width="1174" height="889" alt="Screenshot 2025-07-30 at 16 07 04"
src="https://github.com/user-attachments/assets/a6870dcb-3097-4be4-b70e-a3a932a89f7a"
/>
<img width="1913" height="892" alt="Screenshot 2025-07-30 at 16 06 52"
src="https://github.com/user-attachments/assets/0adeb1c2-5924-4e31-949b-c6e8f0776964"
/>

Showing Safari as well for the Query result panel:
<img width="973" height="725" alt="Screenshot 2025-07-30 at 16 08 23"
src="https://github.com/user-attachments/assets/38c407c5-c6f8-46e5-8c90-661b8f26366f"
/>
<img width="1499" height="754" alt="Screenshot 2025-07-30 at 16 08 09"
src="https://github.com/user-attachments/assets/601bd62a-94ef-417c-8e90-77f971c35e42"
/>
@wildemat wildemat mentioned this pull request Aug 7, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrimal andrimal andrimal approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.19.0 v8.19.1 v9.1.1 v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Inline editor gets extra padding below the Advanced section when editing a dimension

4 participants

@dej611 @elasticmachine @andrimal @kibanamachine